You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/06/08 19:36:55 UTC
[GitHub] [apisix] Yiyiyimu commented on a change in pull request #4391: feat(mqtt-proxy): support domain
Yiyiyimu commented on a change in pull request #4391:
URL: https://github.com/apache/apisix/pull/4391#discussion_r647739171
##########
File path: docs/zh/latest/plugins/mqtt-proxy.md
##########
@@ -45,7 +45,8 @@ title: mqtt-proxy
| -------------- | ------- | ------ | ------ | ------ | ------------------------------------------------------ |
| protocol_name | string | 必须 | | | 协议名称，正常情况下应为“ MQTT” |
| protocol_level | integer | 必须 | | | 协议级别，MQTT `3.1.*` 应为 `4` ，MQTT `5.0` 应是`5`。 |
-| upstream.ip | string | 必须 | | | 将当前请求转发到的上游的 IP 地址 |
+| upstream.host | string | 必须 | | | 将当前请求转发到的上游的 IP 地址或域名 |
+| upstream.ip | string | 必须 | | | 推荐使用“host”代替。将当前请求转发到的上游的 IP 地址 |
Review comment:
since we only need one of them, naming both of them 'required' might lead to misunderstanding
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org