You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2019/12/11 19:32:18 UTC

[Impala-ASF-CR] [DOCS] Impala is not optimized for the IN operator when accessing HBASE

Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14891


Change subject: [DOCS] Impala is not optimized for the IN operator when accessing HBASE
......................................................................

[DOCS] Impala is not optimized for the IN operator when accessing HBASE

Change-Id: I37337a18c7add3c64795b3b2e49670493a9a8e44
---
M docs/topics/impala_hbase.xml
1 file changed, 10 insertions(+), 9 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/91/14891/1
-- 
To view, visit http://gerrit.cloudera.org:8080/14891
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I37337a18c7add3c64795b3b2e49670493a9a8e44
Gerrit-Change-Number: 14891
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>

[Impala-ASF-CR] [DOCS] Impala is not optimized for the IN operator when accessing HBASE

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/14891 )

Change subject: [DOCS] Impala is not optimized for the IN operator when accessing HBASE
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/14891/1/docs/topics/impala_hbase.xml
File docs/topics/impala_hbase.xml:

http://gerrit.cloudera.org:8080/#/c/14891/1/docs/topics/impala_hbase.xml@184
PS1, Line 184:         queries will perform comparisons in the <codeph>WHERE</codeph> against
> ... in the WHERE clause...
Done


http://gerrit.cloudera.org:8080/#/c/14891/1/docs/topics/impala_hbase.xml@188
PS1, Line 188: conditional tests
> predicates
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/14891
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37337a18c7add3c64795b3b2e49670493a9a8e44
Gerrit-Change-Number: 14891
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 Dec 2019 19:43:44 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] [DOCS] Impala is not optimized for the IN operator when accessing HBASE

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14891 )

Change subject: [DOCS] Impala is not optimized for the IN operator when accessing HBASE
......................................................................


Patch Set 1:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/555/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/14891
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37337a18c7add3c64795b3b2e49670493a9a8e44
Gerrit-Change-Number: 14891
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 Dec 2019 19:32:29 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] [DOCS] Impala is not optimized for the IN operator when accessing HBASE

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/14891 )

Change subject: [DOCS] Impala is not optimized for the IN operator when accessing HBASE
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14891/2/docs/topics/impala_hbase.xml
File docs/topics/impala_hbase.xml:

http://gerrit.cloudera.org:8080/#/c/14891/2/docs/topics/impala_hbase.xml@114
PS2, Line 114: clauses
singular, the whole (WHERE ...) part is called the where clause



-- 
To view, visit http://gerrit.cloudera.org:8080/14891
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37337a18c7add3c64795b3b2e49670493a9a8e44
Gerrit-Change-Number: 14891
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 Dec 2019 19:54:49 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] [DOCS] Impala is not optimized for the IN operator when accessing HBASE

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/14891 )

Change subject: [DOCS] Impala is not optimized for the IN operator when accessing HBASE
......................................................................


Patch Set 1: Code-Review+2

(2 comments)

http://gerrit.cloudera.org:8080/#/c/14891/1/docs/topics/impala_hbase.xml
File docs/topics/impala_hbase.xml:

http://gerrit.cloudera.org:8080/#/c/14891/1/docs/topics/impala_hbase.xml@184
PS1, Line 184:         queries will perform comparisons in the <codeph>WHERE</codeph> against
... in the WHERE clause...


http://gerrit.cloudera.org:8080/#/c/14891/1/docs/topics/impala_hbase.xml@188
PS1, Line 188: conditional tests
predicates



-- 
To view, visit http://gerrit.cloudera.org:8080/14891
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37337a18c7add3c64795b3b2e49670493a9a8e44
Gerrit-Change-Number: 14891
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 Dec 2019 19:40:21 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] [DOCS] Impala is not optimized for the IN operator when accessing HBASE

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14891 )

Change subject: [DOCS] Impala is not optimized for the IN operator when accessing HBASE
......................................................................


Patch Set 3: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/557/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/14891
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37337a18c7add3c64795b3b2e49670493a9a8e44
Gerrit-Change-Number: 14891
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 Dec 2019 20:22:33 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] [DOCS] Impala is not optimized for the IN operator when accessing HBASE

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Lars Volker, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/14891

to look at the new patch set (#2).

Change subject: [DOCS] Impala is not optimized for the IN operator when accessing HBASE
......................................................................

[DOCS] Impala is not optimized for the IN operator when accessing HBASE

Change-Id: I37337a18c7add3c64795b3b2e49670493a9a8e44
---
M docs/topics/impala_hbase.xml
1 file changed, 16 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/91/14891/2
-- 
To view, visit http://gerrit.cloudera.org:8080/14891
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I37337a18c7add3c64795b3b2e49670493a9a8e44
Gerrit-Change-Number: 14891
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>

[Impala-ASF-CR] [DOCS] Impala is not optimized for the IN operator when accessing HBASE

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14891 )

Change subject: [DOCS] Impala is not optimized for the IN operator when accessing HBASE
......................................................................


Patch Set 3:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/557/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/14891
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37337a18c7add3c64795b3b2e49670493a9a8e44
Gerrit-Change-Number: 14891
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 Dec 2019 20:01:48 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] [DOCS] Impala is not optimized for the IN operator when accessing HBASE

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14891 )

Change subject: [DOCS] Impala is not optimized for the IN operator when accessing HBASE
......................................................................

[DOCS] Impala is not optimized for the IN operator when accessing HBASE

Change-Id: I37337a18c7add3c64795b3b2e49670493a9a8e44
Reviewed-on: http://gerrit.cloudera.org:8080/14891
Reviewed-by: Lars Volker <lv...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M docs/topics/impala_hbase.xml
1 file changed, 16 insertions(+), 15 deletions(-)

Approvals:
  Lars Volker: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/14891
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I37337a18c7add3c64795b3b2e49670493a9a8e44
Gerrit-Change-Number: 14891
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>

[Impala-ASF-CR] [DOCS] Impala is not optimized for the IN operator when accessing HBASE

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/14891 )

Change subject: [DOCS] Impala is not optimized for the IN operator when accessing HBASE
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/14891
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37337a18c7add3c64795b3b2e49670493a9a8e44
Gerrit-Change-Number: 14891
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 Dec 2019 20:04:02 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] [DOCS] Impala is not optimized for the IN operator when accessing HBASE

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14891 )

Change subject: [DOCS] Impala is not optimized for the IN operator when accessing HBASE
......................................................................


Patch Set 2: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/556/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/14891
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37337a18c7add3c64795b3b2e49670493a9a8e44
Gerrit-Change-Number: 14891
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 Dec 2019 19:56:31 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] [DOCS] Impala is not optimized for the IN operator when accessing HBASE

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/14891 )

Change subject: [DOCS] Impala is not optimized for the IN operator when accessing HBASE
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14891/2/docs/topics/impala_hbase.xml
File docs/topics/impala_hbase.xml:

http://gerrit.cloudera.org:8080/#/c/14891/2/docs/topics/impala_hbase.xml@114
PS2, Line 114: clauses
> singular, the whole (WHERE ...) part is called the where clause
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/14891
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37337a18c7add3c64795b3b2e49670493a9a8e44
Gerrit-Change-Number: 14891
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 Dec 2019 20:00:56 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] [DOCS] Impala is not optimized for the IN operator when accessing HBASE

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14891 )

Change subject: [DOCS] Impala is not optimized for the IN operator when accessing HBASE
......................................................................


Patch Set 1: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/555/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/14891
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37337a18c7add3c64795b3b2e49670493a9a8e44
Gerrit-Change-Number: 14891
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 Dec 2019 19:55:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] [DOCS] Impala is not optimized for the IN operator when accessing HBASE

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14891 )

Change subject: [DOCS] Impala is not optimized for the IN operator when accessing HBASE
......................................................................


Patch Set 2:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/556/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/14891
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37337a18c7add3c64795b3b2e49670493a9a8e44
Gerrit-Change-Number: 14891
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 Dec 2019 19:44:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] [DOCS] Impala is not optimized for the IN operator when accessing HBASE

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Lars Volker, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/14891

to look at the new patch set (#3).

Change subject: [DOCS] Impala is not optimized for the IN operator when accessing HBASE
......................................................................

[DOCS] Impala is not optimized for the IN operator when accessing HBASE

Change-Id: I37337a18c7add3c64795b3b2e49670493a9a8e44
---
M docs/topics/impala_hbase.xml
1 file changed, 16 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/91/14891/3
-- 
To view, visit http://gerrit.cloudera.org:8080/14891
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I37337a18c7add3c64795b3b2e49670493a9a8e44
Gerrit-Change-Number: 14891
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>