[GitHub] [ozone] bshashikant commented on a change in pull request #2224: HDDS-5173. Divide snapshot related work into notifyInstallSnapshotFromLeader and reinitialize for SCMStateMachine.

[GitBox <gi...@apache.org>]

bshashikant commented on a change in pull request #2224:
URL: https://github.com/apache/ozone/pull/2224#discussion_r629138201



##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMStateMachine.java
##########
@@ -76,6 +78,11 @@
   private final boolean isInitialized;
   private ExecutorService installSnapshotExecutor;
 
+  // The atomic variable RaftServerImpl#inProgressInstallSnapshotRequest
+  // ensures serializable between notifyInstallSnapshotFromLeader()
+  // and reinitialize().
+  private DBCheckpoint installingDBCheckpoint;
+

Review comment:
       Once, the installSnaoshot completes, i guess, we need to set the "IntsallingCheckpoint" filed to null. Also, before the downloadSnaoshot icall is invoked, we should add a precondition check that installingCheckpoint is null always.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org