You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/05/27 04:10:11 UTC

[GitHub] [calcite] DonnyZone commented on a change in pull request #1988: [CALCITE-4019] Visit SqlInsert with SqlShuttle cause NullPointerException

DonnyZone commented on a change in pull request #1988:
URL: https://github.com/apache/calcite/pull/1988#discussion_r430830028



##########
File path: core/src/main/java/org/apache/calcite/sql/SqlInsert.java
##########
@@ -62,7 +62,11 @@ public SqlOperator getOperator() {
   }
 
   public List<SqlNode> getOperandList() {
-    return ImmutableNullableList.of(keywords, targetTable, source, columnList);
+    if (columnList == null) {

Review comment:
       Is it possible that `targetTable` is `null` or `source` is `null`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org