You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@maven.apache.org by Adam Monsen <ha...@gmail.com> on 2010/05/14 01:17:26 UTC

buildnumber-maven-plugin, git

Some awesome folks have created a patch to the
buildnumber-maven-plugin that supports Git. Apparently it works, but
the integration tests do not pass. Is anyone interested in helping
make the tests pass? If not, perhaps someone could offer some advice
on how to debug plugin integration tests?


Justin(?) said, on May 11th:
> Ah yes I also got that. I disabled the "itest"
> section of the pom.
>
> I'll send it to you soon.
>
> Regards
> Justin

---------- Forwarded message ----------
From: Antony Stubbs
Date: Tue, May 11, 2010 at 12:53 PM
Subject: Re: buildnumber-maven-plugin, git
To: Adam Monsen <ha...@gmail.com>
Cc: Nigel Magnay, Markus Heberling


I use my build every day, it definitely works for me. However, yes, I
noticed the failure and disabled the tests! ;) but yes, the git
integration works fine. I welcome a patch to fix the integration
tests...

Regards
Antony

On 12/05/2010, at 4:06, Adam Monsen wrote:
> Hi there! Sorry to trouble you all. I ran across
> http://stackoverflow.com/questions/2685069/maven-buildnumber-plugin-git
> , and it led me to you folks. I'm a software engineer on Mifos.
>
> Do any of you have a working version of buildnumber-maven-plugin with
> git support? I tried building from 14001f of
> http://github.com/astubbs/buildnumber-maven-plugin/ , but I get an
> "embedded error". I think an integration test is failing, and I forget
> how to debug these integration tests. The build passes for me for the
> upstream code (r11906 of
> http://svn.codehaus.org/mojo/trunk/mojo/buildnumber-maven-plugin ).
>
> Anyway, I'd like to help, let me know if you'd like to collaborate.

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
For additional commands, e-mail: users-help@maven.apache.org


Re: buildnumber-maven-plugin, git

Posted by Espen Wiborg <es...@telio.no>.
Adam Monsen <ha...@gmail.com> writes:

> On Thu, May 13, 2010 at 4:17 PM, Adam Monsen wrote:
>> Some awesome folks have created a patch to the
>> buildnumber-maven-plugin that supports Git. Apparently it works, but
>> the integration tests do not pass. Is anyone interested in helping
>> make the tests pass? If not, perhaps someone could offer some advice
>> on how to debug plugin integration tests?
>
> (the following was crossposted to the git mailing list)
>
> FYI, I gave up trying to fix the integration tests, or to modify the
> plugin to suit my needs. I instead used groovy script right in my
> POM, and set project properties that are filtered into a file
> included in our war.
<-snip->

FWIW: I fixed the problems with the ITs; the result can be found at
http://github.com/espenhw/buildnumber-maven-plugin

-- 
Espen Wiborg <es...@telio.no> - Veritas vos liberabit
God grant us the serenity to accept the things we cannot change, courage to
change the things we can, and wisdom to know the difference.

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
For additional commands, e-mail: users-help@maven.apache.org


Re: buildnumber-maven-plugin, git

Posted by Adam Monsen <ha...@gmail.com>.
On Thu, May 13, 2010 at 4:17 PM, Adam Monsen wrote:
> Some awesome folks have created a patch to the
> buildnumber-maven-plugin that supports Git. Apparently it works, but
> the integration tests do not pass. Is anyone interested in helping
> make the tests pass? If not, perhaps someone could offer some advice
> on how to debug plugin integration tests?

(the following was crossposted to the git mailing list)

FYI, I gave up trying to fix the integration tests, or to modify the
plugin to suit my needs. I instead used groovy script right in my
POM, and set project properties that are filtered into a file
included in our war.

Here's the Groovy snippet I used, modified to have shorter names to
prevent wrapping:

  def env = System.getenv()
  def gitcmd = "git"
  if (env['OS'] =~ /^Windows/)
      gitcmd = "cmd /c ${gitcmd}"
  def gcmd = """${gitcmd} log --pretty=format:%H -n1""".execute()
  project.properties['mifos_commit'] = gcmd.in.text
  project.properties['mifos_build'] = env['BUILD_TAG'] ?: 'DEV'
  project.properties['mifos_date'] = "" + new Date()

"BUILD_TAG" is something set by the Hudson continuous integration
server (that's what we use).

Here's the script, in vivo (commit 5dfe4d1abda09713b296ea2524):
http://tinyurl.com/3xcxp9n

I figured trading lots of lines of Java, XML, etc. for 8 lines of
maintainable/portable Groovy was a good move.

Hope this helps someone else using Maven and git who needs build
identifiers available as properties,
-Adam

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
For additional commands, e-mail: users-help@maven.apache.org