You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2019/06/06 23:24:57 UTC

Review Request 70796: WIP: Fix Mesos unit tests after API change.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70796/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov and Joseph Wu.


Repository: mesos


Description
-------

WIP: Fix Mesos unit tests after API change.


Diffs
-----

  src/tests/master_tests.cpp 097f1b77a59e29c6690210773d1556ebf2bb701e 


Diff: https://reviews.apache.org/r/70796/diff/1/


Testing
-------


Thanks,

Benno Evers


Re: Review Request 70796: Fixed Mesos unit tests after Address API change.

Posted by Till Toenshoff via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70796/#review216016
-----------------------------------------------------------


Ship it!




- Till Toenshoff


On June 19, 2019, 2:44 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70796/
> -----------------------------------------------------------
> 
> (Updated June 19, 2019, 2:44 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Joseph Wu, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adjusts some Mesos unit tests after renaming
> `Address::hostname()` to `Address::lookup_hostname()`.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_tests.cpp 097f1b77a59e29c6690210773d1556ebf2bb701e 
> 
> 
> Diff: https://reviews.apache.org/r/70796/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Re: Review Request 70796: Fixed Mesos unit tests after Address API change.

Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70796/
-----------------------------------------------------------

(Updated June 19, 2019, 2:44 p.m.)


Review request for mesos, Alexander Rukletsov, Joseph Wu, and Till Toenshoff.


Summary (updated)
-----------------

Fixed Mesos unit tests after Address API change.


Repository: mesos


Description (updated)
-------

Adjusted some Mesos unit tests after the renaming
of `Address::hostname()` -> `Address::lookup_hostname()`.


Diffs (updated)
-----

  src/tests/master_tests.cpp 097f1b77a59e29c6690210773d1556ebf2bb701e 


Diff: https://reviews.apache.org/r/70796/diff/2/

Changes: https://reviews.apache.org/r/70796/diff/1-2/


Testing
-------


Thanks,

Benno Evers