You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/12 17:13:30 UTC

[GitHub] [pulsar] michaeljmarshall commented on pull request #15122: Add a cache of versioned KeyValueSchemaImpl

michaeljmarshall commented on PR #15122:
URL: https://github.com/apache/pulsar/pull/15122#issuecomment-1096985919

   @cbornet - in that case, I don't think this PR should be labeled as fixing #15118. It seems you've identified two problems, and we should fix both.
   
   One question about your caching solution. It seems your solution does not expire cache entries. I am not familiar with schema management, but wouldn't it make sense to use a caffeine cache to prevent unbounded growth on the `schemaMap` map?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org