You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/03/16 05:50:50 UTC
[GitHub] [cloudstack] Pearl1594 opened a new pull request #4822: listprojects: Maintain order or project owners added to account
Pearl1594 opened a new pull request #4822:
URL: https://github.com/apache/cloudstack/pull/4822
### Description
This PR ensures to list the projects owners in the order in which they were added.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [X] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [X] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
Prior to fix, listing projects didn't necessarily return a list of project owners in the order in which they were added.
```
Added an account (ACSUser)
(admin) SBCM5> > list projects listall=true filter=owner,id,name,
{
"count": 1,
"project": [
{
"id": "a81b8ec4-fa61-4e17-9383-1083276c18df",
"name": "p1",
"owner": [
{
"account": "ACSUser"
}
]
}
]
}
Added Admin account
(admin) SBCM5> > list projects listall=true filter=owner,id,name,
{
"count": 1,
"project": [
{
"id": "a81b8ec4-fa61-4e17-9383-1083276c18df",
"name": "p1",
"owner": [
{
"account": "admin"
},
{
"account": "ACSUser"
}
]
}
]
}
Added user (u1)
(admin) SBCM5> > list projects listall=true filter=owner,id,name,
{
"count": 1,
"project": [
{
"id": "a81b8ec4-fa61-4e17-9383-1083276c18df",
"name": "p1",
"owner": [
{
"account": "ACSUser"
},
{
"account": "admin"
},
{
"account": "u1",
"user": "u1",
"userid": "603d77db-bd46-4f06-9c71-18ccd0211f8d"
}
]
}
]
}
```
Notice that the order of the account/user admins of a project is not the same as the order in which they were added to the project
With this fix, the order of the owners in maintained.
```
(admin) SBCM5> > list projects listall=true filter=owner,id,name,
{
"count": 1,
"project": [
{
"id": "a81b8ec4-fa61-4e17-9383-1083276c18df",
"name": "p1",
"owner": [
{
"account": "ACSUser"
}
]
}
]
}
(admin) SBCM5> > list projects listall=true filter=owner,id,name,
{
"count": 1,
"project": [
{
"id": "a81b8ec4-fa61-4e17-9383-1083276c18df",
"name": "p1",
"owner": [
{
"account": "ACSUser"
},
{
"account": "admin"
}
]
}
]
}
(admin) SBCM5> > list projects listall=true filter=owner,id,name,
{
"count": 1,
"project": [
{
"id": "a81b8ec4-fa61-4e17-9383-1083276c18df",
"name": "p1",
"owner": [
{
"account": "ACSUser"
},
{
"account": "admin"
},
{
"account": "u1",
"user": "u1",
"userid": "603d77db-bd46-4f06-9c71-18ccd0211f8d"
}
]
}
]
}
```
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4822: listprojects: Maintain order of project owners added to a project
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4822:
URL: https://github.com/apache/cloudstack/pull/4822#issuecomment-800023443
@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests [S]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4822: listprojects: Maintain order of project owners added to a project
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4822:
URL: https://github.com/apache/cloudstack/pull/4822#issuecomment-799988147
@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. [S]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4822: listprojects: Maintain order of project owners added to a project
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4822:
URL: https://github.com/apache/cloudstack/pull/4822#issuecomment-800021723
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4822: listprojects: Maintain order of project owners added to a project
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4822:
URL: https://github.com/apache/cloudstack/pull/4822#issuecomment-799985211
Packaging result: :heavy_multiplication_x: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 131
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4822: listprojects: Maintain order of project owners added to a project
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4822:
URL: https://github.com/apache/cloudstack/pull/4822#issuecomment-800501543
<b>[S] Trillian test result (tid-144)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36879 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4822-t144-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 83 look OK, 3 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_isolate_network_password_server | `Failure` | 18.95 | test_password_server.py
test_01_migrate_VM_and_root_volume | `Error` | 69.22 | test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks | `Error` | 49.10 | test_vm_life_cycle.py
test_hostha_enable_ha_when_host_in_maintenance | `Error` | 300.48 | test_hostha_kvm.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4822: listprojects: Maintain order of project owners added to a project
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4822:
URL: https://github.com/apache/cloudstack/pull/4822#issuecomment-799987643
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4822: listprojects: Maintain order of project owners added to a project
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4822:
URL: https://github.com/apache/cloudstack/pull/4822#issuecomment-800003792
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 133
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4822: listprojects: Maintain order or project owners added to account
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4822:
URL: https://github.com/apache/cloudstack/pull/4822#issuecomment-799973414
@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. [S]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4822: listprojects: Maintain order or project owners added to account
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4822:
URL: https://github.com/apache/cloudstack/pull/4822#issuecomment-799972889
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4822: listprojects: Maintain order of project owners added to a project
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4822:
URL: https://github.com/apache/cloudstack/pull/4822
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org