You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "JunRuiLee (via GitHub)" <gi...@apache.org> on 2024/03/22 04:49:34 UTC

[PR] [FLINK-33985][runtime] Support obtain all partitions existing in cluster through ShuffleMaster. [flink]

JunRuiLee opened a new pull request, #24553:
URL: https://github.com/apache/flink/pull/24553

<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*

*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*

## Contribution Checklist

- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.

- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.

- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.

- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).

- Each pull request should address only one issue, not mix up code from multiple issues.

- Each commit in the pull request has a meaningful commit message (including the JIRA id)

- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.

**(The sections below can be removed for hotfixes of typos)**
-->

## What is the purpose of the change

[FLINK-33985][runtime] Support obtain all partitions existing in cluster through ShuffleMaster.

## Brief change log

- Support obtain all partitions existing in cluster through ShuffleMaster.
- TaskExecutor will not release partitions immediately when JM Failover enabled.

## Does this pull request potentially affect one of the following parts:

- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)

## Documentation

- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-33985][runtime] Support obtain all partitions existing in cluster through ShuffleMaster. [flink]

Posted by "JunRuiLee (via GitHub)" <gi...@apache.org>.

JunRuiLee commented on PR #24553:
URL: https://github.com/apache/flink/pull/24553#issuecomment-2024512507

   @zhuzhurk Fixed, PTAL~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-33985][runtime] Support obtain all partitions existing in cluster through ShuffleMaster. [flink]

Posted by "JunRuiLee (via GitHub)" <gi...@apache.org>.

JunRuiLee commented on PR #24553:
URL: https://github.com/apache/flink/pull/24553#issuecomment-2022677060

   @zhuzhurk Thanks for your review, I've updated this pr accordingly, PTAL.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-33985][runtime] Support obtain all partitions existing in cluster through ShuffleMaster. [flink]

Posted by "zhuzhurk (via GitHub)" <gi...@apache.org>.

zhuzhurk commented on code in PR #24553:
URL: https://github.com/apache/flink/pull/24553#discussion_r1542254332


##########
flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/NettyShuffleMaster.java:
##########
@@ -62,7 +61,7 @@ public class NettyShuffleMaster implements ShuffleMaster<NettyShuffleDescriptor>
 
     @Nullable private final TieredInternalShuffleMaster tieredInternalShuffleMaster;
 
-    private final Map<JobID, JobMasterGateway> jobMasters = new HashMap<>();
+    private final Map<JobID, JobShuffleContext> jobMasterShuffleMasters = new HashMap<>();

Review Comment:
   I prefer to name it as `jobShuffleContexts`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-33985][runtime] Support obtain all partitions existing in cluster through ShuffleMaster. [flink]

Posted by "zhuzhurk (via GitHub)" <gi...@apache.org>.

zhuzhurk closed pull request #24553: [FLINK-33985][runtime] Support obtain all partitions existing in cluster through ShuffleMaster.
URL: https://github.com/apache/flink/pull/24553


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-33985][runtime] Support obtain all partitions existing in cluster through ShuffleMaster. [flink]

Posted by "zhuzhurk (via GitHub)" <gi...@apache.org>.

zhuzhurk commented on code in PR #24553:
URL: https://github.com/apache/flink/pull/24553#discussion_r1540663177


##########
flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/JobMasterTest.java:
##########
@@ -1900,6 +1906,74 @@ void testJobMasterAcceptsSlotsWhenJobIsRestarting() throws Exception {
         }
     }
 
+    @Test
+    void testGetAllPartitionWithMetrics() throws Exception {

Review Comment:
   We need another test which verifies `NettyShuffleMaster#getAllPartitionWithMetrics()`, maybe in `ShuffleMasterTest`.



##########
flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/PartitionWithMetrics.java:
##########
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.shuffle;
+
+import java.io.Serializable;
+
+/**
+ * Interface representing a partition with associated shuffle metrics. It provides access to shuffle
+ * metrics as well as the partition data.

Review Comment:
   > a partition with associated shuffle metrics
   
   the description and metrics of a result partition
   
   > It provides access to shuffle metrics as well as the partition data.
   
   seems duplicated. maybe remove it?



##########
flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/NettyShuffleMaster.java:
##########
@@ -58,6 +62,8 @@ public class NettyShuffleMaster implements ShuffleMaster<NettyShuffleDescriptor>
 
     @Nullable private final TieredInternalShuffleMaster tieredInternalShuffleMaster;
 
+    private final Map<JobID, JobMasterGateway> jobMasters = new HashMap<>();

Review Comment:
   I prefer to cache the context because other methods in it may be needed later, e.g. `stopTrackingAndReleasePartitions`. 
   Then in the context we directly introduce a method `CompletableFuture<Collection<PartitionWithMetrics>> getAllPartitionWithMetricsOnTaskManagers()`.



##########
flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/ShuffleMaster.java:
##########
@@ -108,4 +109,16 @@ default MemorySize computeShuffleMemorySizeForTask(
             TaskInputsOutputsDescriptor taskInputsOutputsDescriptor) {
         return MemorySize.ZERO;
     }
+
+    /**
+     * Get all partitions and their metrics, the metrics mainly includes the meta information of
+     * partition(partition bytes, etc).

Review Comment:
   > the metrics mainly includes the meta information of partition(partition bytes, etc).
   
   The metrics include sizes of sub-partitions in a result partition.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-33985][runtime] Support obtain all partitions existing in cluster through ShuffleMaster. [flink]

Posted by "JunRuiLee (via GitHub)" <gi...@apache.org>.

JunRuiLee commented on code in PR #24553:
URL: https://github.com/apache/flink/pull/24553#discussion_r1541034943


##########
flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/JobMasterTest.java:
##########
@@ -1900,6 +1906,74 @@ void testJobMasterAcceptsSlotsWhenJobIsRestarting() throws Exception {
         }
     }
 
+    @Test
+    void testGetAllPartitionWithMetrics() throws Exception {

Review Comment:
   Currently, the changes in `NettyShuffleMaster` haven't been introduced into the production code path, and they will be covered by the upcoming PR. Therefore, I'd prefer to include the test for `NettyShuffleMaster#getAllPartitionWithMetrics()` in the subsequent PR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-33985][runtime] Support obtain all partitions existing in cluster through ShuffleMaster. [flink]

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.

flinkbot commented on PR #24553:
URL: https://github.com/apache/flink/pull/24553#issuecomment-2014352795

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "aba805d48cecbc21eeb32da963e62581255bc7a8",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "aba805d48cecbc21eeb32da963e62581255bc7a8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * aba805d48cecbc21eeb32da963e62581255bc7a8 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org