You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/02/11 14:42:38 UTC

[GitHub] [couchdb] garrensmith opened a new pull request #2538: Encode startkey/endkey for all_docs

garrensmith opened a new pull request #2538: Encode startkey/endkey for all_docs
URL: https://github.com/apache/couchdb/pull/2538
 
 
   ## Overview
   
   Encodes the startkey/endkey so that if a startkey is not binary it will return the expected results.
   ## Testing recommendations
   
   ## Related Issues or Pull Requests
   
   <!-- If your changes affects multiple components in different
        repositories please put links to those issues or pull requests here.  -->
   
   ## Checklist
   
   - [x] Code is written and works correctly
   - [x] Changes are covered by tests
   - [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
   - [ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [couchdb] garrensmith merged pull request #2538: Encode startkey/endkey for all_docs

Posted by GitBox <gi...@apache.org>.
garrensmith merged pull request #2538: Encode startkey/endkey for all_docs
URL: https://github.com/apache/couchdb/pull/2538
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [couchdb] davisp commented on a change in pull request #2538: Encode startkey/endkey for all_docs

Posted by GitBox <gi...@apache.org>.
davisp commented on a change in pull request #2538: Encode startkey/endkey for all_docs
URL: https://github.com/apache/couchdb/pull/2538#discussion_r377872107
 
 

 ##########
 File path: test/elixir/test/all_docs_test.exs
 ##########
 @@ -41,11 +41,9 @@ defmodule AllDocsTest do
     assert resp["total_rows"] == length(rows)
 
     # Check _all_docs offset
-    retry_until(fn ->
 
 Review comment:
   I assume the removal of retry_until is because fdb is more consistent than old clustering code? We'll want to dedent the inner block though right? mix format should take care of that I think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [couchdb] davisp commented on a change in pull request #2538: Encode startkey/endkey for all_docs

Posted by GitBox <gi...@apache.org>.
davisp commented on a change in pull request #2538: Encode startkey/endkey for all_docs
URL: https://github.com/apache/couchdb/pull/2538#discussion_r377870849
 
 

 ##########
 File path: src/fabric/src/fabric2_util.erl
 ##########
 @@ -235,3 +237,12 @@ hex_to_nibble(N) ->
 
 uuid() ->
     to_hex(crypto:strong_rand_bytes(16)).
+
+
+all_docs_encode(null) -> <<>>;
 
 Review comment:
   This function name is a bit vague. How about `encode_all_docs_key` maybe?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [couchdb] garrensmith commented on a change in pull request #2538: Encode startkey/endkey for all_docs

Posted by GitBox <gi...@apache.org>.
garrensmith commented on a change in pull request #2538: Encode startkey/endkey for all_docs
URL: https://github.com/apache/couchdb/pull/2538#discussion_r378087379
 
 

 ##########
 File path: test/elixir/test/all_docs_test.exs
 ##########
 @@ -41,11 +41,9 @@ defmodule AllDocsTest do
     assert resp["total_rows"] == length(rows)
 
     # Check _all_docs offset
-    retry_until(fn ->
 
 Review comment:
   That is right

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services