[GitHub] [zookeeper] maoling commented on issue #994: ZOOKEEPER-3432 Improving zookeeper trace for performance and scalability

[GitBox <gi...@apache.org>]

maoling commented on issue #994: ZOOKEEPER-3432 Improving zookeeper trace for performance and scalability
URL: https://github.com/apache/zookeeper/pull/994#issuecomment-534960115
 
 
   - I take another look at this PR. One of the most valuable thing of this PR is the pointcut of tracing,i.e. where to do the tracing.
   - I prefer to use the opentracing api to do this work, for the following benefits:
     - Use the standard terminology(e.g:traceId, span...) to help uses to have a better understanding of the implementation
     - Save a ton of codes to use the ready-made opentracing api, hide the details about  how to generate the traceId, how to send the tracing, how to storage the tracing...
     - Easy to make users to integrate with their existing tracing system(zipkin, jaeger...) seamlessly
     - A wonderful ready-made web UI to show the tracing chain to analyse
   
   - @gmcatsf Are you free there day? If not, I can pick it up and this PR will still sign off your name.
   - I watch the etcd community is also doing the tracing feature currently(etcd PR-11179), but that one seems like logging, not tracing. I wish we can land this great feature before etcd, and do it much better :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services