You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by st...@apache.org on 2012/06/25 23:25:48 UTC

svn commit: r1353748 - /subversion/trunk/subversion/tests/cmdline/svnadmin_tests.py

Author: stsp
Date: Mon Jun 25 21:25:47 2012
New Revision: 1353748

URL: http://svn.apache.org/viewvc?rev=1353748&view=rev
Log:
Following up to r1353730, fix a test failure due to passing the wrong number
of arguments to a helper function.

* subversion/tests/cmdline/svnadmin_tests.py
  (reflect_dropped_renumbered_revs): Pass False for the new check_props 
   parameter of load_and_verify_dumpstream().

Modified:
    subversion/trunk/subversion/tests/cmdline/svnadmin_tests.py

Modified: subversion/trunk/subversion/tests/cmdline/svnadmin_tests.py
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/cmdline/svnadmin_tests.py?rev=1353748&r1=1353747&r2=1353748&view=diff
==============================================================================
--- subversion/trunk/subversion/tests/cmdline/svnadmin_tests.py (original)
+++ subversion/trunk/subversion/tests/cmdline/svnadmin_tests.py Mon Jun 25 21:25:47 2012
@@ -910,10 +910,10 @@ def reflect_dropped_renumbered_revs(sbox
                                      "-m", "Create toplevel dir")
 
   # Load the dump stream in sbox.repo_url
-  load_and_verify_dumpstream(sbox,[],[], None, dumpfile)
+  load_and_verify_dumpstream(sbox,[],[], None, False, dumpfile)
 
   # Load the dump stream in toplevel dir
-  load_and_verify_dumpstream(sbox,[],[], None, dumpfile, '--parent-dir',
+  load_and_verify_dumpstream(sbox,[],[], None, False, dumpfile, '--parent-dir',
                              '/toplevel')
 
   # Verify the svn:mergeinfo properties

Re: svn commit: r1353748 - /subversion/trunk/subversion/tests/cmdline/svnadmin_tests.py

Posted by Stefan Sperling <st...@elego.de>.
On Tue, Jun 26, 2012 at 12:15:00AM +0200, Stephen Butler wrote:
> 
> On Jun 25, 2012, at 23:25 , stsp@apache.org wrote:
> 
> > Author: stsp
> > Date: Mon Jun 25 21:25:47 2012
> > New Revision: 1353748
> > 
> > URL: http://svn.apache.org/viewvc?rev=1353748&view=rev
> > Log:
> > Following up to r1353730, fix a test failure due to passing the wrong number
> > of arguments to a helper function.
> 
> Thank for catching my mistake, Stefan.   I should be more careful when splitting 
> up a big ugly patch into readable commits.
> 
> Thanks,
> Steve

No problem!

Re: svn commit: r1353748 - /subversion/trunk/subversion/tests/cmdline/svnadmin_tests.py

Posted by Stefan Sperling <st...@elego.de>.
On Tue, Jun 26, 2012 at 12:15:00AM +0200, Stephen Butler wrote:
> 
> On Jun 25, 2012, at 23:25 , stsp@apache.org wrote:
> 
> > Author: stsp
> > Date: Mon Jun 25 21:25:47 2012
> > New Revision: 1353748
> > 
> > URL: http://svn.apache.org/viewvc?rev=1353748&view=rev
> > Log:
> > Following up to r1353730, fix a test failure due to passing the wrong number
> > of arguments to a helper function.
> 
> Thank for catching my mistake, Stefan.   I should be more careful when splitting 
> up a big ugly patch into readable commits.
> 
> Thanks,
> Steve

No problem!

Re: svn commit: r1353748 - /subversion/trunk/subversion/tests/cmdline/svnadmin_tests.py

Posted by Stephen Butler <sb...@elego.de>.
On Jun 25, 2012, at 23:25 , stsp@apache.org wrote:

> Author: stsp
> Date: Mon Jun 25 21:25:47 2012
> New Revision: 1353748
> 
> URL: http://svn.apache.org/viewvc?rev=1353748&view=rev
> Log:
> Following up to r1353730, fix a test failure due to passing the wrong number
> of arguments to a helper function.

Thank for catching my mistake, Stefan.   I should be more careful when splitting 
up a big ugly patch into readable commits.

Thanks,
Steve

Re: svn commit: r1353748 - /subversion/trunk/subversion/tests/cmdline/svnadmin_tests.py

Posted by Stephen Butler <sb...@elego.de>.
On Jun 25, 2012, at 23:25 , stsp@apache.org wrote:

> Author: stsp
> Date: Mon Jun 25 21:25:47 2012
> New Revision: 1353748
> 
> URL: http://svn.apache.org/viewvc?rev=1353748&view=rev
> Log:
> Following up to r1353730, fix a test failure due to passing the wrong number
> of arguments to a helper function.

Thank for catching my mistake, Stefan.   I should be more careful when splitting 
up a big ugly patch into readable commits.

Thanks,
Steve