You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@manifoldcf.apache.org by "Karl Wright (JIRA)" <ji...@apache.org> on 2011/09/21 12:42:08 UTC
[jira] [Created] (CONNECTORS-263) Long-running tests should all be
moved to Maven's integration-test phase
Long-running tests should all be moved to Maven's integration-test phase
------------------------------------------------------------------------
Key: CONNECTORS-263
URL: https://issues.apache.org/jira/browse/CONNECTORS-263
Project: ManifoldCF
Issue Type: Improvement
Components: Build
Affects Versions: ManifoldCF 0.4
Reporter: Karl Wright
Fix For: ManifoldCF 0.4
Long-running tests should be moved to Maven's integration-test phase.
(which are all in root-level "tests" directory)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Commented] (CONNECTORS-263) Long-running tests should all
be moved to Maven's integration-test phase
Posted by Karl Wright <da...@gmail.com>.
By default, the maven build should not run anything other than the
general, Derby and HSQLDB tests. The PostgreSQL tests should not be
run under Maven.
On Tue, Sep 27, 2011 at 3:19 PM, Karl Wright (Commented) (JIRA)
<ji...@apache.org> wrote:
>
> [ https://issues.apache.org/jira/browse/CONNECTORS-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115827#comment-13115827 ]
>
> Karl Wright commented on CONNECTORS-263:
> ----------------------------------------
>
> There is a different ticket for integrating maven profiles with the build. CONNECTORS-261.
>
>
>> Long-running tests should all be moved to Maven's integration-test phase
>> ------------------------------------------------------------------------
>>
>> Key: CONNECTORS-263
>> URL: https://issues.apache.org/jira/browse/CONNECTORS-263
>> Project: ManifoldCF
>> Issue Type: Improvement
>> Components: Build
>> Affects Versions: ManifoldCF 0.4
>> Reporter: Karl Wright
>> Assignee: Piergiorgio Lucidi
>> Fix For: ManifoldCF 0.4
>>
>>
>> Long-running tests should be moved to Maven's integration-test phase.
>> (which are all in root-level "tests" directory)
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>
[jira] [Commented] (CONNECTORS-263) Long-running tests should all
be moved to Maven's integration-test phase
Posted by "Karl Wright (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114734#comment-13114734 ]
Karl Wright commented on CONNECTORS-263:
----------------------------------------
We should update the "how-to-build-and-deploy" site page to correspond.
> Long-running tests should all be moved to Maven's integration-test phase
> ------------------------------------------------------------------------
>
> Key: CONNECTORS-263
> URL: https://issues.apache.org/jira/browse/CONNECTORS-263
> Project: ManifoldCF
> Issue Type: Improvement
> Components: Build
> Affects Versions: ManifoldCF 0.4
> Reporter: Karl Wright
> Assignee: Piergiorgio Lucidi
> Fix For: ManifoldCF 0.4
>
>
> Long-running tests should be moved to Maven's integration-test phase.
> (which are all in root-level "tests" directory)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-263) Long-running tests should all
be moved to Maven's integration-test phase
Posted by "Karl Wright (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115827#comment-13115827 ]
Karl Wright commented on CONNECTORS-263:
----------------------------------------
There is a different ticket for integrating maven profiles with the build. CONNECTORS-261.
> Long-running tests should all be moved to Maven's integration-test phase
> ------------------------------------------------------------------------
>
> Key: CONNECTORS-263
> URL: https://issues.apache.org/jira/browse/CONNECTORS-263
> Project: ManifoldCF
> Issue Type: Improvement
> Components: Build
> Affects Versions: ManifoldCF 0.4
> Reporter: Karl Wright
> Assignee: Piergiorgio Lucidi
> Fix For: ManifoldCF 0.4
>
>
> Long-running tests should be moved to Maven's integration-test phase.
> (which are all in root-level "tests" directory)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CONNECTORS-263) Long-running tests should all be
moved to Maven's integration-test phase
Posted by "Piergiorgio Lucidi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Piergiorgio Lucidi resolved CONNECTORS-263.
-------------------------------------------
Resolution: Fixed
r1175909
> Long-running tests should all be moved to Maven's integration-test phase
> ------------------------------------------------------------------------
>
> Key: CONNECTORS-263
> URL: https://issues.apache.org/jira/browse/CONNECTORS-263
> Project: ManifoldCF
> Issue Type: Improvement
> Components: Build
> Affects Versions: ManifoldCF 0.4
> Reporter: Karl Wright
> Assignee: Piergiorgio Lucidi
> Fix For: ManifoldCF 0.4
>
>
> Long-running tests should be moved to Maven's integration-test phase.
> (which are all in root-level "tests" directory)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (CONNECTORS-263) Long-running tests
should all be moved to Maven's integration-test phase
Posted by "Karl Wright (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115827#comment-13115827 ]
Karl Wright edited comment on CONNECTORS-263 at 9/27/11 7:30 PM:
-----------------------------------------------------------------
There is a different ticket for integrating maven profiles with the build. CONNECTORS-261.
By default, the maven build should not run anything other than the general, Derby and HSQLDB tests. The PostgreSQL tests should not be run under Maven. So if this is happening it is a bug.
was (Author: kwright@metacarta.com):
There is a different ticket for integrating maven profiles with the build. CONNECTORS-261.
> Long-running tests should all be moved to Maven's integration-test phase
> ------------------------------------------------------------------------
>
> Key: CONNECTORS-263
> URL: https://issues.apache.org/jira/browse/CONNECTORS-263
> Project: ManifoldCF
> Issue Type: Improvement
> Components: Build
> Affects Versions: ManifoldCF 0.4
> Reporter: Karl Wright
> Assignee: Piergiorgio Lucidi
> Fix For: ManifoldCF 0.4
>
>
> Long-running tests should be moved to Maven's integration-test phase.
> (which are all in root-level "tests" directory)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-263) Long-running tests should all
be moved to Maven's integration-test phase
Posted by "Piergiorgio Lucidi (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115698#comment-13115698 ]
Piergiorgio Lucidi commented on CONNECTORS-263:
-----------------------------------------------
Ok, I updated the page but I can't commit now because the SVN is down :(
> Long-running tests should all be moved to Maven's integration-test phase
> ------------------------------------------------------------------------
>
> Key: CONNECTORS-263
> URL: https://issues.apache.org/jira/browse/CONNECTORS-263
> Project: ManifoldCF
> Issue Type: Improvement
> Components: Build
> Affects Versions: ManifoldCF 0.4
> Reporter: Karl Wright
> Assignee: Piergiorgio Lucidi
> Fix For: ManifoldCF 0.4
>
>
> Long-running tests should be moved to Maven's integration-test phase.
> (which are all in root-level "tests" directory)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (CONNECTORS-263) Long-running tests
should all be moved to Maven's integration-test phase
Posted by "Piergiorgio Lucidi (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127652#comment-13127652 ]
Piergiorgio Lucidi edited comment on CONNECTORS-263 at 10/14/11 4:06 PM:
-------------------------------------------------------------------------
r1183401.
All the integration tests classes are renamed with the suffix *IT.java to work with the Maven Failsafe Plugin. This because I had some problems to add the <include> element in the Maven configuration: it seems that it doesn't work with the Failsafe plugin :(
Updated the how-to-build-and-deploy page on the website and the Ant script to work with this latest change.
By default to execute unit tests and integration tests, type:
{code}
mvn clean install
{code}
If you want to skip only the integration tests, type:
{code}
mvn clean install -DskipITs
{code}
was (Author: piergiorgiolucidi@gmail.com):
r1183401.
All the integration tests classes are renamed with the suffix *IT.java to work with the Maven Failsafe Plugin. This because I had some problems to add the <include> element in the Maven configuration: it seems that it doesn't work with the Failsafe plugin :(
Updated the how-to-build-and-deploy page on the website and the Ant script to work with this latest change.
> Long-running tests should all be moved to Maven's integration-test phase
> ------------------------------------------------------------------------
>
> Key: CONNECTORS-263
> URL: https://issues.apache.org/jira/browse/CONNECTORS-263
> Project: ManifoldCF
> Issue Type: Improvement
> Components: Build
> Affects Versions: ManifoldCF 0.4
> Reporter: Karl Wright
> Assignee: Piergiorgio Lucidi
> Fix For: ManifoldCF 0.4
>
>
> Long-running tests should be moved to Maven's integration-test phase.
> (which are all in root-level "tests" directory)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-263) Long-running tests should all
be moved to Maven's integration-test phase
Posted by "Piergiorgio Lucidi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114731#comment-13114731 ]
Piergiorgio Lucidi commented on CONNECTORS-263:
-----------------------------------------------
Now the project uses the right Maven lifecycle.
If you run mvn clean package, only unit tests are executed.
If you run mvn clean install the integration-test phase will be executed.
> Long-running tests should all be moved to Maven's integration-test phase
> ------------------------------------------------------------------------
>
> Key: CONNECTORS-263
> URL: https://issues.apache.org/jira/browse/CONNECTORS-263
> Project: ManifoldCF
> Issue Type: Improvement
> Components: Build
> Affects Versions: ManifoldCF 0.4
> Reporter: Karl Wright
> Assignee: Piergiorgio Lucidi
> Fix For: ManifoldCF 0.4
>
>
> Long-running tests should be moved to Maven's integration-test phase.
> (which are all in root-level "tests" directory)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CONNECTORS-263) Long-running tests should all be
moved to Maven's integration-test phase
Posted by "Piergiorgio Lucidi (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Piergiorgio Lucidi resolved CONNECTORS-263.
-------------------------------------------
Resolution: Fixed
r1183401.
All the integration tests classes are renamed with the suffix *IT.java to work with the Maven Failsafe Plugin. This because I had some problems to add the <include> element in the Maven configuration: it seems that it doesn't work with the Failsafe plugin :(
Updated the how-to-build-and-deploy page on the website and the Ant script to work with this latest change.
> Long-running tests should all be moved to Maven's integration-test phase
> ------------------------------------------------------------------------
>
> Key: CONNECTORS-263
> URL: https://issues.apache.org/jira/browse/CONNECTORS-263
> Project: ManifoldCF
> Issue Type: Improvement
> Components: Build
> Affects Versions: ManifoldCF 0.4
> Reporter: Karl Wright
> Assignee: Piergiorgio Lucidi
> Fix For: ManifoldCF 0.4
>
>
> Long-running tests should be moved to Maven's integration-test phase.
> (which are all in root-level "tests" directory)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (CONNECTORS-263) Long-running tests should all be
moved to Maven's integration-test phase
Posted by "Piergiorgio Lucidi (Reopened) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Piergiorgio Lucidi reopened CONNECTORS-263:
-------------------------------------------
This was not enough because it has broken the Maven build process.
Probably we can solve adding the maven-failsafe-plugin and using the -DskipITs to skip integration test:
http://maven.apache.org/plugins/maven-failsafe-plugin/examples/skipping-test.html
I hope to spend some time on this issue very soon.
> Long-running tests should all be moved to Maven's integration-test phase
> ------------------------------------------------------------------------
>
> Key: CONNECTORS-263
> URL: https://issues.apache.org/jira/browse/CONNECTORS-263
> Project: ManifoldCF
> Issue Type: Improvement
> Components: Build
> Affects Versions: ManifoldCF 0.4
> Reporter: Karl Wright
> Assignee: Piergiorgio Lucidi
> Fix For: ManifoldCF 0.4
>
>
> Long-running tests should be moved to Maven's integration-test phase.
> (which are all in root-level "tests" directory)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-263) Long-running tests should all
be moved to Maven's integration-test phase
Posted by "Alex Ott (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115820#comment-13115820 ]
Alex Ott commented on CONNECTORS-263:
-------------------------------------
it looks like this change doesn't respect profile setup - I see, that it's trying to run pgsql test, and fail with:
Running org.apache.manifoldcf.agents.tests.SanityPostgresqlTest
Configuration file successfully read
org.apache.manifoldcf.core.interfaces.ManifoldCFException: Error getting connection
> Long-running tests should all be moved to Maven's integration-test phase
> ------------------------------------------------------------------------
>
> Key: CONNECTORS-263
> URL: https://issues.apache.org/jira/browse/CONNECTORS-263
> Project: ManifoldCF
> Issue Type: Improvement
> Components: Build
> Affects Versions: ManifoldCF 0.4
> Reporter: Karl Wright
> Assignee: Piergiorgio Lucidi
> Fix For: ManifoldCF 0.4
>
>
> Long-running tests should be moved to Maven's integration-test phase.
> (which are all in root-level "tests" directory)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-263) Long-running tests should all
be moved to Maven's integration-test phase
Posted by "Piergiorgio Lucidi (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115770#comment-13115770 ]
Piergiorgio Lucidi commented on CONNECTORS-263:
-----------------------------------------------
updated the page (r1176497)
> Long-running tests should all be moved to Maven's integration-test phase
> ------------------------------------------------------------------------
>
> Key: CONNECTORS-263
> URL: https://issues.apache.org/jira/browse/CONNECTORS-263
> Project: ManifoldCF
> Issue Type: Improvement
> Components: Build
> Affects Versions: ManifoldCF 0.4
> Reporter: Karl Wright
> Assignee: Piergiorgio Lucidi
> Fix For: ManifoldCF 0.4
>
>
> Long-running tests should be moved to Maven's integration-test phase.
> (which are all in root-level "tests" directory)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (CONNECTORS-263) Long-running tests should all be
moved to Maven's integration-test phase
Posted by "Piergiorgio Lucidi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Piergiorgio Lucidi reassigned CONNECTORS-263:
---------------------------------------------
Assignee: Piergiorgio Lucidi
> Long-running tests should all be moved to Maven's integration-test phase
> ------------------------------------------------------------------------
>
> Key: CONNECTORS-263
> URL: https://issues.apache.org/jira/browse/CONNECTORS-263
> Project: ManifoldCF
> Issue Type: Improvement
> Components: Build
> Affects Versions: ManifoldCF 0.4
> Reporter: Karl Wright
> Assignee: Piergiorgio Lucidi
> Fix For: ManifoldCF 0.4
>
>
> Long-running tests should be moved to Maven's integration-test phase.
> (which are all in root-level "tests" directory)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CONNECTORS-263) Long-running tests should all
be moved to Maven's integration-test phase
Posted by "Alex Ott (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONNECTORS-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115839#comment-13115839 ]
Alex Ott commented on CONNECTORS-263:
-------------------------------------
Yes, this is why I commented - in previous builds, these tests weren't running
> Long-running tests should all be moved to Maven's integration-test phase
> ------------------------------------------------------------------------
>
> Key: CONNECTORS-263
> URL: https://issues.apache.org/jira/browse/CONNECTORS-263
> Project: ManifoldCF
> Issue Type: Improvement
> Components: Build
> Affects Versions: ManifoldCF 0.4
> Reporter: Karl Wright
> Assignee: Piergiorgio Lucidi
> Fix For: ManifoldCF 0.4
>
>
> Long-running tests should be moved to Maven's integration-test phase.
> (which are all in root-level "tests" directory)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira