You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by arpadboda <gi...@git.apache.org> on 2018/10/30 13:48:37 UTC

[GitHub] nifi-minifi-cpp pull request #431: MINIFICPP-640 - C API: how to support dyn...

GitHub user arpadboda opened a pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/431

    MINIFICPP-640 - C API: how to support dynamic properties?

    Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced
         in the commit message?
    
    - [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [ ] If applicable, have you updated the LICENSE file?
    - [ ] If applicable, have you updated the NOTICE file?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/arpadboda/nifi-minifi-cpp MINIFICPP-640

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi-minifi-cpp/pull/431.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #431
    
----
commit 051aa07d97adf39ab6ccbf742166dc4d38d6d16b
Author: Arpad Boda <ab...@...>
Date:   2018-10-30T13:48:04Z

    MINIFICPP-640 - C API: how to support dynamic properties?

----


---

[GitHub] nifi-minifi-cpp issue #431: MINIFICPP-640 - C API: how to support dynamic pr...

Posted by phrocker <gi...@git.apache.org>.
Github user phrocker commented on the issue:

    https://github.com/apache/nifi-minifi-cpp/pull/431
  
    @arpadboda this was merged but I used the wrong commit hook to close it. I closed the wrong PR. So can you close this when you have a chance? Sorry about that. 


---

[GitHub] nifi-minifi-cpp issue #431: MINIFICPP-640 - C API: how to support dynamic pr...

Posted by arpadboda <gi...@git.apache.org>.
Github user arpadboda commented on the issue:

    https://github.com/apache/nifi-minifi-cpp/pull/431
  
    > @arpadboda this was merged but I used the wrong commit hook to close it. I closed the wrong PR. So can you close this when you have a chance? Sorry about that.
    
    Sure, done


---

[GitHub] nifi-minifi-cpp pull request #431: MINIFICPP-640 - C API: how to support dyn...

Posted by arpadboda <gi...@git.apache.org>.
Github user arpadboda closed the pull request at:

    https://github.com/apache/nifi-minifi-cpp/pull/431


---