You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Mryange (via GitHub)" <gi...@apache.org> on 2025/10/17 10:27:07 UTC
[PR] [refine](type)use new type dispatch for agg function [doris]
Mryange opened a new pull request, #57112:
URL: https://github.com/apache/doris/pull/57112
### What problem does this PR solve?
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](type)use new type dispatch for agg function [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57112:
URL: https://github.com/apache/doris/pull/57112#issuecomment-3415510614
# BE Regression && UT Coverage Report
Increment line coverage `100.00% (31/31)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/57112_7e8bad4182556d7afb8903be75b1b8fbdc6f84c6_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/57112_7e8bad4182556d7afb8903be75b1b8fbdc6f84c6_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.26% (23716/33282) |
| Line Coverage | 57.70% (246962/428028) |
| Region Coverage | 52.82% (205030/388199) |
| Branch Coverage | 54.54% (88189/161706) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](type)use new type dispatch for agg function [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #57112:
URL: https://github.com/apache/doris/pull/57112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](type)use new type dispatch for agg function [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57112:
URL: https://github.com/apache/doris/pull/57112#issuecomment-3415125262
# BE UT Coverage Report
Increment line coverage `70.97% (22/31)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/7e8bad4182556d7afb8903be75b1b8fbdc6f84c6_7e8bad4182556d7afb8903be75b1b8fbdc6f84c6/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/7e8bad4182556d7afb8903be75b1b8fbdc6f84c6_7e8bad4182556d7afb8903be75b1b8fbdc6f84c6/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.54% (17834/33943) |
| Line Coverage | 37.82% (161955/428270) |
| Region Coverage | 32.24% (123559/383235) |
| Branch Coverage | 33.65% (54106/160811) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](type)use new type dispatch for agg function [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57112:
URL: https://github.com/apache/doris/pull/57112#issuecomment-3415058646
<details>
<summary>ClickBench: <b>Total hot run time: 31.09 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7e8bad4182556d7afb8903be75b1b8fbdc6f84c6, data reload: false
query1 0.06 0.06 0.05
query2 0.09 0.05 0.06
query3 0.26 0.08 0.08
query4 1.60 0.12 0.12
query5 0.27 0.26 0.26
query6 1.17 0.66 0.65
query7 0.03 0.02 0.03
query8 0.06 0.05 0.05
query9 0.66 0.54 0.56
query10 0.59 0.58 0.58
query11 0.16 0.11 0.12
query12 0.15 0.12 0.12
query13 0.64 0.61 0.62
query14 1.04 1.06 1.03
query15 0.87 0.86 0.84
query16 0.42 0.39 0.40
query17 1.06 1.04 1.02
query18 0.22 0.20 0.21
query19 2.02 1.88 1.83
query20 0.01 0.01 0.02
query21 15.42 0.95 0.57
query22 0.76 1.20 1.00
query23 14.70 1.39 0.68
query24 6.63 1.17 0.96
query25 0.57 0.26 0.06
query26 0.49 0.15 0.15
query27 0.07 0.06 0.05
query28 10.06 1.39 0.94
query29 12.57 3.99 3.29
query30 0.28 0.13 0.11
query31 2.83 0.61 0.39
query32 3.23 0.56 0.48
query33 3.23 3.16 3.19
query34 15.98 5.47 4.88
query35 4.96 4.94 4.97
query36 0.68 0.54 0.50
query37 0.10 0.08 0.07
query38 0.07 0.05 0.05
query39 0.04 0.03 0.03
query40 0.18 0.14 0.13
query41 0.08 0.04 0.03
query42 0.04 0.04 0.03
query43 0.05 0.04 0.03
Total cold run time: 104.4 s
Total hot run time: 31.09 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](type)use new type dispatch for agg function [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #57112:
URL: https://github.com/apache/doris/pull/57112#issuecomment-3414863313
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](type)use new type dispatch for agg function [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #57112:
URL: https://github.com/apache/doris/pull/57112#issuecomment-3425535321
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](type)use new type dispatch for agg function [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #57112:
URL: https://github.com/apache/doris/pull/57112#issuecomment-3414863065
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](type)use new type dispatch for agg function [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #57112:
URL: https://github.com/apache/doris/pull/57112#issuecomment-3425535145
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org