[GitHub] [druid] clintropolis commented on a change in pull request #9507: optionally disable all of hardcoded zookeeper use

[GitBox <gi...@apache.org>]

clintropolis commented on a change in pull request #9507: optionally disable all of hardcoded zookeeper use
URL: https://github.com/apache/druid/pull/9507#discussion_r396910109
 
 

 ##########
 File path: server/src/main/java/org/apache/druid/server/coordinator/DruidCoordinator.java
 ##########
 @@ -443,7 +455,7 @@ public void moveSegment(
             () -> {
               try {
                 if (serverInventoryView.isSegmentLoadedByServer(toServer.getName(), segment) &&
-                    curator.checkExists().forPath(toLoadQueueSegPath) == null &&
+                    (curator == null || curator.checkExists().forPath(toLoadQueueSegPath) == null) &&
 
 Review comment:
   This doesn't necessarily need to change in this PR, but it seems kind of leaky that this thing has a `CuratorFramework` at all, it seems like the load peon should provide this check so it can just be a no-op for non-zk. and then `DruidCoordinator` no longer needs a curator or zk paths I think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org