[I] --telemetry-params collection-stats-sample-interval is documented but ignored [solr-orbit]

["syahra712 (via GitHub)" <gi...@apache.org>]

syahra712 opened a new issue, #136:
URL: https://github.com/apache/solr-orbit/issues/136

   `docs/reference/telemetry.md` says collection stats are polled every 30 seconds by default and that `--telemetry-params collection-stats-sample-interval:60` overrides this. Nothing reads that parameter, though: `WorkerCoordinator._create_solr_telemetry_devices` creates `SolrCollectionStats(sc, self.metrics_store)` without a `sample_interval_s`, so the device always polls every 30 s.
   
   `ShardStats` already reads its `shard-stats-sample-interval` from the same `telemetry_params` and rejects values <= 0. `collection-stats-sample-interval` could work the same way. A value of 0 would matter here, because `SolrTelemetryDevice._poll_loop` waits `sample_interval` between polls, so a zero interval would poll Solr in a tight loop.
   
   Noted while looking into #5.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org