You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by ja...@apache.org on 2017/05/09 00:18:45 UTC
samza git commit: SAMZA-1232;
Log configuration value in RunLoopFactory
Repository: samza
Updated Branches:
refs/heads/master ad41f9a7f -> 29c4844fd
SAMZA-1232; Log configuration value in RunLoopFactory
Author: Shanthoosh Venkataraman <sv...@linkedin.com>
Reviewers: Xinyu Liu <xi...@apache.org>
Closes #137 from shanthoosh/adding_logging_into_asyncrunloop
Project: http://git-wip-us.apache.org/repos/asf/samza/repo
Commit: http://git-wip-us.apache.org/repos/asf/samza/commit/29c4844f
Tree: http://git-wip-us.apache.org/repos/asf/samza/tree/29c4844f
Diff: http://git-wip-us.apache.org/repos/asf/samza/diff/29c4844f
Branch: refs/heads/master
Commit: 29c4844fd8403581f0ad0d87fc71a2ab46035dc2
Parents: ad41f9a
Author: Shanthoosh Venkataraman <sv...@linkedin.com>
Authored: Mon May 8 17:18:38 2017 -0700
Committer: vjagadish1989 <jv...@linkedin.com>
Committed: Mon May 8 17:18:38 2017 -0700
----------------------------------------------------------------------
.../java/org/apache/samza/container/RunLoopFactory.java | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/samza/blob/29c4844f/samza-core/src/main/java/org/apache/samza/container/RunLoopFactory.java
----------------------------------------------------------------------
diff --git a/samza-core/src/main/java/org/apache/samza/container/RunLoopFactory.java b/samza-core/src/main/java/org/apache/samza/container/RunLoopFactory.java
index 9d1877c..f19c240 100644
--- a/samza-core/src/main/java/org/apache/samza/container/RunLoopFactory.java
+++ b/samza-core/src/main/java/org/apache/samza/container/RunLoopFactory.java
@@ -55,11 +55,11 @@ public class RunLoopFactory {
long taskWindowMs = config.getWindowMs().getOrElse(defaultValue(DEFAULT_WINDOW_MS));
- log.info("Got window milliseconds: " + taskWindowMs);
+ log.info("Got window milliseconds: {}.", taskWindowMs);
long taskCommitMs = config.getCommitMs().getOrElse(defaultValue(DEFAULT_COMMIT_MS));
- log.info("Got commit milliseconds: " + taskCommitMs);
+ log.info("Got commit milliseconds: {}.", taskCommitMs);
int asyncTaskCount = taskInstances.values().count(new AbstractFunction1<TaskInstance, Object>() {
@Override
@@ -87,13 +87,15 @@ public class RunLoopFactory {
} else {
Integer taskMaxConcurrency = config.getMaxConcurrency().getOrElse(defaultValue(1));
+ log.info("Got taskMaxConcurrency: {}.", taskMaxConcurrency);
+
boolean isAsyncCommitEnabled = config.getAsyncCommit().getOrElse(defaultValue(false));
- log.info("Got max messages in flight: " + taskMaxConcurrency);
+ log.info("Got asyncCommitEnabled: {}.", isAsyncCommitEnabled);
Long callbackTimeout = config.getCallbackTimeoutMs().getOrElse(defaultValue(DEFAULT_CALLBACK_TIMEOUT_MS));
- log.info("Got callback timeout: " + callbackTimeout);
+ log.info("Got callbackTimeout: {}.", callbackTimeout);
log.info("Run loop in asynchronous mode.");