You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Abhishek Kumar <ab...@gmail.com> on 2021/03/17 22:12:43 UTC
Review Request 73238: RANGER-2862: Added packaging,
kerberos and SSL support for Java Client
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73238/
-----------------------------------------------------------
Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Sailaja Polavarapu, Vishal Suvagia, and Velmurugan Periasamy.
Bugs: RANGER-2862
https://issues.apache.org/jira/browse/RANGER-2862
Repository: ranger
Description
-------
Java client will now be packaged as part of ranger installation.
Added client support for kerberos authentication.
Added client support for TLS enabled ranger admin.
Diffs
-----
distro/pom.xml 6d78e8e9b
distro/src/main/assembly/sample-client.xml PRE-CREATION
intg/src/main/java/org/apache/ranger/RangerClient.java bef385707
intg/src/main/java/org/apache/ranger/RangerClientConfig.java 68ef0ffc3
ranger-examples/sample-client/conf/config.properties 5be772ac1
ranger-examples/sample-client/conf/ssl-client.xml PRE-CREATION
ranger-examples/sample-client/scripts/run-sample-client.sh 2260476ef
ranger-examples/sample-client/src/main/java/org/apache/ranger/examples/sampleclient/SampleClient.java b6ab3131d
Diff: https://reviews.apache.org/r/73238/diff/1/
Testing
-------
Tested the kerberos and SSL changes on remote cluster which hosts ranger admin.
Thanks,
Abhishek Kumar
Re: Review Request 73238: RANGER-3212: Added packaging,
kerberos and SSL support for Java Client
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73238/#review222719
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On March 18, 2021, 9:39 p.m., Abhishek Kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73238/
> -----------------------------------------------------------
>
> (Updated March 18, 2021, 9:39 p.m.)
>
>
> Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Sailaja Polavarapu, Vishal Suvagia, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3212
> https://issues.apache.org/jira/browse/RANGER-3212
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Java client will now be packaged as part of ranger installation.
> Added client support for kerberos authentication.
> Added client support for TLS enabled ranger admin.
>
>
> Diffs
> -----
>
> distro/pom.xml 6d78e8e9b
> distro/src/main/assembly/sample-client.xml PRE-CREATION
> intg/src/main/java/org/apache/ranger/RangerClient.java bef385707
> intg/src/main/java/org/apache/ranger/RangerClientConfig.java 68ef0ffc3
> ranger-examples/sample-client/conf/config.properties 5be772ac1
> ranger-examples/sample-client/conf/ssl-client.xml PRE-CREATION
> ranger-examples/sample-client/scripts/run-sample-client.sh 2260476ef
> ranger-examples/sample-client/src/main/java/org/apache/ranger/examples/sampleclient/SampleClient.java b6ab3131d
>
>
> Diff: https://reviews.apache.org/r/73238/diff/2/
>
>
> Testing
> -------
>
> Tested the kerberos and SSL changes on remote cluster which hosts ranger admin.
>
>
> Thanks,
>
> Abhishek Kumar
>
>
Re: Review Request 73238: RANGER-3212: Added packaging,
kerberos and SSL support for Java Client
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73238/#review222707
-----------------------------------------------------------
intg/src/main/java/org/apache/ranger/RangerClient.java
Line 144 (original), 144 (patched)
<https://reviews.apache.org/r/73238/#comment311870>
I suggest to retain existing constructor that uses RangerClientConfig to read from config file. And add the new constructor that takes parameters: hostName, authType, userName and password.
- Madhan Neethiraj
On March 18, 2021, 9:39 p.m., Abhishek Kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73238/
> -----------------------------------------------------------
>
> (Updated March 18, 2021, 9:39 p.m.)
>
>
> Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Sailaja Polavarapu, Vishal Suvagia, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3212
> https://issues.apache.org/jira/browse/RANGER-3212
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Java client will now be packaged as part of ranger installation.
> Added client support for kerberos authentication.
> Added client support for TLS enabled ranger admin.
>
>
> Diffs
> -----
>
> distro/pom.xml 6d78e8e9b
> distro/src/main/assembly/sample-client.xml PRE-CREATION
> intg/src/main/java/org/apache/ranger/RangerClient.java bef385707
> intg/src/main/java/org/apache/ranger/RangerClientConfig.java 68ef0ffc3
> ranger-examples/sample-client/conf/config.properties 5be772ac1
> ranger-examples/sample-client/conf/ssl-client.xml PRE-CREATION
> ranger-examples/sample-client/scripts/run-sample-client.sh 2260476ef
> ranger-examples/sample-client/src/main/java/org/apache/ranger/examples/sampleclient/SampleClient.java b6ab3131d
>
>
> Diff: https://reviews.apache.org/r/73238/diff/2/
>
>
> Testing
> -------
>
> Tested the kerberos and SSL changes on remote cluster which hosts ranger admin.
>
>
> Thanks,
>
> Abhishek Kumar
>
>
Re: Review Request 73238: RANGER-3212: Added packaging,
kerberos and SSL support for Java Client
Posted by Abhishek Kumar <ab...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73238/
-----------------------------------------------------------
(Updated March 18, 2021, 9:39 p.m.)
Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Sailaja Polavarapu, Vishal Suvagia, and Velmurugan Periasamy.
Changes
-------
Tracking the changes in a new JIRA - RANGER-3212
Summary (updated)
-----------------
RANGER-3212: Added packaging, kerberos and SSL support for Java Client
Bugs: RANGER-3212
https://issues.apache.org/jira/browse/RANGER-3212
Repository: ranger
Description
-------
Java client will now be packaged as part of ranger installation.
Added client support for kerberos authentication.
Added client support for TLS enabled ranger admin.
Diffs (updated)
-----
distro/pom.xml 6d78e8e9b
distro/src/main/assembly/sample-client.xml PRE-CREATION
intg/src/main/java/org/apache/ranger/RangerClient.java bef385707
intg/src/main/java/org/apache/ranger/RangerClientConfig.java 68ef0ffc3
ranger-examples/sample-client/conf/config.properties 5be772ac1
ranger-examples/sample-client/conf/ssl-client.xml PRE-CREATION
ranger-examples/sample-client/scripts/run-sample-client.sh 2260476ef
ranger-examples/sample-client/src/main/java/org/apache/ranger/examples/sampleclient/SampleClient.java b6ab3131d
Diff: https://reviews.apache.org/r/73238/diff/2/
Changes: https://reviews.apache.org/r/73238/diff/1-2/
Testing
-------
Tested the kerberos and SSL changes on remote cluster which hosts ranger admin.
Thanks,
Abhishek Kumar
Re: Review Request 73238: RANGER-2862: Added packaging,
kerberos and SSL support for Java Client
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73238/#review222706
-----------------------------------------------------------
distro/pom.xml
Lines 78 (patched)
<https://reviews.apache.org/r/73238/#comment311869>
Patch looks fine. Ideally this should be tracked with a new JIRA since https://issues.apache.org/jira/browse/RANGER-2862 is closed. Can you please address that and revise? Thanks.
- Velmurugan Periasamy
On March 17, 2021, 10:12 p.m., Abhishek Kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73238/
> -----------------------------------------------------------
>
> (Updated March 17, 2021, 10:12 p.m.)
>
>
> Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Sailaja Polavarapu, Vishal Suvagia, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2862
> https://issues.apache.org/jira/browse/RANGER-2862
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Java client will now be packaged as part of ranger installation.
> Added client support for kerberos authentication.
> Added client support for TLS enabled ranger admin.
>
>
> Diffs
> -----
>
> distro/pom.xml 6d78e8e9b
> distro/src/main/assembly/sample-client.xml PRE-CREATION
> intg/src/main/java/org/apache/ranger/RangerClient.java bef385707
> intg/src/main/java/org/apache/ranger/RangerClientConfig.java 68ef0ffc3
> ranger-examples/sample-client/conf/config.properties 5be772ac1
> ranger-examples/sample-client/conf/ssl-client.xml PRE-CREATION
> ranger-examples/sample-client/scripts/run-sample-client.sh 2260476ef
> ranger-examples/sample-client/src/main/java/org/apache/ranger/examples/sampleclient/SampleClient.java b6ab3131d
>
>
> Diff: https://reviews.apache.org/r/73238/diff/1/
>
>
> Testing
> -------
>
> Tested the kerberos and SSL changes on remote cluster which hosts ranger admin.
>
>
> Thanks,
>
> Abhishek Kumar
>
>
Re: Review Request 73238: RANGER-2862: Added packaging,
kerberos and SSL support for Java Client
Posted by Abhishek Kumar <ab...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73238/#review222700
-----------------------------------------------------------
intg/src/main/java/org/apache/ranger/RangerClient.java
Line 163 (original), 162 (patched)
<https://reviews.apache.org/r/73238/#comment311866>
will remove it in revised review.
- Abhishek Kumar
On March 17, 2021, 10:12 p.m., Abhishek Kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73238/
> -----------------------------------------------------------
>
> (Updated March 17, 2021, 10:12 p.m.)
>
>
> Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, Sailaja Polavarapu, Vishal Suvagia, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2862
> https://issues.apache.org/jira/browse/RANGER-2862
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Java client will now be packaged as part of ranger installation.
> Added client support for kerberos authentication.
> Added client support for TLS enabled ranger admin.
>
>
> Diffs
> -----
>
> distro/pom.xml 6d78e8e9b
> distro/src/main/assembly/sample-client.xml PRE-CREATION
> intg/src/main/java/org/apache/ranger/RangerClient.java bef385707
> intg/src/main/java/org/apache/ranger/RangerClientConfig.java 68ef0ffc3
> ranger-examples/sample-client/conf/config.properties 5be772ac1
> ranger-examples/sample-client/conf/ssl-client.xml PRE-CREATION
> ranger-examples/sample-client/scripts/run-sample-client.sh 2260476ef
> ranger-examples/sample-client/src/main/java/org/apache/ranger/examples/sampleclient/SampleClient.java b6ab3131d
>
>
> Diff: https://reviews.apache.org/r/73238/diff/1/
>
>
> Testing
> -------
>
> Tested the kerberos and SSL changes on remote cluster which hosts ranger admin.
>
>
> Thanks,
>
> Abhishek Kumar
>
>