You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/07/18 17:20:50 UTC

[GitHub] [hbase] anoopsjohn commented on a change in pull request #2092: HBASE-21721 reduce write#syncs() times

anoopsjohn commented on a change in pull request #2092:
URL: https://github.com/apache/hbase/pull/2092#discussion_r456809912



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java
##########
@@ -595,8 +595,12 @@ public void run() {
           Throwable lastException = null;
           try {
             TraceUtil.addTimelineAnnotation("syncing writer");
+            long unSyncedFlushSeq = highestUnsyncedTxid;

Review comment:
       Ya this looks to be an issue. We update the highestSyncedTxid with currentSequence which was calculated in above steps.  By the time when we actually do the sync, it would have been changed. The moment we call a sync (by any syncer tread) we would sync all appends till then.
   cc @saintstack 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org