You are viewing a plain text version of this content. The canonical link for it is here.
Posted to wave-dev@incubator.apache.org by Evan Hughes <wi...@apache.org> on 2016/11/24 11:19:59 UTC
Stuff and mocking things
Hey all,
Been working on removing old dependencies and updating dependencies as can
be seen here
https://github.com/apache/incubator-wave/tree/fix/dependendices-2016 . It
seems we have to mocking lib's in use, if anyone is good with mockito would
you kindly help in transiting the tests with the other mocking library
(jmock)?
In other news ive been working on replacing the GXP (Google XML Pages)
which create html pages from a xml markup into standard HTML. This is work
being done to seperate the frontend and make it more modern, more will be
shown in coming week. After GXP is removed attention will then turn to the
Protobuf setup we have which atm needs to go through another utility, I
hope to remove this extra step with the transition to proto3. This would
mean the sub project PST (protobuf strings templates), would be depreciated
and can be lost to the void.
After this transitioning the clicent away from the server will be top
priority to allow swellrt to integrate without having bloat. Tis does not
mean Wave's intentional purpose is being changed but the entire UI will be
getting an upgrade as it gets transitioned, so expect to see new mixed with
old for a little while.
~ Evan
Re: Stuff and mocking things
Posted by Pablo Ojanguren <pa...@gmail.com>.
Good job Evan.
Regarding with gwt module inheritance... I found some problems with new gwt
version and path expresions in gwt modules. Does it ring you a bell?
2016-11-28 16:56 GMT+01:00 Yuri Z <ve...@gmail.com>:
> Great! I was sick for a few days, hopefully I ll get back to fixing the
> tests soon.
>
> On Mon, Nov 28, 2016 at 5:42 PM Evan Hughes <eh...@gmail.com> wrote:
>
> > I have finished changing everything over to mockito, I also managed to
> get
> > the gwt tests working now. Some of the gwt tests are working, some are
> not,
> > seems to mostly be missing inherited modules.
> >
> > On Sat, 26 Nov 2016 at 22:50 Evan Hughes <eh...@gmail.com> wrote:
> >
> > > Howd you end up going yuri, unfortunately the life/work balance got me
> > > this weekend so ill have to push it back till monday.
> > >
> > > On Thu, 24 Nov 2016 at 23:13 Yuri Z <ve...@gmail.com> wrote:
> > >
> > > I ll start with SchedulerTest.java
> > >
> > > On Thu, Nov 24, 2016 at 2:13 PM Evan Hughes <eh...@gmail.com> wrote:
> > >
> > > >
> > > >
> > >
> > incubator-wave/wave/src/test/java/org/waveprotocol/wave/
> client/scheduler/IdempotentSchedulerTest.java
> > > >
> > > >
> > >
> > incubator-wave/wave/src/test/java/org/waveprotocol/wave/
> client/scheduler/knobs/ControllerTest.java
> > > >
> > > >
> > >
> > incubator-wave/wave/src/test/java/org/waveprotocol/wave/
> client/scheduler/testing/FakeTimerServiceTest.java
> > > >
> > > > seems to only be 3, I have updated on that branch the version of
> > mockito
> > > > which had its own things to fix but they should be good now. I cant
> > touch
> > > > things again till this time tomorrow so feel free to choose which
> ones
> > > you
> > > > want.
> > > >
> > > > On Thu, 24 Nov 2016 at 22:04 Yuri Z <ve...@gmail.com> wrote:
> > > >
> > > > > Sure, I guess I can help with this. How we coordinate to ensure we
> > > don't
> > > > > work on the same tests? Would you like to send me a few test class
> > > names
> > > > to
> > > > > work on?
> > > > >
> > > > > On Thu, Nov 24, 2016 at 1:59 PM Evan Hughes <
> wisebaldone@apache.org>
> > > > > wrote:
> > > > >
> > > > > > We shouldn't have 2 mocking libraries and mockito is the superior
> > one
> > > > > since
> > > > > > its continually maintained. We can even do fancy things like this
> > > > > > http://google.github.io/gwtmockito/ in the future to aid in
> having
> > > the
> > > > > gwt
> > > > > > js library well tested.
> > > > > >
> > > > > > On Thu, 24 Nov 2016 at 21:50 Yuri Z <ve...@gmail.com> wrote:
> > > > > >
> > > > > > > Great news, thanks Evan!
> > > > > > > Regarding mockito - what are the issues?
> > > > > > >
> > > > > > > On Thu, Nov 24, 2016 at 1:20 PM Evan Hughes <
> > > wisebaldone@apache.org>
> > > > > > > wrote:
> > > > > > >
> > > > > > > > Hey all,
> > > > > > > >
> > > > > > > > Been working on removing old dependencies and updating
> > > dependencies
> > > > > as
> > > > > > > can
> > > > > > > > be seen here
> > > > > > > >
> > > > https://github.com/apache/incubator-wave/tree/fix/dependendices-2016
> > > > > .
> > > > > > > It
> > > > > > > > seems we have to mocking lib's in use, if anyone is good with
> > > > mockito
> > > > > > > would
> > > > > > > > you kindly help in transiting the tests with the other
> mocking
> > > > > library
> > > > > > > > (jmock)?
> > > > > > > >
> > > > > > > > In other news ive been working on replacing the GXP (Google
> XML
> > > > > Pages)
> > > > > > > > which create html pages from a xml markup into standard HTML.
> > > This
> > > > is
> > > > > > > work
> > > > > > > > being done to seperate the frontend and make it more modern,
> > more
> > > > > will
> > > > > > be
> > > > > > > > shown in coming week. After GXP is removed attention will
> then
> > > turn
> > > > > to
> > > > > > > the
> > > > > > > > Protobuf setup we have which atm needs to go through another
> > > > > utility, I
> > > > > > > > hope to remove this extra step with the transition to proto3.
> > > This
> > > > > > would
> > > > > > > > mean the sub project PST (protobuf strings templates), would
> be
> > > > > > > depreciated
> > > > > > > > and can be lost to the void.
> > > > > > > >
> > > > > > > > After this transitioning the clicent away from the server
> will
> > be
> > > > top
> > > > > > > > priority to allow swellrt to integrate without having bloat.
> > Tis
> > > > does
> > > > > > not
> > > > > > > > mean Wave's intentional purpose is being changed but the
> entire
> > > UI
> > > > > will
> > > > > > > be
> > > > > > > > getting an upgrade as it gets transitioned, so expect to see
> > new
> > > > > mixed
> > > > > > > with
> > > > > > > > old for a little while.
> > > > > > > >
> > > > > > > > ~ Evan
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> > >
> >
>
Re: Stuff and mocking things
Posted by Yuri Z <ve...@gmail.com>.
Great! I was sick for a few days, hopefully I ll get back to fixing the
tests soon.
On Mon, Nov 28, 2016 at 5:42 PM Evan Hughes <eh...@gmail.com> wrote:
> I have finished changing everything over to mockito, I also managed to get
> the gwt tests working now. Some of the gwt tests are working, some are not,
> seems to mostly be missing inherited modules.
>
> On Sat, 26 Nov 2016 at 22:50 Evan Hughes <eh...@gmail.com> wrote:
>
> > Howd you end up going yuri, unfortunately the life/work balance got me
> > this weekend so ill have to push it back till monday.
> >
> > On Thu, 24 Nov 2016 at 23:13 Yuri Z <ve...@gmail.com> wrote:
> >
> > I ll start with SchedulerTest.java
> >
> > On Thu, Nov 24, 2016 at 2:13 PM Evan Hughes <eh...@gmail.com> wrote:
> >
> > >
> > >
> >
> incubator-wave/wave/src/test/java/org/waveprotocol/wave/client/scheduler/IdempotentSchedulerTest.java
> > >
> > >
> >
> incubator-wave/wave/src/test/java/org/waveprotocol/wave/client/scheduler/knobs/ControllerTest.java
> > >
> > >
> >
> incubator-wave/wave/src/test/java/org/waveprotocol/wave/client/scheduler/testing/FakeTimerServiceTest.java
> > >
> > > seems to only be 3, I have updated on that branch the version of
> mockito
> > > which had its own things to fix but they should be good now. I cant
> touch
> > > things again till this time tomorrow so feel free to choose which ones
> > you
> > > want.
> > >
> > > On Thu, 24 Nov 2016 at 22:04 Yuri Z <ve...@gmail.com> wrote:
> > >
> > > > Sure, I guess I can help with this. How we coordinate to ensure we
> > don't
> > > > work on the same tests? Would you like to send me a few test class
> > names
> > > to
> > > > work on?
> > > >
> > > > On Thu, Nov 24, 2016 at 1:59 PM Evan Hughes <wi...@apache.org>
> > > > wrote:
> > > >
> > > > > We shouldn't have 2 mocking libraries and mockito is the superior
> one
> > > > since
> > > > > its continually maintained. We can even do fancy things like this
> > > > > http://google.github.io/gwtmockito/ in the future to aid in having
> > the
> > > > gwt
> > > > > js library well tested.
> > > > >
> > > > > On Thu, 24 Nov 2016 at 21:50 Yuri Z <ve...@gmail.com> wrote:
> > > > >
> > > > > > Great news, thanks Evan!
> > > > > > Regarding mockito - what are the issues?
> > > > > >
> > > > > > On Thu, Nov 24, 2016 at 1:20 PM Evan Hughes <
> > wisebaldone@apache.org>
> > > > > > wrote:
> > > > > >
> > > > > > > Hey all,
> > > > > > >
> > > > > > > Been working on removing old dependencies and updating
> > dependencies
> > > > as
> > > > > > can
> > > > > > > be seen here
> > > > > > >
> > > https://github.com/apache/incubator-wave/tree/fix/dependendices-2016
> > > > .
> > > > > > It
> > > > > > > seems we have to mocking lib's in use, if anyone is good with
> > > mockito
> > > > > > would
> > > > > > > you kindly help in transiting the tests with the other mocking
> > > > library
> > > > > > > (jmock)?
> > > > > > >
> > > > > > > In other news ive been working on replacing the GXP (Google XML
> > > > Pages)
> > > > > > > which create html pages from a xml markup into standard HTML.
> > This
> > > is
> > > > > > work
> > > > > > > being done to seperate the frontend and make it more modern,
> more
> > > > will
> > > > > be
> > > > > > > shown in coming week. After GXP is removed attention will then
> > turn
> > > > to
> > > > > > the
> > > > > > > Protobuf setup we have which atm needs to go through another
> > > > utility, I
> > > > > > > hope to remove this extra step with the transition to proto3.
> > This
> > > > > would
> > > > > > > mean the sub project PST (protobuf strings templates), would be
> > > > > > depreciated
> > > > > > > and can be lost to the void.
> > > > > > >
> > > > > > > After this transitioning the clicent away from the server will
> be
> > > top
> > > > > > > priority to allow swellrt to integrate without having bloat.
> Tis
> > > does
> > > > > not
> > > > > > > mean Wave's intentional purpose is being changed but the entire
> > UI
> > > > will
> > > > > > be
> > > > > > > getting an upgrade as it gets transitioned, so expect to see
> new
> > > > mixed
> > > > > > with
> > > > > > > old for a little while.
> > > > > > >
> > > > > > > ~ Evan
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> >
>
Re: Stuff and mocking things
Posted by Evan Hughes <eh...@gmail.com>.
I have finished changing everything over to mockito, I also managed to get
the gwt tests working now. Some of the gwt tests are working, some are not,
seems to mostly be missing inherited modules.
On Sat, 26 Nov 2016 at 22:50 Evan Hughes <eh...@gmail.com> wrote:
> Howd you end up going yuri, unfortunately the life/work balance got me
> this weekend so ill have to push it back till monday.
>
> On Thu, 24 Nov 2016 at 23:13 Yuri Z <ve...@gmail.com> wrote:
>
> I ll start with SchedulerTest.java
>
> On Thu, Nov 24, 2016 at 2:13 PM Evan Hughes <eh...@gmail.com> wrote:
>
> >
> >
> incubator-wave/wave/src/test/java/org/waveprotocol/wave/client/scheduler/IdempotentSchedulerTest.java
> >
> >
> incubator-wave/wave/src/test/java/org/waveprotocol/wave/client/scheduler/knobs/ControllerTest.java
> >
> >
> incubator-wave/wave/src/test/java/org/waveprotocol/wave/client/scheduler/testing/FakeTimerServiceTest.java
> >
> > seems to only be 3, I have updated on that branch the version of mockito
> > which had its own things to fix but they should be good now. I cant touch
> > things again till this time tomorrow so feel free to choose which ones
> you
> > want.
> >
> > On Thu, 24 Nov 2016 at 22:04 Yuri Z <ve...@gmail.com> wrote:
> >
> > > Sure, I guess I can help with this. How we coordinate to ensure we
> don't
> > > work on the same tests? Would you like to send me a few test class
> names
> > to
> > > work on?
> > >
> > > On Thu, Nov 24, 2016 at 1:59 PM Evan Hughes <wi...@apache.org>
> > > wrote:
> > >
> > > > We shouldn't have 2 mocking libraries and mockito is the superior one
> > > since
> > > > its continually maintained. We can even do fancy things like this
> > > > http://google.github.io/gwtmockito/ in the future to aid in having
> the
> > > gwt
> > > > js library well tested.
> > > >
> > > > On Thu, 24 Nov 2016 at 21:50 Yuri Z <ve...@gmail.com> wrote:
> > > >
> > > > > Great news, thanks Evan!
> > > > > Regarding mockito - what are the issues?
> > > > >
> > > > > On Thu, Nov 24, 2016 at 1:20 PM Evan Hughes <
> wisebaldone@apache.org>
> > > > > wrote:
> > > > >
> > > > > > Hey all,
> > > > > >
> > > > > > Been working on removing old dependencies and updating
> dependencies
> > > as
> > > > > can
> > > > > > be seen here
> > > > > >
> > https://github.com/apache/incubator-wave/tree/fix/dependendices-2016
> > > .
> > > > > It
> > > > > > seems we have to mocking lib's in use, if anyone is good with
> > mockito
> > > > > would
> > > > > > you kindly help in transiting the tests with the other mocking
> > > library
> > > > > > (jmock)?
> > > > > >
> > > > > > In other news ive been working on replacing the GXP (Google XML
> > > Pages)
> > > > > > which create html pages from a xml markup into standard HTML.
> This
> > is
> > > > > work
> > > > > > being done to seperate the frontend and make it more modern, more
> > > will
> > > > be
> > > > > > shown in coming week. After GXP is removed attention will then
> turn
> > > to
> > > > > the
> > > > > > Protobuf setup we have which atm needs to go through another
> > > utility, I
> > > > > > hope to remove this extra step with the transition to proto3.
> This
> > > > would
> > > > > > mean the sub project PST (protobuf strings templates), would be
> > > > > depreciated
> > > > > > and can be lost to the void.
> > > > > >
> > > > > > After this transitioning the clicent away from the server will be
> > top
> > > > > > priority to allow swellrt to integrate without having bloat. Tis
> > does
> > > > not
> > > > > > mean Wave's intentional purpose is being changed but the entire
> UI
> > > will
> > > > > be
> > > > > > getting an upgrade as it gets transitioned, so expect to see new
> > > mixed
> > > > > with
> > > > > > old for a little while.
> > > > > >
> > > > > > ~ Evan
> > > > > >
> > > > >
> > > >
> > >
> >
>
>
Re: Stuff and mocking things
Posted by Evan Hughes <eh...@gmail.com>.
Howd you end up going yuri, unfortunately the life/work balance got me this
weekend so ill have to push it back till monday.
On Thu, 24 Nov 2016 at 23:13 Yuri Z <ve...@gmail.com> wrote:
> I ll start with SchedulerTest.java
>
> On Thu, Nov 24, 2016 at 2:13 PM Evan Hughes <eh...@gmail.com> wrote:
>
> >
> >
> incubator-wave/wave/src/test/java/org/waveprotocol/wave/client/scheduler/IdempotentSchedulerTest.java
> >
> >
> incubator-wave/wave/src/test/java/org/waveprotocol/wave/client/scheduler/knobs/ControllerTest.java
> >
> >
> incubator-wave/wave/src/test/java/org/waveprotocol/wave/client/scheduler/testing/FakeTimerServiceTest.java
> >
> > seems to only be 3, I have updated on that branch the version of mockito
> > which had its own things to fix but they should be good now. I cant touch
> > things again till this time tomorrow so feel free to choose which ones
> you
> > want.
> >
> > On Thu, 24 Nov 2016 at 22:04 Yuri Z <ve...@gmail.com> wrote:
> >
> > > Sure, I guess I can help with this. How we coordinate to ensure we
> don't
> > > work on the same tests? Would you like to send me a few test class
> names
> > to
> > > work on?
> > >
> > > On Thu, Nov 24, 2016 at 1:59 PM Evan Hughes <wi...@apache.org>
> > > wrote:
> > >
> > > > We shouldn't have 2 mocking libraries and mockito is the superior one
> > > since
> > > > its continually maintained. We can even do fancy things like this
> > > > http://google.github.io/gwtmockito/ in the future to aid in having
> the
> > > gwt
> > > > js library well tested.
> > > >
> > > > On Thu, 24 Nov 2016 at 21:50 Yuri Z <ve...@gmail.com> wrote:
> > > >
> > > > > Great news, thanks Evan!
> > > > > Regarding mockito - what are the issues?
> > > > >
> > > > > On Thu, Nov 24, 2016 at 1:20 PM Evan Hughes <
> wisebaldone@apache.org>
> > > > > wrote:
> > > > >
> > > > > > Hey all,
> > > > > >
> > > > > > Been working on removing old dependencies and updating
> dependencies
> > > as
> > > > > can
> > > > > > be seen here
> > > > > >
> > https://github.com/apache/incubator-wave/tree/fix/dependendices-2016
> > > .
> > > > > It
> > > > > > seems we have to mocking lib's in use, if anyone is good with
> > mockito
> > > > > would
> > > > > > you kindly help in transiting the tests with the other mocking
> > > library
> > > > > > (jmock)?
> > > > > >
> > > > > > In other news ive been working on replacing the GXP (Google XML
> > > Pages)
> > > > > > which create html pages from a xml markup into standard HTML.
> This
> > is
> > > > > work
> > > > > > being done to seperate the frontend and make it more modern, more
> > > will
> > > > be
> > > > > > shown in coming week. After GXP is removed attention will then
> turn
> > > to
> > > > > the
> > > > > > Protobuf setup we have which atm needs to go through another
> > > utility, I
> > > > > > hope to remove this extra step with the transition to proto3.
> This
> > > > would
> > > > > > mean the sub project PST (protobuf strings templates), would be
> > > > > depreciated
> > > > > > and can be lost to the void.
> > > > > >
> > > > > > After this transitioning the clicent away from the server will be
> > top
> > > > > > priority to allow swellrt to integrate without having bloat. Tis
> > does
> > > > not
> > > > > > mean Wave's intentional purpose is being changed but the entire
> UI
> > > will
> > > > > be
> > > > > > getting an upgrade as it gets transitioned, so expect to see new
> > > mixed
> > > > > with
> > > > > > old for a little while.
> > > > > >
> > > > > > ~ Evan
> > > > > >
> > > > >
> > > >
> > >
> >
>
Re: Stuff and mocking things
Posted by Yuri Z <ve...@gmail.com>.
I ll start with SchedulerTest.java
On Thu, Nov 24, 2016 at 2:13 PM Evan Hughes <eh...@gmail.com> wrote:
>
> incubator-wave/wave/src/test/java/org/waveprotocol/wave/client/scheduler/IdempotentSchedulerTest.java
>
> incubator-wave/wave/src/test/java/org/waveprotocol/wave/client/scheduler/knobs/ControllerTest.java
>
> incubator-wave/wave/src/test/java/org/waveprotocol/wave/client/scheduler/testing/FakeTimerServiceTest.java
>
> seems to only be 3, I have updated on that branch the version of mockito
> which had its own things to fix but they should be good now. I cant touch
> things again till this time tomorrow so feel free to choose which ones you
> want.
>
> On Thu, 24 Nov 2016 at 22:04 Yuri Z <ve...@gmail.com> wrote:
>
> > Sure, I guess I can help with this. How we coordinate to ensure we don't
> > work on the same tests? Would you like to send me a few test class names
> to
> > work on?
> >
> > On Thu, Nov 24, 2016 at 1:59 PM Evan Hughes <wi...@apache.org>
> > wrote:
> >
> > > We shouldn't have 2 mocking libraries and mockito is the superior one
> > since
> > > its continually maintained. We can even do fancy things like this
> > > http://google.github.io/gwtmockito/ in the future to aid in having the
> > gwt
> > > js library well tested.
> > >
> > > On Thu, 24 Nov 2016 at 21:50 Yuri Z <ve...@gmail.com> wrote:
> > >
> > > > Great news, thanks Evan!
> > > > Regarding mockito - what are the issues?
> > > >
> > > > On Thu, Nov 24, 2016 at 1:20 PM Evan Hughes <wi...@apache.org>
> > > > wrote:
> > > >
> > > > > Hey all,
> > > > >
> > > > > Been working on removing old dependencies and updating dependencies
> > as
> > > > can
> > > > > be seen here
> > > > >
> https://github.com/apache/incubator-wave/tree/fix/dependendices-2016
> > .
> > > > It
> > > > > seems we have to mocking lib's in use, if anyone is good with
> mockito
> > > > would
> > > > > you kindly help in transiting the tests with the other mocking
> > library
> > > > > (jmock)?
> > > > >
> > > > > In other news ive been working on replacing the GXP (Google XML
> > Pages)
> > > > > which create html pages from a xml markup into standard HTML. This
> is
> > > > work
> > > > > being done to seperate the frontend and make it more modern, more
> > will
> > > be
> > > > > shown in coming week. After GXP is removed attention will then turn
> > to
> > > > the
> > > > > Protobuf setup we have which atm needs to go through another
> > utility, I
> > > > > hope to remove this extra step with the transition to proto3. This
> > > would
> > > > > mean the sub project PST (protobuf strings templates), would be
> > > > depreciated
> > > > > and can be lost to the void.
> > > > >
> > > > > After this transitioning the clicent away from the server will be
> top
> > > > > priority to allow swellrt to integrate without having bloat. Tis
> does
> > > not
> > > > > mean Wave's intentional purpose is being changed but the entire UI
> > will
> > > > be
> > > > > getting an upgrade as it gets transitioned, so expect to see new
> > mixed
> > > > with
> > > > > old for a little while.
> > > > >
> > > > > ~ Evan
> > > > >
> > > >
> > >
> >
>
Re: Stuff and mocking things
Posted by Evan Hughes <eh...@gmail.com>.
incubator-wave/wave/src/test/java/org/waveprotocol/wave/client/scheduler/IdempotentSchedulerTest.java
incubator-wave/wave/src/test/java/org/waveprotocol/wave/client/scheduler/knobs/ControllerTest.java
incubator-wave/wave/src/test/java/org/waveprotocol/wave/client/scheduler/testing/FakeTimerServiceTest.java
seems to only be 3, I have updated on that branch the version of mockito
which had its own things to fix but they should be good now. I cant touch
things again till this time tomorrow so feel free to choose which ones you
want.
On Thu, 24 Nov 2016 at 22:04 Yuri Z <ve...@gmail.com> wrote:
> Sure, I guess I can help with this. How we coordinate to ensure we don't
> work on the same tests? Would you like to send me a few test class names to
> work on?
>
> On Thu, Nov 24, 2016 at 1:59 PM Evan Hughes <wi...@apache.org>
> wrote:
>
> > We shouldn't have 2 mocking libraries and mockito is the superior one
> since
> > its continually maintained. We can even do fancy things like this
> > http://google.github.io/gwtmockito/ in the future to aid in having the
> gwt
> > js library well tested.
> >
> > On Thu, 24 Nov 2016 at 21:50 Yuri Z <ve...@gmail.com> wrote:
> >
> > > Great news, thanks Evan!
> > > Regarding mockito - what are the issues?
> > >
> > > On Thu, Nov 24, 2016 at 1:20 PM Evan Hughes <wi...@apache.org>
> > > wrote:
> > >
> > > > Hey all,
> > > >
> > > > Been working on removing old dependencies and updating dependencies
> as
> > > can
> > > > be seen here
> > > > https://github.com/apache/incubator-wave/tree/fix/dependendices-2016
> .
> > > It
> > > > seems we have to mocking lib's in use, if anyone is good with mockito
> > > would
> > > > you kindly help in transiting the tests with the other mocking
> library
> > > > (jmock)?
> > > >
> > > > In other news ive been working on replacing the GXP (Google XML
> Pages)
> > > > which create html pages from a xml markup into standard HTML. This is
> > > work
> > > > being done to seperate the frontend and make it more modern, more
> will
> > be
> > > > shown in coming week. After GXP is removed attention will then turn
> to
> > > the
> > > > Protobuf setup we have which atm needs to go through another
> utility, I
> > > > hope to remove this extra step with the transition to proto3. This
> > would
> > > > mean the sub project PST (protobuf strings templates), would be
> > > depreciated
> > > > and can be lost to the void.
> > > >
> > > > After this transitioning the clicent away from the server will be top
> > > > priority to allow swellrt to integrate without having bloat. Tis does
> > not
> > > > mean Wave's intentional purpose is being changed but the entire UI
> will
> > > be
> > > > getting an upgrade as it gets transitioned, so expect to see new
> mixed
> > > with
> > > > old for a little while.
> > > >
> > > > ~ Evan
> > > >
> > >
> >
>
Re: Stuff and mocking things
Posted by Yuri Z <ve...@gmail.com>.
Sure, I guess I can help with this. How we coordinate to ensure we don't
work on the same tests? Would you like to send me a few test class names to
work on?
On Thu, Nov 24, 2016 at 1:59 PM Evan Hughes <wi...@apache.org> wrote:
> We shouldn't have 2 mocking libraries and mockito is the superior one since
> its continually maintained. We can even do fancy things like this
> http://google.github.io/gwtmockito/ in the future to aid in having the gwt
> js library well tested.
>
> On Thu, 24 Nov 2016 at 21:50 Yuri Z <ve...@gmail.com> wrote:
>
> > Great news, thanks Evan!
> > Regarding mockito - what are the issues?
> >
> > On Thu, Nov 24, 2016 at 1:20 PM Evan Hughes <wi...@apache.org>
> > wrote:
> >
> > > Hey all,
> > >
> > > Been working on removing old dependencies and updating dependencies as
> > can
> > > be seen here
> > > https://github.com/apache/incubator-wave/tree/fix/dependendices-2016 .
> > It
> > > seems we have to mocking lib's in use, if anyone is good with mockito
> > would
> > > you kindly help in transiting the tests with the other mocking library
> > > (jmock)?
> > >
> > > In other news ive been working on replacing the GXP (Google XML Pages)
> > > which create html pages from a xml markup into standard HTML. This is
> > work
> > > being done to seperate the frontend and make it more modern, more will
> be
> > > shown in coming week. After GXP is removed attention will then turn to
> > the
> > > Protobuf setup we have which atm needs to go through another utility, I
> > > hope to remove this extra step with the transition to proto3. This
> would
> > > mean the sub project PST (protobuf strings templates), would be
> > depreciated
> > > and can be lost to the void.
> > >
> > > After this transitioning the clicent away from the server will be top
> > > priority to allow swellrt to integrate without having bloat. Tis does
> not
> > > mean Wave's intentional purpose is being changed but the entire UI will
> > be
> > > getting an upgrade as it gets transitioned, so expect to see new mixed
> > with
> > > old for a little while.
> > >
> > > ~ Evan
> > >
> >
>
Re: Stuff and mocking things
Posted by Evan Hughes <wi...@apache.org>.
We shouldn't have 2 mocking libraries and mockito is the superior one since
its continually maintained. We can even do fancy things like this
http://google.github.io/gwtmockito/ in the future to aid in having the gwt
js library well tested.
On Thu, 24 Nov 2016 at 21:50 Yuri Z <ve...@gmail.com> wrote:
> Great news, thanks Evan!
> Regarding mockito - what are the issues?
>
> On Thu, Nov 24, 2016 at 1:20 PM Evan Hughes <wi...@apache.org>
> wrote:
>
> > Hey all,
> >
> > Been working on removing old dependencies and updating dependencies as
> can
> > be seen here
> > https://github.com/apache/incubator-wave/tree/fix/dependendices-2016 .
> It
> > seems we have to mocking lib's in use, if anyone is good with mockito
> would
> > you kindly help in transiting the tests with the other mocking library
> > (jmock)?
> >
> > In other news ive been working on replacing the GXP (Google XML Pages)
> > which create html pages from a xml markup into standard HTML. This is
> work
> > being done to seperate the frontend and make it more modern, more will be
> > shown in coming week. After GXP is removed attention will then turn to
> the
> > Protobuf setup we have which atm needs to go through another utility, I
> > hope to remove this extra step with the transition to proto3. This would
> > mean the sub project PST (protobuf strings templates), would be
> depreciated
> > and can be lost to the void.
> >
> > After this transitioning the clicent away from the server will be top
> > priority to allow swellrt to integrate without having bloat. Tis does not
> > mean Wave's intentional purpose is being changed but the entire UI will
> be
> > getting an upgrade as it gets transitioned, so expect to see new mixed
> with
> > old for a little while.
> >
> > ~ Evan
> >
>
Re: Stuff and mocking things
Posted by Yuri Z <ve...@gmail.com>.
Great news, thanks Evan!
Regarding mockito - what are the issues?
On Thu, Nov 24, 2016 at 1:20 PM Evan Hughes <wi...@apache.org> wrote:
> Hey all,
>
> Been working on removing old dependencies and updating dependencies as can
> be seen here
> https://github.com/apache/incubator-wave/tree/fix/dependendices-2016 . It
> seems we have to mocking lib's in use, if anyone is good with mockito would
> you kindly help in transiting the tests with the other mocking library
> (jmock)?
>
> In other news ive been working on replacing the GXP (Google XML Pages)
> which create html pages from a xml markup into standard HTML. This is work
> being done to seperate the frontend and make it more modern, more will be
> shown in coming week. After GXP is removed attention will then turn to the
> Protobuf setup we have which atm needs to go through another utility, I
> hope to remove this extra step with the transition to proto3. This would
> mean the sub project PST (protobuf strings templates), would be depreciated
> and can be lost to the void.
>
> After this transitioning the clicent away from the server will be top
> priority to allow swellrt to integrate without having bloat. Tis does not
> mean Wave's intentional purpose is being changed but the entire UI will be
> getting an upgrade as it gets transitioned, so expect to see new mixed with
> old for a little while.
>
> ~ Evan
>
Re: Stuff and mocking things
Posted by Evan Hughes <eh...@gmail.com>.
@yuri I hope ur feeling better.
@pablo I dont believe so, it seems that its more the cause of the tests
just never being kept inline with the code. The main module with wave also
has 5 error's but they are an entire differnt ballpark.
With the transition, it will become clearer after ive finished getting rid
of the gxp. But in the end ild like to seperate what the wave client was
and the OT lib beneath it. It builds apon the discussions not too long ago
that the community had.
On 29/11/2016 2:51 AM, "Pablo Ojanguren" <pa...@gmail.com> wrote:
> Hi Evan, I was reading again your email I am afraid I don't understand your
> last paragraph properly. ;) how is the plan you refer?
> Thanks!
>
>
> 2016-11-24 12:19 GMT+01:00 Evan Hughes <wi...@apache.org>:
>
> > Hey all,
> >
> > Been working on removing old dependencies and updating dependencies as
> can
> > be seen here
> > https://github.com/apache/incubator-wave/tree/fix/dependendices-2016 .
> It
> > seems we have to mocking lib's in use, if anyone is good with mockito
> would
> > you kindly help in transiting the tests with the other mocking library
> > (jmock)?
> >
> > In other news ive been working on replacing the GXP (Google XML Pages)
> > which create html pages from a xml markup into standard HTML. This is
> work
> > being done to seperate the frontend and make it more modern, more will be
> > shown in coming week. After GXP is removed attention will then turn to
> the
> > Protobuf setup we have which atm needs to go through another utility, I
> > hope to remove this extra step with the transition to proto3. This would
> > mean the sub project PST (protobuf strings templates), would be
> depreciated
> > and can be lost to the void.
> >
> > After this transitioning the clicent away from the server will be top
> > priority to allow swellrt to integrate without having bloat. Tis does not
> > mean Wave's intentional purpose is being changed but the entire UI will
> be
> > getting an upgrade as it gets transitioned, so expect to see new mixed
> with
> > old for a little while.
> >
> > ~ Evan
> >
>
Re: Stuff and mocking things
Posted by Pablo Ojanguren <pa...@gmail.com>.
Hi Evan, I was reading again your email I am afraid I don't understand your
last paragraph properly. ;) how is the plan you refer?
Thanks!
2016-11-24 12:19 GMT+01:00 Evan Hughes <wi...@apache.org>:
> Hey all,
>
> Been working on removing old dependencies and updating dependencies as can
> be seen here
> https://github.com/apache/incubator-wave/tree/fix/dependendices-2016 . It
> seems we have to mocking lib's in use, if anyone is good with mockito would
> you kindly help in transiting the tests with the other mocking library
> (jmock)?
>
> In other news ive been working on replacing the GXP (Google XML Pages)
> which create html pages from a xml markup into standard HTML. This is work
> being done to seperate the frontend and make it more modern, more will be
> shown in coming week. After GXP is removed attention will then turn to the
> Protobuf setup we have which atm needs to go through another utility, I
> hope to remove this extra step with the transition to proto3. This would
> mean the sub project PST (protobuf strings templates), would be depreciated
> and can be lost to the void.
>
> After this transitioning the clicent away from the server will be top
> priority to allow swellrt to integrate without having bloat. Tis does not
> mean Wave's intentional purpose is being changed but the entire UI will be
> getting an upgrade as it gets transitioned, so expect to see new mixed with
> old for a little while.
>
> ~ Evan
>