[GitHub] [hadoop] slfan1989 commented on a diff in pull request #5381: HDFS-16914. Add some logs for updateBlockForPipeline RPC.

["slfan1989 (via GitHub)" <gi...@apache.org>]

slfan1989 commented on code in PR #5381:
URL: https://github.com/apache/hadoop/pull/5381#discussion_r1102400991


##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java:
##########
@@ -5943,6 +5943,9 @@ LocatedBlock bumpBlockGenerationStamp(ExtendedBlock block,
     }
     // Ensure we record the new generation stamp
     getEditLog().logSync();
+    LOG.info("bumpBlockGenerationStamp(" + locatedBlock.getBlock()
+        + ", client=" + clientName

Review Comment:
   Thanks for your contribution, but we need to use {} instead of +.
   
   like this
   ```
    LOG.info("bumpBlockGenerationStamp({}), client={}", locatedBlock.getBlock(), clientName)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org