You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tamas Mate (Code Review)" <ge...@cloudera.org> on 2022/04/01 13:58:38 UTC
[Impala-ASF-CR] IMPALA-11216: Fix flaky test describe history params
Tamas Mate has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18375
Change subject: IMPALA-11216: Fix flaky test_describe_history_params
......................................................................
IMPALA-11216: Fix flaky test_describe_history_params
The test_describe_history_params was flaky because the client can
receive the timestamps in two formats, with or without nanoseconds.
This commit updates the test to handle both patterns.
Testing:
- Executed the test locally.
Change-Id: I6aaae9b9fc14dd20390c16f9555d6f43357814a5
---
M tests/query_test/test_iceberg.py
1 file changed, 15 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/75/18375/1
--
To view, visit http://gerrit.cloudera.org:8080/18375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6aaae9b9fc14dd20390c16f9555d6f43357814a5
Gerrit-Change-Number: 18375
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-11216: Fix flaky test describe history params
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18375 )
Change subject: IMPALA-11216: Fix flaky test_describe_history_params
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6aaae9b9fc14dd20390c16f9555d6f43357814a5
Gerrit-Change-Number: 18375
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sat, 02 Apr 2022 11:00:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11216: Fix flaky test describe history params
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/18375 )
Change subject: IMPALA-11216: Fix flaky test_describe_history_params
......................................................................
Patch Set 1:
Thank you for the review Zoltan!
--
To view, visit http://gerrit.cloudera.org:8080/18375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6aaae9b9fc14dd20390c16f9555d6f43357814a5
Gerrit-Change-Number: 18375
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sat, 02 Apr 2022 06:31:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11216: Fix flaky test describe history params
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18375 )
Change subject: IMPALA-11216: Fix flaky test_describe_history_params
......................................................................
Patch Set 1: Code-Review+2
Thanks for fixing this!
--
To view, visit http://gerrit.cloudera.org:8080/18375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6aaae9b9fc14dd20390c16f9555d6f43357814a5
Gerrit-Change-Number: 18375
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 Apr 2022 16:06:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11216: Fix flaky test describe history params
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18375 )
Change subject: IMPALA-11216: Fix flaky test_describe_history_params
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10380/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6aaae9b9fc14dd20390c16f9555d6f43357814a5
Gerrit-Change-Number: 18375
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 Apr 2022 14:18:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11216: Fix flaky test describe history params
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18375 )
Change subject: IMPALA-11216: Fix flaky test_describe_history_params
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6aaae9b9fc14dd20390c16f9555d6f43357814a5
Gerrit-Change-Number: 18375
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sat, 02 Apr 2022 06:31:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11216: Fix flaky test describe history params
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18375 )
Change subject: IMPALA-11216: Fix flaky test_describe_history_params
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8009/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6aaae9b9fc14dd20390c16f9555d6f43357814a5
Gerrit-Change-Number: 18375
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sat, 02 Apr 2022 06:31:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11216: Fix flaky test describe history params
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18375 )
Change subject: IMPALA-11216: Fix flaky test_describe_history_params
......................................................................
IMPALA-11216: Fix flaky test_describe_history_params
The test_describe_history_params was flaky because the client can
receive the timestamps in two formats, with or without nanoseconds.
This commit updates the test to handle both patterns.
Testing:
- Executed the test locally.
Change-Id: I6aaae9b9fc14dd20390c16f9555d6f43357814a5
Reviewed-on: http://gerrit.cloudera.org:8080/18375
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/query_test/test_iceberg.py
1 file changed, 15 insertions(+), 9 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6aaae9b9fc14dd20390c16f9555d6f43357814a5
Gerrit-Change-Number: 18375
Gerrit-PatchSet: 3
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>