You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Ramachandran Krishnan <ra...@gmail.com> on 2022/10/11 17:27:07 UTC
Re: Review Request 74115: dbLoadTime is not added correctly in RangerServicePoliciesCache
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74115/
-----------------------------------------------------------
(Updated Oct. 11, 2022, 5:27 p.m.)
Review request for ranger, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Nikhil P, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
Summary (updated)
-----------------
dbLoadTime is not added correctly in RangerServicePoliciesCache
Bugs: RANGER-3902
https://issues.apache.org/jira/browse/RANGER-3902
Repository: ranger
Description (updated)
-------
dbLoadTime is not added correctly in RangerServicePoliciesCache
Proposal :
servicePoliciesFromDb = serviceStore.getServicePolicyDeltasOrPolicies(serviceName, cachedServicePoliciesVersion);
It should be calcuated properly after fetching servicePoliciesFromDb like
final long dbLoadTime = System.currentTimeMillis() - startTimeMs;
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/common/RangerServicePoliciesCache.java b1447829b
Diff: https://reviews.apache.org/r/74115/diff/4/
Changes: https://reviews.apache.org/r/74115/diff/3-4/
Testing
-------
Tested this change in the log files
Thanks,
Ramachandran Krishnan
Re: Review Request 74115: dbLoadTime is not added correctly in RangerServicePoliciesCache
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74115/#review224782
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Oct. 11, 2022, 5:27 p.m., Ramachandran Krishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74115/
> -----------------------------------------------------------
>
> (Updated Oct. 11, 2022, 5:27 p.m.)
>
>
> Review request for ranger, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Nikhil P, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3902
> https://issues.apache.org/jira/browse/RANGER-3902
>
>
> Repository: ranger
>
>
> Description
> -------
>
> dbLoadTime is not added correctly in RangerServicePoliciesCache
>
> Proposal :
>
> servicePoliciesFromDb = serviceStore.getServicePolicyDeltasOrPolicies(serviceName, cachedServicePoliciesVersion);
> It should be calcuated properly after fetching servicePoliciesFromDb like
> final long dbLoadTime = System.currentTimeMillis() - startTimeMs;
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/common/RangerServicePoliciesCache.java b1447829b
>
>
> Diff: https://reviews.apache.org/r/74115/diff/4/
>
>
> Testing
> -------
>
> Tested this change in the log files
>
>
> Thanks,
>
> Ramachandran Krishnan
>
>