You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Till Rohrmann (Jira)" <ji...@apache.org> on 2020/01/07 15:02:00 UTC

[jira] [Resolved] (FLINK-15501) Remove the wrong doc of ExecutionVertexSchedulingRequirements#getExecutionVertexId

     [ https://issues.apache.org/jira/browse/FLINK-15501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Till Rohrmann resolved FLINK-15501.
-----------------------------------
    Fix Version/s: 1.11.0
       Resolution: Done

Done via ef78962b780edc9a63cdaba2e742ac7656b6a28c

> Remove the wrong doc of ExecutionVertexSchedulingRequirements#getExecutionVertexId
> ----------------------------------------------------------------------------------
>
>                 Key: FLINK-15501
>                 URL: https://issues.apache.org/jira/browse/FLINK-15501
>             Project: Flink
>          Issue Type: Improvement
>          Components: Runtime / Coordination
>            Reporter: vinoyang
>            Assignee: vinoyang
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.11.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Currently, {{ExecutionVertexSchedulingRequirements#getExecutionVertexId}}'s doc is:
> {code:java}
> /**
>  * a {@link ExecutionVertex#MAX_DISTINCT_LOCATIONS_TO_CONSIDER} test.
>  *
>  * @return
>  */
> {code}
> It has a {{@return}} but missed relevant descriptions. However, when analysis of the call chain, it shows that it is called via general code(not only for testing purposes).
> So, IMO, we either correct the java doc or remove it directly.
> Based on the style in the same file, I suggest that we can remove it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)