You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/15 15:53:25 UTC

[GitHub] [airflow] kimyen opened a new pull request #18272: Allow Airflow UI to create worker pod via Clear > Run

kimyen opened a new pull request #18272:
URL: https://github.com/apache/airflow/pull/18272


   Problem:
   
   Clear and Run task instance via UI cause mushroom cloud error.
   
   Repro steps:
   - Using Helm 1.1.0 to deploy Airflow 1.10.15
   - From the UI, navigate to a DAG tree view
   - Select an existing task (small square on tree view) > Clear > Run
   
   Error:
   ```
   -------------------------------------------------------------------------------
   Node: airflow-webserver-67bf9669bc-x6wcc
   -------------------------------------------------------------------------------
   Traceback (most recent call last):
     File "/usr/local/lib/python3.7/site-packages/flask/app.py", line 2446, in wsgi_app
       response = self.full_dispatch_request()
     ...
     File "/usr/local/lib/python3.7/site-packages/airflow/www/views.py", line 1196, in run
       executor.start()
     File "/usr/local/lib/python3.7/site-packages/airflow/executors/kubernetes_executor.py", line 784, in start
       self.kube_client, self.worker_uuid
     File "/usr/local/lib/python3.7/site-packages/airflow/executors/kubernetes_executor.py", line 396, in __init__
       self.worker_configuration_pod = WorkerConfiguration(kube_config=self.kube_config).as_pod()
     File "/usr/local/lib/python3.7/site-packages/airflow/kubernetes/worker_configuration.py", line 437, in as_pod
       return PodGenerator(pod_template_file=self.kube_config.pod_template_file).gen_pod()
     File "/usr/local/lib/python3.7/site-packages/airflow/kubernetes/pod_generator.py", line 308, in gen_pod
       result.metadata.name = self.make_unique_pod_id(result.metadata.name)
   AttributeError: 'NoneType' object has no attribute 'name'
   ```
   
   How does this PR fixes the problem above:
   
   - From the stack trace above, this line here shows that the name is read from the kube_config.pod_template_file: https://github.com/apache/airflow/blob/db720743c5f5828fabed9dd88384c86a41e2f997/airflow/kubernetes/worker_configuration.py#L437 
   - In the Airflow Helm chart 1.1.0, only the scheduler has the pod_template_file mounted. So when this action was triggered, the webserver does not have the pod_template file mounted and couldn't fill in the values here. 
   - This PR patches the webserver K8s template to also mount the pod_template_file the same way the schedule does here: https://github.com/apache/airflow/blob/daa725b9f359c23a374a808ad53bbd7ecefce0d9/chart/templates/scheduler/scheduler-deployment.yaml#L141 so that when the code path is exercised, `name` is filled in from the value read in the pod template file.
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kimyen commented on a change in pull request #18272: Allow Airflow UI to create worker pod via Clear > Run

Posted by GitBox <gi...@apache.org>.
kimyen commented on a change in pull request #18272:
URL: https://github.com/apache/airflow/pull/18272#discussion_r719754802



##########
File path: chart/tests/test_webserver.py
##########
@@ -236,6 +236,38 @@ def test_logs_persistence_adds_volume_and_mount(self, log_persistence_values, ex
                 v["name"] for v in jmespath.search("spec.template.spec.containers[0].volumeMounts", docs[0])
             ]
 
+    @parameterized.expand(
+        [
+            ("1.10.10", False),
+            ("1.10.12", True),
+            ("2.1.0", True),
+        ]
+    )
+    def test_config_volumes_and_mounts(self, af_version, pod_template_file_expected):
+        # setup
+        docs = render_chart(
+            values={"airflowVersion": af_version},
+            show_only=["templates/webserver/webserver-deployment.yaml"],
+        )
+
+        # default config
+        assert {
+            "name": "config",
+            "mountPath": "/opt/airflow/airflow.cfg",
+        } in jmespath.search("spec.template.spec.containers[0].volumeMounts", docs[0])
+
+        # pod_template_file config
+        assert (
+            pod_template_file_expected
+            == (
+                {
+                    "name": "config",
+                    "mountPath": "/opt/airflow/pod_template_file.yaml",
+                }
+                in jmespath.search("spec.template.spec.containers[0].volumeMounts", docs[0])
+            )
+        )

Review comment:
       Use CI suggested format:
   ```suggestion
           assert pod_template_file_expected == (
                   {
                       "name": "config",
                       "mountPath": "/opt/airflow/pod_template_file.yaml",
                   }
                   in jmespath.search("spec.template.spec.containers[0].volumeMounts", docs[0])
           )
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kimyen commented on pull request #18272: Allow Airflow UI to create worker pod via Clear > Run

Posted by GitBox <gi...@apache.org>.
kimyen commented on pull request #18272:
URL: https://github.com/apache/airflow/pull/18272#issuecomment-922119616


   @jedcunningham I would love your feedback on the test that I added. Other volumes depends on other values, so I limit the scope of my test on default and optional config volumes. 
   
   I don't have an option to add tags to this PR, but would like to mark it as `Ready for Review`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on a change in pull request #18272: Allow Airflow UI to create worker pod via Clear > Run

Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #18272:
URL: https://github.com/apache/airflow/pull/18272#discussion_r709361518



##########
File path: chart/templates/webserver/webserver-deployment.yaml
##########
@@ -129,6 +129,12 @@ spec:
           resources:
 {{ toYaml .Values.webserver.resources | indent 12 }}
           volumeMounts:
+{{- if semverCompare ">=1.10.12" .Values.airflowVersion }}

Review comment:
       Also @jedcunningham @kaxil  -> I am not sure what will be the policy about supporting 1.10 in the chart (See https://apache-airflow.slack.com/archives/CCV3FV9KL/p1631564642172400 for context of that change)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] jedcunningham commented on a change in pull request #18272: Allow Airflow UI to create worker pod via Clear > Run

Posted by GitBox <gi...@apache.org>.
jedcunningham commented on a change in pull request #18272:
URL: https://github.com/apache/airflow/pull/18272#discussion_r719805098



##########
File path: chart/tests/test_webserver.py
##########
@@ -236,6 +236,35 @@ def test_logs_persistence_adds_volume_and_mount(self, log_persistence_values, ex
                 v["name"] for v in jmespath.search("spec.template.spec.containers[0].volumeMounts", docs[0])
             ]
 
+    @parameterized.expand(
+        [
+            ("1.10.10", False),
+            ("1.10.12", True),
+            ("2.1.0", True),
+        ]
+    )
+    def test_config_volumes_and_mounts(self, af_version, pod_template_file_expected):
+        # setup
+        docs = render_chart(
+            values={"airflowVersion": af_version},
+            show_only=["templates/webserver/webserver-deployment.yaml"],
+        )
+
+        # default config
+        assert {
+            "name": "config",
+            "mountPath": "/opt/airflow/airflow.cfg",
+        } in jmespath.search("spec.template.spec.containers[0].volumeMounts", docs[0])
+
+        # pod_template_file config
+        assert pod_template_file_expected == (
+                {
+                    "name": "config",
+                    "mountPath": "/opt/airflow/pod_template_file.yaml",
+                }
+                in jmespath.search("spec.template.spec.containers[0].volumeMounts", docs[0])

Review comment:
       ```suggestion
               {
                   "name": "config",
                   "mountPath": "/opt/airflow/pod_template_file.yaml",
               }
               in jmespath.search("spec.template.spec.containers[0].volumeMounts", docs[0])
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on a change in pull request #18272: Allow Airflow UI to create worker pod via Clear > Run

Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #18272:
URL: https://github.com/apache/airflow/pull/18272#discussion_r709360428



##########
File path: chart/templates/webserver/webserver-deployment.yaml
##########
@@ -129,6 +129,12 @@ spec:
           resources:
 {{ toYaml .Values.webserver.resources | indent 12 }}
           volumeMounts:
+{{- if semverCompare ">=1.10.12" .Values.airflowVersion }}

Review comment:
       Should it be also <2.0.0 ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] jedcunningham merged pull request #18272: Allow Airflow UI to create worker pod via Clear > Run

Posted by GitBox <gi...@apache.org>.
jedcunningham merged pull request #18272:
URL: https://github.com/apache/airflow/pull/18272


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] boring-cyborg[bot] commented on pull request #18272: Allow Airflow UI to create worker pod via Clear > Run

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #18272:
URL: https://github.com/apache/airflow/pull/18272#issuecomment-951426143


   Awesome work, congrats on your first merged pull request!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #18272: Allow Airflow UI to create worker pod via Clear > Run

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #18272:
URL: https://github.com/apache/airflow/pull/18272#issuecomment-934293598


   REopened to rebuild @kimyen -> Next time you can simply rebase + "--force-push-with-lease" if something like that happens  (which might be because of various CI issues)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kimyen commented on pull request #18272: Allow Airflow UI to create worker pod via Clear > Run

Posted by GitBox <gi...@apache.org>.
kimyen commented on pull request #18272:
URL: https://github.com/apache/airflow/pull/18272#issuecomment-920335723


   One of the unit test failed:
   ```
   ==== Helm sqlite: 2 failures ====
   
   chart/tests/test_webserver.py::WebserverDeploymentTest::test_logs_persistence_adds_volume_and_mount_1: AssertionError: assert {'mountPath':...name': 'logs'} == {'mountPath':...'airflow.cfg'}
     Differing items:
     {'name': 'logs'} != {'name': 'config'}
     {'mountPath': '/opt/airflow/logs'} != {'mountPath': '/opt/airflow/airflow.cfg'}
     Right contains 2 more items:
     {'readOnly': True, 'subPath': 'airflow.cfg'}
     Use -v to get the full diff
   chart/tests/test_webserver.py::WebserverDeploymentTest::test_logs_persistence_adds_volume_and_mount_2: AssertionError: assert {'mountPath':...name': 'logs'} == {'mountPath':...'airflow.cfg'}
     Differing items:
     {'name': 'logs'} != {'name': 'config'}
     {'mountPath': '/opt/airflow/logs'} != {'mountPath': '/opt/airflow/airflow.cfg'}
     Right contains 2 more items:
     {'readOnly': True, 'subPath': 'airflow.cfg'}
     Use -v to get the full diff
   Error: Process completed with exit code 1.
   ```
   
   I want to challenge the value of this test. It doesn't seem to catch anything that would break the `webserver` deployment, but rather being picky about the order of the volume. 😞 
   
   I would expect to break a test that has a set of volumes that the webserver deployment should have, and with this PR, extend the test to add the new volume. I don't know enough to write such a test. What do you think about the proposal? Does such test already exist (if so, it didn't fail)? Can I get some pointers on how to write the test I propose?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] jedcunningham commented on pull request #18272: Allow Airflow UI to create worker pod via Clear > Run

Posted by GitBox <gi...@apache.org>.
jedcunningham commented on pull request #18272:
URL: https://github.com/apache/airflow/pull/18272#issuecomment-951426692


   @kimyen, congrats on your first commit πŸŽ‰! (sorry about the delay in getting this merged)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] jedcunningham commented on a change in pull request #18272: Allow Airflow UI to create worker pod via Clear > Run

Posted by GitBox <gi...@apache.org>.
jedcunningham commented on a change in pull request #18272:
URL: https://github.com/apache/airflow/pull/18272#discussion_r711398202



##########
File path: chart/tests/test_webserver.py
##########
@@ -236,6 +236,36 @@ def test_logs_persistence_adds_volume_and_mount(self, log_persistence_values, ex
                 v["name"] for v in jmespath.search("spec.template.spec.containers[0].volumeMounts", docs[0])
             ]
 
+    @parameterized.expand(
+        [
+            ("1.10.10", False),
+            ("1.10.12", True),
+            ("2.1.0", True),
+        ]
+    )
+    def test_config_volumes_and_mounts(self, af_version, pod_template_file_expected):
+        # setup
+        docs = render_chart(
+            values={"airflowVersion": af_version},
+            show_only=["templates/webserver/webserver-deployment.yaml"],
+        )
+
+        # default config
+        assert {
+            "name": "config",
+            "mountPath": "/opt/airflow/airflow.cfg",
+        } in jmespath.search("spec.template.spec.containers[0].volumeMounts", docs[0])
+
+        # pod_template_file config
+        assert (
+            pod_template_file_expected
+            == {
+                "name": "config",
+                "mountPath": "/opt/airflow/pod_template_file.yaml",
+            }
+            in jmespath.search("spec.template.spec.containers[0].volumeMounts", docs[0])

Review comment:
       ```suggestion
               == (
                   {
                       "name": "config",
                       "mountPath": "/opt/airflow/pod_template_file.yaml",
                   }
                   in jmespath.search("spec.template.spec.containers[0].volumeMounts", docs[0])
               )
   ```
   
   Not sure on the formatting here, but I believe we need parens.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] jedcunningham commented on pull request #18272: Allow Airflow UI to create worker pod via Clear > Run

Posted by GitBox <gi...@apache.org>.
jedcunningham commented on pull request #18272:
URL: https://github.com/apache/airflow/pull/18272#issuecomment-931745016


   @kimyen I'd also suggest that you [set up the pre-commit hooks](https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks), they help catch these static check issues locally πŸ‘.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] jedcunningham commented on pull request #18272: Allow Airflow UI to create worker pod via Clear > Run

Posted by GitBox <gi...@apache.org>.
jedcunningham commented on pull request #18272:
URL: https://github.com/apache/airflow/pull/18272#issuecomment-922005341


   @kimyen, that test is overly fragile as written. Easy fix though: #18332
   
   I don't think that test exists yet, and I agree it would be a valuable test. The broken test is a reasonable example to follow, just check the default `volumes` and `volumeMounts` instead. More than 1 way to approach this, but one would be to use parameterized.expand like so:
   ```
   @parameterized.expand([
       ("1.10.10", False),
       ("1.10.12", True),
       ("2.1.0", True),
   ])
   def test_default_volumes_and_mounts(self, af_version, pod_template_file_expected):
       # assert "always there" volumes/mounts
       if pod_template_file_expected:
           # assert pod_template_file mount   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] github-actions[bot] commented on pull request #18272: Allow Airflow UI to create worker pod via Clear > Run

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18272:
URL: https://github.com/apache/airflow/pull/18272#issuecomment-951357378


   The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] jedcunningham closed pull request #18272: Allow Airflow UI to create worker pod via Clear > Run

Posted by GitBox <gi...@apache.org>.
jedcunningham closed pull request #18272:
URL: https://github.com/apache/airflow/pull/18272


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] jedcunningham commented on pull request #18272: Allow Airflow UI to create worker pod via Clear > Run

Posted by GitBox <gi...@apache.org>.
jedcunningham commented on pull request #18272:
URL: https://github.com/apache/airflow/pull/18272#issuecomment-951357919


   (Closing/reopening to rerun CI as it's been a little while)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil commented on a change in pull request #18272: Allow Airflow UI to create worker pod via Clear > Run

Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #18272:
URL: https://github.com/apache/airflow/pull/18272#discussion_r709557908



##########
File path: chart/templates/webserver/webserver-deployment.yaml
##########
@@ -129,6 +129,12 @@ spec:
           resources:
 {{ toYaml .Values.webserver.resources | indent 12 }}
           volumeMounts:
+{{- if semverCompare ">=1.10.12" .Values.airflowVersion }}

Review comment:
       Currently, there is not much maintenance effort for supporting 1.x so I think we should support it for now




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kimyen commented on pull request #18272: Allow Airflow UI to create worker pod via Clear > Run

Posted by GitBox <gi...@apache.org>.
kimyen commented on pull request #18272:
URL: https://github.com/apache/airflow/pull/18272#issuecomment-939352552


   @jedcunningham would you mind reviewing this again? Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] jedcunningham commented on a change in pull request #18272: Allow Airflow UI to create worker pod via Clear > Run

Posted by GitBox <gi...@apache.org>.
jedcunningham commented on a change in pull request #18272:
URL: https://github.com/apache/airflow/pull/18272#discussion_r709442284



##########
File path: chart/templates/webserver/webserver-deployment.yaml
##########
@@ -129,6 +129,12 @@ spec:
           resources:
 {{ toYaml .Values.webserver.resources | indent 12 }}
           volumeMounts:
+{{- if semverCompare ">=1.10.12" .Values.airflowVersion }}

Review comment:
       It probably should be present for 2.0.0+ too, as it is config, even if it isn't being used.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk closed pull request #18272: Allow Airflow UI to create worker pod via Clear > Run

Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #18272:
URL: https://github.com/apache/airflow/pull/18272


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kimyen commented on pull request #18272: Allow Airflow UI to create worker pod via Clear > Run

Posted by GitBox <gi...@apache.org>.
kimyen commented on pull request #18272:
URL: https://github.com/apache/airflow/pull/18272#issuecomment-939232862


   Thanks @potiuk !
   
   The docker image build still failed. But the error is not related to this change:
   ```
     ERROR: Cannot install apache-airflow[devel-ci]==2.2.0.dev0 because these package versions have conflicting dependencies.
   ```
   
   It looks like the fix is in package dependencies for 2.2.0.dev0. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] boring-cyborg[bot] commented on pull request #18272: Allow Airflow UI to create worker pod via Clear > Run

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #18272:
URL: https://github.com/apache/airflow/pull/18272#issuecomment-920144534


   Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
   Here are some useful points:
   - Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
   - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
   - Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
   - Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
   - Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
   - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
   Apache Airflow is a community-driven project and together we are making it better πŸš€.
   In case of doubts contact the developers at:
   Mailing List: dev@airflow.apache.org
   Slack: https://s.apache.org/airflow-slack
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #18272: Allow Airflow UI to create worker pod via Clear > Run

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #18272:
URL: https://github.com/apache/airflow/pull/18272#issuecomment-939310410


   Looks like all tests passed now!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kimyen commented on pull request #18272: Allow Airflow UI to create worker pod via Clear > Run

Posted by GitBox <gi...@apache.org>.
kimyen commented on pull request #18272:
URL: https://github.com/apache/airflow/pull/18272#issuecomment-933569828


   <img width="1400" alt="Screen Shot 2021-10-04 at 7 58 09 AM" src="https://user-images.githubusercontent.com/4404426/135874651-6b8ec491-649b-48d1-af64-86a35fce4868.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org