[jira] [Commented] (HADOOP-7328) Give more information about a missing Serializer class

["jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-7328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13047991#comment-13047991 ] 

jiraposter@reviews.apache.org commented on HADOOP-7328:
-------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/884/
-----------------------------------------------------------

Review request for hadoop-common and Todd Lipcon.


Summary
-------

Since getSerialization() can possibly return a null, it is only right that getSerializer() and getDeserializer() usage functions do the same, instead of throwing up NPEs.

Related issue to which this improvement is required: https://issues.apache.org/jira/browse/MAPREDUCE-2584


This addresses bug HADOOP-7328.
    http://issues.apache.org/jira/browse/HADOOP-7328


Diffs
-----

  src/java/org/apache/hadoop/io/serializer/SerializationFactory.java dee314a 

Diff: https://reviews.apache.org/r/884/diff


Testing
-------

Existing SequenceFile serialization factory tests pass. The change is merely to make the functions return null instead of throwing an NPE within.


Thanks,

Harsh



> Give more information about a missing Serializer class
> ------------------------------------------------------
>
>                 Key: HADOOP-7328
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7328
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: io
>    Affects Versions: 0.20.2
>            Reporter: Harsh J
>            Assignee: Harsh J
>              Labels: io, serialization
>             Fix For: 0.23.0
>
>         Attachments: HADOOP-7328.r1.diff
>
>
> When you have a key/value class that's non Writable and you forget to attach io.serializers for the same, an NPE is thrown by the tasks with no information on why or what's missing and what led to it. I think a better exception can be thrown by SerializationFactory instead of an NPE when a class is not found accepted by any of the loaded ones.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira