[GitHub] [royale-asjs] Laturine opened a new issue #1124: IndexChangedEvent not sending correct event parameters in mx.containers.ViewStack

[GitBox <gi...@apache.org>]

Laturine opened a new issue #1124:
URL: https://github.com/apache/royale-asjs/issues/1124


   https://github.com/apache/royale-asjs/blob/9ee7abbaa576d9985f9314a1369e41faaa91a464/frameworks/projects/MXRoyale/src/main/royale/mx/containers/ViewStack.as#L1286
   
   This method in ViewStack is dispatching an mx.events.IndexChangedEvent with type of "change".
   In the ElementWrapper.prototype.dispatchEvent method it looks like the event with type "change" or any events in org.apache.royale.events.ElementEvents.elementEvents get created as org.apache.royale.events.utils.EventUtils.createEvent(eventType) which is probably why there is missing event properties for the IndexChangedEvent.
   
   I propose to change (no pun intended) the dispatched event in ViewStack to "childIndexChange". It appears from the flex original usage this should only be dispatched when "a component's index among a container's children has changed" where the "change" event is dispatched "an index has changed, such as when and Accordian control cchanges the displayed panel or a ViewStack changes views"
    
   The difference isn't exactly clear to me, it seems "change" is just more general.
   
   If this is satisfactory I will issue a PR. 
   
   Thank you for your time.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@royale.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org