[jira] [Work logged] (GOBBLIN-944) Provide the flexibility of deriving platform field in a different way for subclasses of BaseDatasetDescriptor

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GOBBLIN-944?focusedWorklogId=337884&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-337884 ]

ASF GitHub Bot logged work on GOBBLIN-944:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/Nov/19 00:11
            Start Date: 04/Nov/19 00:11
    Worklog Time Spent: 10m 
      Work Description: enjoyear commented on pull request #2794: [GOBBLIN-944] Provide the flexibility of deriving platform field in a different way for subclasses of BaseDatasetDescriptor
URL: https://github.com/apache/incubator-gobblin/pull/2794
 
 
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [X] My PR addresses the following [Gobblin JIRA]
       - https://issues.apache.org/jira/browse/GOBBLIN-944
   
   
   ### Description
   - [X] Here are some details about my PR, including screenshots (if applicable):
   Move two lines of code to a protected method for subclasses to override.
   
   ### Tests
   - [X] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   
   ### Commits
   - [X] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 337884)
    Remaining Estimate: 0h
            Time Spent: 10m

> Provide the flexibility of deriving platform field in a different way for subclasses of BaseDatasetDescriptor
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: GOBBLIN-944
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-944
>             Project: Apache Gobblin
>          Issue Type: New Feature
>            Reporter: Chen Guo
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Current BaseDatasetDescriptor always gets the platform from the configuration object, but there could be use cases where the platform is derived in a different way. We need to change the implementation of BaseDatasetDescriptor constructor such that derived classes have the flexibility to change this default behaviour.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)