You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/07/22 03:20:33 UTC
[GitHub] [incubator-kyuubi] hddong opened a new pull request #858: [KYUUBI#844]Use NodePort to expose kyuubi port on k8s
hddong opened a new pull request #858:
URL: https://github.com/apache/incubator-kyuubi/pull/858
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
`kubectl port-forward` usually use to test, use `NodePort` to visit kyuubi service in pod.
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [X] [Run test](https://kyuubi.readthedocs.io/en/latest/tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #858: [KYUUBI#844]Use NodePort to expose kyuubi port on k8s
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #858:
URL: https://github.com/apache/incubator-kyuubi/pull/858#issuecomment-884636021
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/858?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#858](https://codecov.io/gh/apache/incubator-kyuubi/pull/858?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (74cec93) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/bf0042cbff2c2b70622d5be20784b00fdf8480e0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bf0042c) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/858?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #858 +/- ##
=========================================
Coverage 78.60% 78.60%
Complexity 10 10
=========================================
Files 135 135
Lines 5123 5123
Branches 642 642
=========================================
Hits 4027 4027
Misses 745 745
Partials 351 351
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/858?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/858?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bf0042c...74cec93](https://codecov.io/gh/apache/incubator-kyuubi/pull/858?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #858: [KYUUBI #844] Exposing Kyuubi as a NodePort service
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #858:
URL: https://github.com/apache/incubator-kyuubi/pull/858#issuecomment-884636021
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/858?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#858](https://codecov.io/gh/apache/incubator-kyuubi/pull/858?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (72d51d6) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/bf0042cbff2c2b70622d5be20784b00fdf8480e0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bf0042c) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 72d51d6 differs from pull request most recent head d149226. Consider uploading reports for the commit d149226 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/858?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #858 +/- ##
=========================================
Coverage 78.60% 78.60%
Complexity 10 10
=========================================
Files 135 135
Lines 5123 5123
Branches 642 642
=========================================
Hits 4027 4027
Misses 745 745
Partials 351 351
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/858?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/858?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bf0042c...d149226](https://codecov.io/gh/apache/incubator-kyuubi/pull/858?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #858: [KYUUBI #844] Exposing Kyuubi as a NodePort service
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #858:
URL: https://github.com/apache/incubator-kyuubi/pull/858#discussion_r674611821
##########
File path: docker/kyuubi-service.yaml
##########
@@ -0,0 +1,41 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Usage:
+# Start:
+# kubectl apply -f https://raw.githubusercontent.com/apache/incubator-kyuubi/master/docker/kyuubi-service.yaml
+# Connect:
+# ${SPARK_HOME}/bin/beeline -u 'jdbc:hive2://${hostname}:30009'
Review comment:
how about `${hostname}` => `${any_hostname_of_k8s_nodes}`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #858: [KYUUBI #844] Exposing Kyuubi as a NodePort service
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #858:
URL: https://github.com/apache/incubator-kyuubi/pull/858#issuecomment-884636021
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/858?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#858](https://codecov.io/gh/apache/incubator-kyuubi/pull/858?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9172798) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/bf0042cbff2c2b70622d5be20784b00fdf8480e0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bf0042c) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/858?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #858 +/- ##
=========================================
Coverage 78.60% 78.60%
Complexity 10 10
=========================================
Files 135 135
Lines 5123 5123
Branches 642 642
=========================================
Hits 4027 4027
Misses 745 745
Partials 351 351
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/858?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/858?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bf0042c...9172798](https://codecov.io/gh/apache/incubator-kyuubi/pull/858?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #858: [KYUUBI #844] Exposing Kyuubi as a NodePort service
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #858:
URL: https://github.com/apache/incubator-kyuubi/pull/858#discussion_r674525076
##########
File path: docker/kyuubi-service.yaml
##########
@@ -0,0 +1,41 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Usage:
+# Start:
+# kubectl apply -f https://raw.githubusercontent.com/apache/incubator-kyuubi/master/docker/kyuubi-service.yaml
+# Connect:
+# ${SPARK_HOME}/bin/beeline -u 'jdbc:hive2://${hostname}:30009'
+
+apiVersion: v1
+kind: Service
+metadata:
+ name: kyuubi-example-service
+spec:
+ ports:
+ # The default port limit is 30000-32767
+ # to change:
+ # vim kube-apiserver.yaml (usually under path: /etc/kubernetes/manifests/)
+ # add or change line 'service-node-port-range=1-32767' under kube-apiserver
+ - nodePort: 30009
+ # same of containerPort in pod yaml
+ port: 10009
+ protocol: TCP
+ type: NodePort
+ selector:
+ # some of pod label
Review comment:
what's the meaning of `some of pod label`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] hddong commented on a change in pull request #858: [KYUUBI #844] Exposing Kyuubi as a NodePort service
Posted by GitBox <gi...@apache.org>.
hddong commented on a change in pull request #858:
URL: https://github.com/apache/incubator-kyuubi/pull/858#discussion_r674615392
##########
File path: docker/kyuubi-service.yaml
##########
@@ -0,0 +1,41 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Usage:
+# Start:
+# kubectl apply -f https://raw.githubusercontent.com/apache/incubator-kyuubi/master/docker/kyuubi-service.yaml
+# Connect:
+# ${SPARK_HOME}/bin/beeline -u 'jdbc:hive2://${hostname}:30009'
Review comment:
sure, `any_hostname_of_k8s_nodes` is better here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #858: [KYUUBI #844] Exposing Kyuubi as a NodePort service
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #858:
URL: https://github.com/apache/incubator-kyuubi/pull/858#discussion_r674609617
##########
File path: docker/kyuubi-service.yaml
##########
@@ -0,0 +1,41 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Usage:
+# Start:
+# kubectl apply -f https://raw.githubusercontent.com/apache/incubator-kyuubi/master/docker/kyuubi-service.yaml
+# Connect:
+# ${SPARK_HOME}/bin/beeline -u 'jdbc:hive2://${hostname}:30009'
Review comment:
Expose a node port means that expose the port to all K8s nodes. Suppose the K8s deployed in 3 hosts `k8s-1`, `k8s-2`, `k8s-3`, any of `jdbc:hive2://k8s-1:30009`, `jdbc:hive2://k8s-2:30009`, `jdbc:hive2://k8s-3:30009` works.
The static `kyuubi-test` is misleading to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] hddong commented on a change in pull request #858: [KYUUBI #844] Exposing Kyuubi as a NodePort service
Posted by GitBox <gi...@apache.org>.
hddong commented on a change in pull request #858:
URL: https://github.com/apache/incubator-kyuubi/pull/858#discussion_r674641676
##########
File path: docker/kyuubi-pod.yaml
##########
@@ -17,20 +17,25 @@
# Usage:
# Start:
-# kubectl apply -f https://raw.githubusercontent.com/apache/incubator-kyuubi/master/docker/example.yaml
-# Connect:
+# kubectl apply -f https://raw.githubusercontent.com/apache/incubator-kyuubi/master/docker/kyuubi-pod.yaml
+# Expose port:
+# 1. for tmp test
# kubectl port-forward kyuubi-example --address localhost 10009:10009
-# Or
-# kubectl exec -it kyuubi-example -- /bin/bash
+# Connect:
+# kubectl exec -it kyuubi-example -- /bin/bash
#
-# ${SPARK_HOME}/bin/beeline -u 'jdbc:hive2://localhost:10009'
+# ${SPARK_HOME}/bin/beeline -u 'jdbc:hive2://localhost:10009'
+# 2. use NodePort
Review comment:
Had modify.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on a change in pull request #858: [KYUUBI#844]Use NodePort to expose kyuubi port on k8s
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #858:
URL: https://github.com/apache/incubator-kyuubi/pull/858#discussion_r674477371
##########
File path: docker/kyuubi-pod.yaml
##########
@@ -17,10 +17,13 @@
# Usage:
# Start:
-# kubectl apply -f https://raw.githubusercontent.com/apache/incubator-kyuubi/master/docker/example.yaml
+# kubectl apply -f https://raw.githubusercontent.com/apache/incubator-kyuubi/master/docker/kyuubi-pod.yaml
+# Expose port:
+# 1. for tmp test
+# kubectl port-forward kyuubi-example --address localhost 10009:10009
+# 2. use NodePort
+# see usage of kyuubi-service.yaml
Review comment:
It seems 24-25 line should move to line 30 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #858: [KYUUBI #844] Exposing Kyuubi as a NodePort service
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #858:
URL: https://github.com/apache/incubator-kyuubi/pull/858#issuecomment-884636021
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/858?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#858](https://codecov.io/gh/apache/incubator-kyuubi/pull/858?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d149226) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/bf0042cbff2c2b70622d5be20784b00fdf8480e0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bf0042c) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/858?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #858 +/- ##
=========================================
Coverage 78.60% 78.60%
Complexity 10 10
=========================================
Files 135 135
Lines 5123 5123
Branches 642 642
=========================================
Hits 4027 4027
Misses 745 745
Partials 351 351
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/858?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/858?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bf0042c...d149226](https://codecov.io/gh/apache/incubator-kyuubi/pull/858?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #858: [KYUUBI #844] Exposing Kyuubi as a NodePort service
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #858:
URL: https://github.com/apache/incubator-kyuubi/pull/858#issuecomment-884636021
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/858?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#858](https://codecov.io/gh/apache/incubator-kyuubi/pull/858?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (74cec93) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/bf0042cbff2c2b70622d5be20784b00fdf8480e0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bf0042c) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 74cec93 differs from pull request most recent head a169332. Consider uploading reports for the commit a169332 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/858?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #858 +/- ##
=========================================
Coverage 78.60% 78.60%
Complexity 10 10
=========================================
Files 135 135
Lines 5123 5123
Branches 642 642
=========================================
Hits 4027 4027
Misses 745 745
Partials 351 351
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/858?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/858?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bf0042c...a169332](https://codecov.io/gh/apache/incubator-kyuubi/pull/858?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #858: [KYUUBI #844] Exposing Kyuubi as a NodePort service
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #858:
URL: https://github.com/apache/incubator-kyuubi/pull/858#discussion_r674524710
##########
File path: docker/kyuubi-pod.yaml
##########
@@ -17,20 +17,25 @@
# Usage:
# Start:
-# kubectl apply -f https://raw.githubusercontent.com/apache/incubator-kyuubi/master/docker/example.yaml
-# Connect:
+# kubectl apply -f https://raw.githubusercontent.com/apache/incubator-kyuubi/master/docker/kyuubi-pod.yaml
Review comment:
why is the name changed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #858: [KYUUBI #844] Exposing Kyuubi as a NodePort service
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #858:
URL: https://github.com/apache/incubator-kyuubi/pull/858#discussion_r674569394
##########
File path: docker/kyuubi-service.yaml
##########
@@ -0,0 +1,41 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Usage:
+# Start:
+# kubectl apply -f https://raw.githubusercontent.com/apache/incubator-kyuubi/master/docker/kyuubi-service.yaml
+# Connect:
+# ${SPARK_HOME}/bin/beeline -u 'jdbc:hive2://${hostname}:30009'
Review comment:
Can it be static? something like kyuubi.apache.org:30009
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #858: [KYUUBI #844] Exposing Kyuubi as a NodePort service
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #858:
URL: https://github.com/apache/incubator-kyuubi/pull/858#discussion_r674621818
##########
File path: docker/kyuubi-pod.yaml
##########
@@ -17,20 +17,25 @@
# Usage:
# Start:
-# kubectl apply -f https://raw.githubusercontent.com/apache/incubator-kyuubi/master/docker/example.yaml
-# Connect:
+# kubectl apply -f https://raw.githubusercontent.com/apache/incubator-kyuubi/master/docker/kyuubi-pod.yaml
+# Expose port:
+# 1. for tmp test
# kubectl port-forward kyuubi-example --address localhost 10009:10009
-# Or
-# kubectl exec -it kyuubi-example -- /bin/bash
+# Connect:
+# kubectl exec -it kyuubi-example -- /bin/bash
#
-# ${SPARK_HOME}/bin/beeline -u 'jdbc:hive2://localhost:10009'
+# ${SPARK_HOME}/bin/beeline -u 'jdbc:hive2://localhost:10009'
+# 2. use NodePort
Review comment:
Expose the Pod as a service with NodePort
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn closed pull request #858: [KYUUBI #844] Exposing Kyuubi as a NodePort service
Posted by GitBox <gi...@apache.org>.
yaooqinn closed pull request #858:
URL: https://github.com/apache/incubator-kyuubi/pull/858
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] hddong commented on a change in pull request #858: [KYUUBI #844] Exposing Kyuubi as a NodePort service
Posted by GitBox <gi...@apache.org>.
hddong commented on a change in pull request #858:
URL: https://github.com/apache/incubator-kyuubi/pull/858#discussion_r674524598
##########
File path: docker/kyuubi-pod.yaml
##########
@@ -17,10 +17,13 @@
# Usage:
# Start:
-# kubectl apply -f https://raw.githubusercontent.com/apache/incubator-kyuubi/master/docker/example.yaml
+# kubectl apply -f https://raw.githubusercontent.com/apache/incubator-kyuubi/master/docker/kyuubi-pod.yaml
+# Expose port:
+# 1. for tmp test
+# kubectl port-forward kyuubi-example --address localhost 10009:10009
+# 2. use NodePort
+# see usage of kyuubi-service.yaml
Review comment:
Thanks for your review, it's seems better to put it there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] hddong commented on a change in pull request #858: [KYUUBI #844] Exposing Kyuubi as a NodePort service
Posted by GitBox <gi...@apache.org>.
hddong commented on a change in pull request #858:
URL: https://github.com/apache/incubator-kyuubi/pull/858#discussion_r674568461
##########
File path: docker/kyuubi-service.yaml
##########
@@ -0,0 +1,41 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Usage:
+# Start:
+# kubectl apply -f https://raw.githubusercontent.com/apache/incubator-kyuubi/master/docker/kyuubi-service.yaml
+# Connect:
+# ${SPARK_HOME}/bin/beeline -u 'jdbc:hive2://${hostname}:30009'
Review comment:
ip/hostname of any k8s host.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #858: [KYUUBI #844] Exposing Kyuubi as a NodePort service
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #858:
URL: https://github.com/apache/incubator-kyuubi/pull/858#discussion_r674562785
##########
File path: docker/kyuubi-service.yaml
##########
@@ -0,0 +1,41 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Usage:
+# Start:
+# kubectl apply -f https://raw.githubusercontent.com/apache/incubator-kyuubi/master/docker/kyuubi-service.yaml
+# Connect:
+# ${SPARK_HOME}/bin/beeline -u 'jdbc:hive2://${hostname}:30009'
Review comment:
What would the `hostname` be?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] hddong commented on a change in pull request #858: [KYUUBI #844] Exposing Kyuubi as a NodePort service
Posted by GitBox <gi...@apache.org>.
hddong commented on a change in pull request #858:
URL: https://github.com/apache/incubator-kyuubi/pull/858#discussion_r674599851
##########
File path: docker/kyuubi-service.yaml
##########
@@ -0,0 +1,41 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Usage:
+# Start:
+# kubectl apply -f https://raw.githubusercontent.com/apache/incubator-kyuubi/master/docker/kyuubi-service.yaml
+# Connect:
+# ${SPARK_HOME}/bin/beeline -u 'jdbc:hive2://${hostname}:30009'
Review comment:
Agree, but i think it can use directly.
We can do as usage:
1. create pod
```
[user@kyuubi-test kyuubi]# kubectl apply -f https://raw.githubusercontent.com/apache/incubator-kyuubi/master/docker/kyuubi-pod.yaml
```
2. create NodePort
```
[user@kyuubi-test kyuubi]# kubectl apply -f https://raw.githubusercontent.com/apache/incubator-kyuubi/master/docker/kyuubi-servie.yaml`
```
3. connect to kyuubi on any host that can connect to host `kyuubi-test`
```
[user@any spark]# bin/beeline -u 'jdbc:hive2://kyuubi-test:30009'
```
It is also appropriate to make these two files suffixed with template or example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #858: [KYUUBI #844] Exposing Kyuubi as a NodePort service
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #858:
URL: https://github.com/apache/incubator-kyuubi/pull/858#discussion_r674602812
##########
File path: docker/kyuubi-service.yaml
##########
@@ -0,0 +1,41 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Usage:
+# Start:
+# kubectl apply -f https://raw.githubusercontent.com/apache/incubator-kyuubi/master/docker/kyuubi-service.yaml
+# Connect:
+# ${SPARK_HOME}/bin/beeline -u 'jdbc:hive2://${hostname}:30009'
Review comment:
Do you mean the `kyuubi-test` here is static for the service, or even the pod is evicted or crashed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #858: [KYUUBI #844] Exposing Kyuubi as a NodePort service
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #858:
URL: https://github.com/apache/incubator-kyuubi/pull/858#issuecomment-884636021
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/858?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#858](https://codecov.io/gh/apache/incubator-kyuubi/pull/858?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a169332) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/bf0042cbff2c2b70622d5be20784b00fdf8480e0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bf0042c) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head a169332 differs from pull request most recent head 9172798. Consider uploading reports for the commit 9172798 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/858?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #858 +/- ##
=========================================
Coverage 78.60% 78.60%
Complexity 10 10
=========================================
Files 135 135
Lines 5123 5123
Branches 642 642
=========================================
Hits 4027 4027
Misses 745 745
Partials 351 351
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/858?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/858?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bf0042c...9172798](https://codecov.io/gh/apache/incubator-kyuubi/pull/858?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] hddong commented on a change in pull request #858: [KYUUBI #844] Exposing Kyuubi as a NodePort service
Posted by GitBox <gi...@apache.org>.
hddong commented on a change in pull request #858:
URL: https://github.com/apache/incubator-kyuubi/pull/858#discussion_r674582446
##########
File path: docker/kyuubi-service.yaml
##########
@@ -0,0 +1,41 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Usage:
+# Start:
+# kubectl apply -f https://raw.githubusercontent.com/apache/incubator-kyuubi/master/docker/kyuubi-service.yaml
+# Connect:
+# ${SPARK_HOME}/bin/beeline -u 'jdbc:hive2://${hostname}:30009'
Review comment:
It's host that your k8s deployed(any host of k8s cluster), not pod or service. So, the name is related to the user's own definition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #858: [KYUUBI #844] Exposing Kyuubi as a NodePort service
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #858:
URL: https://github.com/apache/incubator-kyuubi/pull/858#issuecomment-884636021
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/858?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#858](https://codecov.io/gh/apache/incubator-kyuubi/pull/858?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a169332) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/bf0042cbff2c2b70622d5be20784b00fdf8480e0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bf0042c) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/858?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #858 +/- ##
=========================================
Coverage 78.60% 78.60%
Complexity 10 10
=========================================
Files 135 135
Lines 5123 5123
Branches 642 642
=========================================
Hits 4027 4027
Misses 745 745
Partials 351 351
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/858?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/858?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bf0042c...a169332](https://codecov.io/gh/apache/incubator-kyuubi/pull/858?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #858: [KYUUBI #844] Exposing Kyuubi as a NodePort service
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #858:
URL: https://github.com/apache/incubator-kyuubi/pull/858#issuecomment-884636021
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/858?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#858](https://codecov.io/gh/apache/incubator-kyuubi/pull/858?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (72d51d6) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/bf0042cbff2c2b70622d5be20784b00fdf8480e0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bf0042c) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/858?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #858 +/- ##
=========================================
Coverage 78.60% 78.60%
Complexity 10 10
=========================================
Files 135 135
Lines 5123 5123
Branches 642 642
=========================================
Hits 4027 4027
Misses 745 745
Partials 351 351
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/858?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/858?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bf0042c...72d51d6](https://codecov.io/gh/apache/incubator-kyuubi/pull/858?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #858: [KYUUBI #844] Exposing Kyuubi as a NodePort service
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #858:
URL: https://github.com/apache/incubator-kyuubi/pull/858#discussion_r674583652
##########
File path: docker/kyuubi-service.yaml
##########
@@ -0,0 +1,41 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Usage:
+# Start:
+# kubectl apply -f https://raw.githubusercontent.com/apache/incubator-kyuubi/master/docker/kyuubi-service.yaml
+# Connect:
+# ${SPARK_HOME}/bin/beeline -u 'jdbc:hive2://${hostname}:30009'
Review comment:
if they are not able to be used directly, these yml files shall be suffixed with `template` or `example`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #858: [KYUUBI #844] Exposing Kyuubi as a NodePort service
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #858:
URL: https://github.com/apache/incubator-kyuubi/pull/858#issuecomment-884636021
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/858?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#858](https://codecov.io/gh/apache/incubator-kyuubi/pull/858?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9172798) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/bf0042cbff2c2b70622d5be20784b00fdf8480e0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bf0042c) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 9172798 differs from pull request most recent head 72d51d6. Consider uploading reports for the commit 72d51d6 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/858?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #858 +/- ##
=========================================
Coverage 78.60% 78.60%
Complexity 10 10
=========================================
Files 135 135
Lines 5123 5123
Branches 642 642
=========================================
Hits 4027 4027
Misses 745 745
Partials 351 351
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/858?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/858?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bf0042c...72d51d6](https://codecov.io/gh/apache/incubator-kyuubi/pull/858?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #858: [KYUUBI #844] Exposing Kyuubi as a NodePort service
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #858:
URL: https://github.com/apache/incubator-kyuubi/pull/858#discussion_r674620896
##########
File path: docker/kyuubi-pod.yaml
##########
@@ -17,20 +17,25 @@
# Usage:
# Start:
-# kubectl apply -f https://raw.githubusercontent.com/apache/incubator-kyuubi/master/docker/example.yaml
-# Connect:
+# kubectl apply -f https://raw.githubusercontent.com/apache/incubator-kyuubi/master/docker/kyuubi-pod.yaml
+# Expose port:
+# 1. for tmp test
Review comment:
`for tmp test`, please make this comment better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #858: [KYUUBI #844] Exposing Kyuubi as a NodePort service
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #858:
URL: https://github.com/apache/incubator-kyuubi/pull/858#issuecomment-884803507
thanks, merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] hddong commented on a change in pull request #858: [KYUUBI #844] Exposing Kyuubi as a NodePort service
Posted by GitBox <gi...@apache.org>.
hddong commented on a change in pull request #858:
URL: https://github.com/apache/incubator-kyuubi/pull/858#discussion_r674559689
##########
File path: docker/kyuubi-service.yaml
##########
@@ -0,0 +1,41 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Usage:
+# Start:
+# kubectl apply -f https://raw.githubusercontent.com/apache/incubator-kyuubi/master/docker/kyuubi-service.yaml
+# Connect:
+# ${SPARK_HOME}/bin/beeline -u 'jdbc:hive2://${hostname}:30009'
+
+apiVersion: v1
+kind: Service
+metadata:
+ name: kyuubi-example-service
+spec:
+ ports:
+ # The default port limit is 30000-32767
+ # to change:
+ # vim kube-apiserver.yaml (usually under path: /etc/kubernetes/manifests/)
+ # add or change line 'service-node-port-range=1-32767' under kube-apiserver
+ - nodePort: 30009
+ # same of containerPort in pod yaml
+ port: 10009
+ protocol: TCP
+ type: NodePort
+ selector:
+ # some of pod label
Review comment:
Spelling mistakes, modified.
##########
File path: docker/kyuubi-pod.yaml
##########
@@ -17,20 +17,25 @@
# Usage:
# Start:
-# kubectl apply -f https://raw.githubusercontent.com/apache/incubator-kyuubi/master/docker/example.yaml
-# Connect:
+# kubectl apply -f https://raw.githubusercontent.com/apache/incubator-kyuubi/master/docker/kyuubi-pod.yaml
Review comment:
This `yaml` is used to create pod, example contains other kinds of `yaml` like `service`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org