You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/12/23 03:10:40 UTC
[GitHub] [skywalking] hanahmily opened a new pull request #4105: Filter
endpoint with an id == 0
hanahmily opened a new pull request #4105: Filter endpoint with an id == 0
URL: https://github.com/apache/skywalking/pull/4105
Please answer these questions before submitting pull request
- Why submit this pull request?
- [x] Bug fix
- [ ] New feature provided
- [ ] Improve performance
- Related issues
___
### Bug fix
- Bug description.
When analyzing ALS from envoy, OAP generates some endpoint with id equals 0.
- How to fix?
Add a condition expression to filter and log them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] hanahmily merged pull request #4105: Filter endpoint
with an id == 0
Posted by GitBox <gi...@apache.org>.
hanahmily merged pull request #4105: Filter endpoint with an id == 0
URL: https://github.com/apache/skywalking/pull/4105
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io commented on issue #4105: Filter endpoint
with an id == 0
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4105: Filter endpoint with an id == 0
URL: https://github.com/apache/skywalking/pull/4105#issuecomment-568344829
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4105?src=pr&el=h1) Report
> Merging [#4105](https://codecov.io/gh/apache/skywalking/pull/4105?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/4f80c5b750468d858cb4f1c5e56e7938b123c8db?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/skywalking/pull/4105?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4105 +/- ##
==========================================
+ Coverage 27.28% 27.29% +0.01%
==========================================
Files 1140 1140
Lines 25024 25027 +3
Branches 3618 3619 +1
==========================================
+ Hits 6828 6832 +4
+ Misses 17591 17588 -3
- Partials 605 607 +2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4105?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4105/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
| [...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4105/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==) | `77.04% <0%> (-3.28%)` | :arrow_down: |
| [...apm/agent/core/remote/GRPCStreamServiceStatus.java](https://codecov.io/gh/apache/skywalking/pull/4105/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENTdHJlYW1TZXJ2aWNlU3RhdHVzLmphdmE=) | `54.16% <0%> (+25%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4105?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4105?src=pr&el=footer). Last update [4f80c5b...b972f0c](https://codecov.io/gh/apache/skywalking/pull/4105?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services