You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "pivotal-jbarrett (GitHub)" <gi...@apache.org> on 2018/12/07 06:26:39 UTC

[GitHub] [geode] pivotal-jbarrett opened pull request #2970: DO NOT MERGE: Improves put performance

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2970 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] pivotal-jbarrett commented on issue #2970: GEODE-6166: Improves put performance

Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.
When benchmarked with a simple rapid put operation the changes between develop and this PR resulted in about ~20% increase in puts/second. Comparing the profiles between develop and the PR shows a ~72% reduction in allocated transient objects.

[ Full content available at: https://github.com/apache/geode/pull/2970 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] pivotal-jbarrett commented on issue #2970: GEODE-6166: Improves put performance

Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.
@upthewaterspout it does change the on wire and all backwards compatibility tests pass.

Old clients send the serialized object and the server detects this because the part is and object. New clients send just a byte and the server detects this because the part is not an object. Saves ~63 bytes per put message.

[ Full content available at: https://github.com/apache/geode/pull/2970 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] pivotal-jbarrett closed pull request #2970: GEODE-6166: Improves put performance

Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.
[ pull request closed by pivotal-jbarrett ]

[ Full content available at: https://github.com/apache/geode/pull/2970 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] pivotal-jbarrett commented on issue #2970: GEODE-6166: Improves put performance

Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.
Opps, basic math error. Corrected numbers are:

When benchmarked with a simple rapid put operation the changes between develop and this PR resulted in about ~25% increase in puts/second. Comparing the profiles between develop and the PR shows a ~42% reduction in allocated transient objects.

Still great numbers!


[ Full content available at: https://github.com/apache/geode/pull/2970 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] mstolz1 commented on issue #2970: GEODE-6166: Improves put performance

Posted by "mstolz1 (GitHub)" <gi...@apache.org>.
I love hearing this kind of stuff! Great numbers indeed.

--
Mike Stolz
Principal Engineer - Gemfire Product Manager
Mobile: 631-835-4771

On Dec 8, 2018 10:23 AM, "Jacob Barrett" <no...@github.com> wrote:

> Opps, basic math error. Corrected numbers are:
>
> When benchmarked with a simple rapid put operation the changes between
> develop and this PR resulted in about ~25% increase in puts/second.
> Comparing the profiles between develop and the PR shows a ~42% reduction in
> allocated transient objects.
>
> Still great numbers!
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_geode_pull_2970-23issuecomment-2D445466841&d=DwMFaQ&c=lnl9vOaLMzsy2niBC8-h_K-7QJuNJEsFrzdndhuJ3Sw&r=us915XVL1kT8_Q-vmxAPAGcdk8eQkhBJKJGVCwFNFlA&m=eYRfbtKmkpiq7dk_RvVRQaRp1jCWvDi6XOqUX_Sl9Rk&s=mPLcta6apYMXflsgcoRmgJRP4T74CACe-kZvjnUbDAo&e=>,
> or mute the thread
> <https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ASblIKsBzsvAx1Oi7Q6iDFaTEIX-2DAjHeks5u29lngaJpZM4ZH3Rl&d=DwMFaQ&c=lnl9vOaLMzsy2niBC8-h_K-7QJuNJEsFrzdndhuJ3Sw&r=us915XVL1kT8_Q-vmxAPAGcdk8eQkhBJKJGVCwFNFlA&m=eYRfbtKmkpiq7dk_RvVRQaRp1jCWvDi6XOqUX_Sl9Rk&s=jODcI2ZsFr6_9n9wLOWu0GabHjRpoN8AwW0FUFCVRlY&e=>
> .
>


[ Full content available at: https://github.com/apache/geode/pull/2970 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] pivotal-jbarrett commented on issue #2970: GEODE-6166: Improves put performance

Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.
@upthewaterspout it does change the on wire and all backwards compatibility tests pass.

Old clients send the serialized object an the server detects this because the part is and object. New clients send just a byte and the server detects this because the part is not an object. Saves ~63 bytes per put message.

[ Full content available at: https://github.com/apache/geode/pull/2970 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org