You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2021/03/24 23:57:19 UTC
[Impala-ASF-CR] IMPALA-10606 (part 2): Clean up ordering of requirements.txt
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17229
Change subject: IMPALA-10606 (part 2): Clean up ordering of requirements.txt
......................................................................
IMPALA-10606 (part 2): Clean up ordering of requirements.txt
This is a followup to the original IMPALA-10606 that reorders
the requirements.txt alphabetically. No versions changed
as part of this.
Change-Id: I2f13ec8f8af80c4bac5da30d08a2ea4c56806d27
---
M infra/python/deps/requirements.txt
1 file changed, 23 insertions(+), 34 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/17229/1
--
To view, visit http://gerrit.cloudera.org:8080/17229
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2f13ec8f8af80c4bac5da30d08a2ea4c56806d27
Gerrit-Change-Number: 17229
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-10606 (part 2): Clean up ordering of requirements.txt
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17229 )
Change subject: IMPALA-10606 (part 2): Clean up ordering of requirements.txt
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8438/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17229
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f13ec8f8af80c4bac5da30d08a2ea4c56806d27
Gerrit-Change-Number: 17229
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Mar 2021 00:11:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10606 (part 2): Clean up ordering of requirements.txt
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17229 )
Change subject: IMPALA-10606 (part 2): Clean up ordering of requirements.txt
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8468/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17229
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f13ec8f8af80c4bac5da30d08a2ea4c56806d27
Gerrit-Change-Number: 17229
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Tue, 30 Mar 2021 21:40:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10606 (part 2): Clean up ordering of requirements.txt
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17229 )
Change subject: IMPALA-10606 (part 2): Clean up ordering of requirements.txt
......................................................................
Patch Set 3: Verified+1
GVO on whole stack succeeded.
--
To view, visit http://gerrit.cloudera.org:8080/17229
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f13ec8f8af80c4bac5da30d08a2ea4c56806d27
Gerrit-Change-Number: 17229
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Mar 2021 03:17:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10606 (part 2): Clean up ordering of requirements.txt
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/17229 )
Change subject: IMPALA-10606 (part 2): Clean up ordering of requirements.txt
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17229
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f13ec8f8af80c4bac5da30d08a2ea4c56806d27
Gerrit-Change-Number: 17229
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Tue, 30 Mar 2021 20:27:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10606 (part 2): Clean up ordering of requirements.txt
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17229 )
Change subject: IMPALA-10606 (part 2): Clean up ordering of requirements.txt
......................................................................
Patch Set 3: Code-Review+2
Only change is to the requests version that got updated, carrying +2
--
To view, visit http://gerrit.cloudera.org:8080/17229
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f13ec8f8af80c4bac5da30d08a2ea4c56806d27
Gerrit-Change-Number: 17229
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Tue, 30 Mar 2021 21:21:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10606 (part 2): Clean up ordering of requirements.txt
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Laszlo Gaal, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17229
to look at the new patch set (#3).
Change subject: IMPALA-10606 (part 2): Clean up ordering of requirements.txt
......................................................................
IMPALA-10606 (part 2): Clean up ordering of requirements.txt
This is a followup to the original IMPALA-10606 that reorders
the requirements.txt alphabetically. No versions changed
as part of this.
Change-Id: I2f13ec8f8af80c4bac5da30d08a2ea4c56806d27
---
M infra/python/deps/requirements.txt
1 file changed, 22 insertions(+), 34 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/17229/3
--
To view, visit http://gerrit.cloudera.org:8080/17229
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2f13ec8f8af80c4bac5da30d08a2ea4c56806d27
Gerrit-Change-Number: 17229
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
[Impala-ASF-CR] IMPALA-10606 (part 2): Clean up ordering of requirements.txt
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17229 )
Change subject: IMPALA-10606 (part 2): Clean up ordering of requirements.txt
......................................................................
IMPALA-10606 (part 2): Clean up ordering of requirements.txt
This is a followup to the original IMPALA-10606 that reorders
the requirements.txt alphabetically. No versions changed
as part of this.
Change-Id: I2f13ec8f8af80c4bac5da30d08a2ea4c56806d27
Reviewed-on: http://gerrit.cloudera.org:8080/17229
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Joe McDonnell <jo...@cloudera.com>
---
M infra/python/deps/requirements.txt
1 file changed, 22 insertions(+), 34 deletions(-)
Approvals:
Joe McDonnell: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/17229
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2f13ec8f8af80c4bac5da30d08a2ea4c56806d27
Gerrit-Change-Number: 17229
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>