You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by victorsosa <gi...@git.apache.org> on 2016/04/03 17:42:46 UTC
[GitHub] struts pull request: WW-4623 Multiple tiles.xml in web.xml
GitHub user victorsosa opened a pull request:
https://github.com/apache/struts/pull/94
WW-4623 Multiple tiles.xml in web.xml
WW-4623, WW-4624
Multiple tiles.xml in web.xml
Now it will load all the "**/tiles*.xml" below WEB-INF and also load individual files using the <context-param>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/victorsosa/struts ww-4623
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/struts/pull/94.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #94
----
commit da8b13a87ef0d6af54a8cabbc62d54fbca67f683
Author: victor sosa <vi...@users.noreply.github.com>
Date: 2016-03-03T18:16:11Z
Merge pull request #8 from apache/master
update pull
commit a5d716393999110b3701563479a96e83136a8b97
Author: victor sosa <vi...@users.noreply.github.com>
Date: 2016-03-03T18:41:11Z
Merge pull request #9 from victorsosa/easymock_update
Easymock update
commit 6bb1ec67ad539d4bf6850f8314ef521e06b8295e
Author: victor sosa <vi...@users.noreply.github.com>
Date: 2016-03-04T22:07:16Z
Merge pull request #10 from apache/master
pull update
commit 379b75292e6d084dc881e71f0a826c45934d9df8
Author: victor sosa <vi...@users.noreply.github.com>
Date: 2016-03-27T18:43:40Z
Merge pull request #11 from apache/master
update pull
commit f1d01253e4ed15ffb33afdbc62f1c92114d7fc27
Author: victorsosa <vi...@peopleware.do>
Date: 2016-04-03T15:38:15Z
Fix for WW-4623, WW-4624
Multiple tiles.xml in web.xml
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts pull request: WW-4623 Multiple tiles.xml in web.xml
Posted by victorsosa <gi...@git.apache.org>.
Github user victorsosa closed the pull request at:
https://github.com/apache/struts/pull/94
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts pull request: WW-4623 Multiple tiles.xml in web.xml
Posted by aleksandr-m <gi...@git.apache.org>.
Github user aleksandr-m commented on the pull request:
https://github.com/apache/struts/pull/94#issuecomment-205352470
Not working for 2.3.x and doubt it will work in 2.5. Take a look at `ResourceFinder`.
Please try to write a unit tests along with code changes, and if it is somehow complicated then at least test things manually.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts pull request: WW-4623 Multiple tiles.xml in web.xml
Posted by victorsosa <gi...@git.apache.org>.
Github user victorsosa commented on the pull request:
https://github.com/apache/struts/pull/94#issuecomment-206506526
Code implement by Lukas already
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts pull request: WW-4623 Multiple tiles.xml in web.xml
Posted by victorsosa <gi...@git.apache.org>.
Github user victorsosa commented on the pull request:
https://github.com/apache/struts/pull/94#issuecomment-205401807
Thanks for you help, Aleksandr; can you please post the stack trace of that? So I can look with more info into ResourceFinder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts pull request: WW-4623 Multiple tiles.xml in web.xml
Posted by aleksandr-m <gi...@git.apache.org>.
Github user aleksandr-m commented on the pull request:
https://github.com/apache/struts/pull/94#issuecomment-205429031
In 2.3.28 `StrutsWildcardServletTilesApplicationContext` produces something like that:
> org.apache.struts2.tiles.StrutsTilesListener - Starting Struts Tiles 2 integration ...
> org.apache.struts2.tiles.StrutsTilesInitializer - Initializing Tiles wildcard support ...
> org.apache.struts2.tiles.StrutsWildcardServletTilesApplicationContext:
>
> url= file:/path/to/webapps/app/img/
> url= file:/path/to/webapps/app/js/
> url= file:/path/to/webapps/app/META-INF/
> url= file:/path/to/webapps/app/index.jsp
> url= file:/path/to/webapps/app/WEB-INF/
> url= file:/path/to/webapps/app/css/
> url= file:/path/to/webapps/app/favicon.ico
And `ResourceFinder#getResourcesMap` won't look into sub-folders, meaning that `**/tiles` pattern is irrelevant in such case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org