You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by pe...@apache.org on 2011/07/05 14:41:08 UTC
svn commit: r1143027 - in /wicket/trunk/wicket-request/src:
main/java/org/apache/wicket/request/HttpHeaderCollection.java
test/java/org/apache/wicket/request/HttpHeaderCollectionTest.java
Author: pete
Date: Tue Jul 5 12:41:07 2011
New Revision: 1143027
URL: http://svn.apache.org/viewvc?rev=1143027&view=rev
Log:
WICKET-3845: allow empty header values since they are valid based on RFC2616
Modified:
wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/HttpHeaderCollection.java
wicket/trunk/wicket-request/src/test/java/org/apache/wicket/request/HttpHeaderCollectionTest.java
Modified: wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/HttpHeaderCollection.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/HttpHeaderCollection.java?rev=1143027&r1=1143026&r2=1143027&view=diff
==============================================================================
--- wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/HttpHeaderCollection.java (original)
+++ wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/HttpHeaderCollection.java Tue Jul 5 12:41:07 2011
@@ -99,7 +99,7 @@ public class HttpHeaderCollection
public void addHeader(String name, String value)
{
// be lenient and strip leading / trailing blanks
- value = Args.notEmpty(value, "value").trim();
+ value = Args.notNull(value, "value").trim();
internalAdd(name, value);
}
Modified: wicket/trunk/wicket-request/src/test/java/org/apache/wicket/request/HttpHeaderCollectionTest.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-request/src/test/java/org/apache/wicket/request/HttpHeaderCollectionTest.java?rev=1143027&r1=1143026&r2=1143027&view=diff
==============================================================================
--- wicket/trunk/wicket-request/src/test/java/org/apache/wicket/request/HttpHeaderCollectionTest.java (original)
+++ wicket/trunk/wicket-request/src/test/java/org/apache/wicket/request/HttpHeaderCollectionTest.java Tue Jul 5 12:41:07 2011
@@ -50,6 +50,15 @@ public class HttpHeaderCollectionTest
headers.removeHeader(" x-tesT ");
assertEquals(1, headers.getCount());
+
+ // empty header values are valid (RFC2616)
+ headers.setHeader("foobaz", "");
+ assertEquals("", headers.getHeader("foobaz"));
+
+ // empty header values are valid (RFC2616)
+ headers.setHeader("foobaz", " ");
+ assertEquals("", headers.getHeader("foobaz"));
+
}
@Test