You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by ac...@apache.org on 2017/03/01 15:49:50 UTC
[2/2] qpid-proton git commit: PROTON-1422: c makefiles including -luv
in too many places
PROTON-1422: c makefiles including -luv in too many places
cmake was including un-necessary private dependencies (including -luv but also
sasl & ssl related stuff) on every example etc. linked with liqpid-proton. Added
PRIVATE tags to target_link_libraries to prevent that.
Project: http://git-wip-us.apache.org/repos/asf/qpid-proton/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-proton/commit/7241e775
Tree: http://git-wip-us.apache.org/repos/asf/qpid-proton/tree/7241e775
Diff: http://git-wip-us.apache.org/repos/asf/qpid-proton/diff/7241e775
Branch: refs/heads/master
Commit: 7241e775f185f74f3e65c30dcf3a631aba6213ce
Parents: 9845408
Author: Alan Conway <ac...@redhat.com>
Authored: Wed Mar 1 10:16:11 2017 -0500
Committer: Alan Conway <ac...@redhat.com>
Committed: Wed Mar 1 10:31:30 2017 -0500
----------------------------------------------------------------------
proton-c/CMakeLists.txt | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/qpid-proton/blob/7241e775/proton-c/CMakeLists.txt
----------------------------------------------------------------------
diff --git a/proton-c/CMakeLists.txt b/proton-c/CMakeLists.txt
index 1b0aa15..a6e9ef1 100644
--- a/proton-c/CMakeLists.txt
+++ b/proton-c/CMakeLists.txt
@@ -561,7 +561,7 @@ if (MSVC)
add_dependencies(qpid-proton qpid-proton-core)
endif (MSVC)
-target_link_libraries (qpid-proton ${UUID_LIB} ${SSL_LIB} ${SASL_LIB} ${TIME_LIB} ${PLATFORM_LIBS} ${PROACTOR_LIBS})
+target_link_libraries (qpid-proton LINK_PRIVATE ${UUID_LIB} ${SSL_LIB} ${SASL_LIB} ${TIME_LIB} ${PLATFORM_LIBS} ${PROACTOR_LIBS})
set_target_properties (
qpid-proton
@@ -581,7 +581,8 @@ if (qpid-proton-proactor)
set(HAS_PROACTOR 1 PARENT_SCOPE) # Visible to examples
add_library (
qpid-proton-proactor SHARED ${qpid-proton-proactor})
- target_link_libraries (qpid-proton-proactor qpid-proton-core ${PROACTOR_LIBS})
+ target_link_libraries (qpid-proton-proactor LINK_PUBLIC qpid-proton-core)
+ target_link_libraries (qpid-proton-proactor LINK_PRIVATE ${PROACTOR_LIBS})
list(APPEND LIB_TARGETS qpid-proton-proactor)
endif()
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org