You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Lee-W (via GitHub)" <gi...@apache.org> on 2024/02/15 10:41:27 UTC
Re: [PR] minor Amazon provider improvements [airflow]
Lee-W commented on code in PR #36330:
URL: https://github.com/apache/airflow/pull/36330#discussion_r1490797175
##########
airflow/providers/amazon/aws/operators/batch.py:
##########
@@ -255,11 +255,16 @@ def execute(self, context: Context):
return self.job_id
- def execute_complete(self, context, event=None):
+ def execute_complete(self, context: Context, event: dict[str, Any] | None = None) -> str:
Review Comment:
I tried to extract a utility function and check the event instead. The detail and even signature are different between execute_complete methods
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org