[GitHub] drill pull request #:

[Ben-Zvi <gi...@git.apache.org>]

Github user Ben-Zvi commented on the pull request:

    https://github.com/apache/drill/commit/c16570705a182bf833576a7ddb546665442ef14d#commitcomment-20771562
  
    In exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java:
    In exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/ExternalSortBatch.java on line 395:
    (not a comment) A wish -- Wish our options setting mechanism be more sophisticated; like define the option along with various restrictions (like min and max values, etc). Then all those checks would be done in a single module, instead of all over the code - like here defining an inline constant and adding code to compare the option. Also here if a user sets a value violating the limit he/she would not understand why the new value did not apply. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---