You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "andpab (via GitHub)" <gi...@apache.org> on 2023/02/11 19:50:13 UTC
[GitHub] [maven-surefire] andpab opened a new pull request, #612: [SUREFIRE-2143] Fix reporting of skipped parameterized test
andpab opened a new pull request, #612:
URL: https://github.com/apache/maven-surefire/pull/612
This fixes the regression https://issues.apache.org/jira/browse/SUREFIRE-2143
- In executionSkipped handle ParameterizedTest which is a non-class test container the same as a regular test
- In executionSkipped always remove the testIdentifier from the map testStartTime, regardless if it's a class or a test
- In createReportEntry set methodName and methodText if the testExecutionResult is null, which is the case for skipped tests, otherwise the test name in the XML report is left empty
- Add ITs also for the related previous issue SUREFIRE-2032 the fix of which caused this regression, to make sure that fix still works
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean install` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean install`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski merged pull request #612: [SUREFIRE-2143] Fix reporting of skipped parameterized test
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski merged PR #612:
URL: https://github.com/apache/maven-surefire/pull/612
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] andpab commented on pull request #612: [SUREFIRE-2143] Fix reporting of skipped parameterized test
Posted by "andpab (via GitHub)" <gi...@apache.org>.
andpab commented on PR #612:
URL: https://github.com/apache/maven-surefire/pull/612#issuecomment-1434378765
All successful except for one macOS build in which the ConsoleOutputIT_largerSoutThanMemory failed - probably an unrelated flake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on pull request #612: [SUREFIRE-2143] Fix reporting of skipped parameterized test
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #612:
URL: https://github.com/apache/maven-surefire/pull/612#issuecomment-1432700785
@andpab please rebase with the latest master - to be sure that all test pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org