You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "liyamahendra (via GitHub)" <gi...@apache.org> on 2023/02/11 14:57:21 UTC
[GitHub] [cordova-docs] liyamahendra opened a new pull request, #1285: android: Updated docs for supporting themed icons
liyamahendra opened a new pull request, #1285:
URL: https://github.com/apache/cordova-docs/pull/1285
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
https://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
- android
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
Android 13 added support for Themed Icons. Since themed icons aren't yet supported on Cordova Android, adding support for Themed icons.
closes https://github.com/apache/cordova-android/issues/1450
### Description
<!-- Describe your changes in detail -->
Added details about the `monochrome` attribute for Adaptive icons
### Testing
<!-- Please describe in detail how you tested your changes. -->
n/a
### Checklist
- [ ] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-docs] liyamahendra commented on pull request #1285: android: Updated docs for supporting themed icons
Posted by "liyamahendra (via GitHub)" <gi...@apache.org>.
liyamahendra commented on PR #1285:
URL: https://github.com/apache/cordova-docs/pull/1285#issuecomment-1426792566
@breautek just tagging you here. Kindly tag anyone that need to verify the changes please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-docs] erisu merged pull request #1285: docs(android): support for themed icons
Posted by "erisu (via GitHub)" <gi...@apache.org>.
erisu merged PR #1285:
URL: https://github.com/apache/cordova-docs/pull/1285
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-docs] liyamahendra commented on a diff in pull request #1285: android: Updated docs for supporting themed icons
Posted by "liyamahendra (via GitHub)" <gi...@apache.org>.
liyamahendra commented on code in PR #1285:
URL: https://github.com/apache/cordova-docs/pull/1285#discussion_r1108041095
##########
www/docs/en/dev/config_ref/images.md:
##########
@@ -54,27 +54,28 @@ different screen resolutions.
## Android
-On Android, instead of using a single image for an icon, you can use two images (background and foreground) to create an **Adaptive Icon**. To use Adaptive Icons, you need to have installed at least version 9.0.0 of **Cordova** and version 8.0.0 of **Cordova-Android**.
+On Android, instead of using a single image for an icon, you can use two images (background and foreground) to create an **Adaptive Icon**. WIth the support for themed icons from Android 13, you can use three images (background, foreground and monochrome) to create an **Adaptive Icon**. To use Adaptive Icons, you need to have installed at least version 9.0.0 of **Cordova** and version 8.0.0 of **Cordova-Android**.
Review Comment:
Using a separate paragraph for Themed icons is way better, thank you! And thank you for adding the `v12.0.0` requirement.
I think @erisu your suggestion is apt; unless there is anything else that you think I should consider, I think this is good to go. Kindly let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-docs] erisu commented on a diff in pull request #1285: android: Updated docs for supporting themed icons
Posted by "erisu (via GitHub)" <gi...@apache.org>.
erisu commented on code in PR #1285:
URL: https://github.com/apache/cordova-docs/pull/1285#discussion_r1107951405
##########
www/docs/en/dev/config_ref/images.md:
##########
@@ -54,27 +54,28 @@ different screen resolutions.
## Android
-On Android, instead of using a single image for an icon, you can use two images (background and foreground) to create an **Adaptive Icon**. To use Adaptive Icons, you need to have installed at least version 9.0.0 of **Cordova** and version 8.0.0 of **Cordova-Android**.
+On Android, instead of using a single image for an icon, you can use two images (background and foreground) to create an **Adaptive Icon**. WIth the support for themed icons from Android 13, you can use three images (background, foreground and monochrome) to create an **Adaptive Icon**. To use Adaptive Icons, you need to have installed at least version 9.0.0 of **Cordova** and version 8.0.0 of **Cordova-Android**.
Review Comment:
I think it might be better to split this change into a separate paragraph. Stuck in the middle sounds confusing because the following line talks about the minimum requirement for Adaptive Icons in Cordova, while the requirements for monochrome are different.
Here is maybe an example, but the wording should be confirmed.
```suggestion
Instead of using a single image for an icon, you can use two images (background and foreground) to create an **Adaptive Icon**. To use Adaptive Icons in Cordova, at minimum **Cordova CLI** 9.0.0 and **Cordova-Android** 8.0.0 is required.
Android 13 has introduced themed icons which are monochrome images appended to the existing **Adaptive Icons**. To use Themed Icon in Cordova, at minimum **Cordova CLI** 12.0.0 and **Cordova-Android** 12.0.0 is required.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org