You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/08/01 11:46:46 UTC

[GitHub] [dolphinscheduler-website] ruanwenjun commented on a change in pull request #415: [Imporvement][Doc] /development/architecture-design.html

ruanwenjun commented on a change in pull request #415:
URL: https://github.com/apache/dolphinscheduler-website/pull/415#discussion_r680498880



##########
File path: development/zh-cn/architecture-design.md
##########
@@ -131,12 +131,12 @@
 DolphinScheduler使用ZooKeeper分布式锁来实现同一时刻只有一台Master执行Scheduler,或者只有一台Worker执行任务的提交。
 1. 获取分布式锁的核心流程算法如下
  <p align="center">
-   <img src="https://analysys.github.io/easyscheduler_docs_cn/images/distributed_lock.png" alt="获取分布式锁流程"  width="50%" />
+   <img src="/img/architecture-design/distributed_lock_zh_cn.png" alt="获取分布式锁流程"  width="55%" />

Review comment:
       Please rename to `distributed_lock_ch_zn.png`

##########
File path: development/en-us/architecture-design.md
##########
@@ -6,7 +6,7 @@ Before explaining the architecture of the schedule system, let us first understa
 **DAG:** Full name Directed Acyclic Graph,referred to as DAG。Tasks in the workflow are assembled in the form of directed acyclic graphs, which are topologically traversed from nodes with zero indegrees of ingress until there are no successor nodes. For example, the following picture:
 
 <p align="center">
-  <img src="/img/dag_examples_cn.jpg" alt="dag示例"  width="60%" />
+  <img src="/img/architecture-design/dag_examples_en_us.PNG" alt="dag示例"  width="60%" />

Review comment:
       Please use lowercase suffixes `dag_examples_en_us.png`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org