You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/07/09 02:45:51 UTC

[GitHub] [hbase] bsglz commented on a change in pull request #1926: HBASE-24586 Add table level locality in table.jsp

bsglz commented on a change in pull request #1926:
URL: https://github.com/apache/hbase/pull/1926#discussion_r451932583



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/HDFSBlocksDistribution.java
##########
@@ -228,33 +228,49 @@ public long getUniqueBlocksTotalWeight() {
    * Implementations 'visit' hostAndWeight.
    */
   public interface Visitor {
-    float visit(final HostAndWeight hostAndWeight);
+    long visit(final HostAndWeight hostAndWeight);

Review comment:
       Just thought we need fetch original value now, change it to long will more flexbility.
   Thanks.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org