[GitHub] [nifi] greyp9 commented on pull request #6172: NIFI-10143 - ListFTP/GetFTP charset issues

[GitBox <gi...@apache.org>]

greyp9 commented on PR #6172:
URL: https://github.com/apache/nifi/pull/6172#issuecomment-1172776789

   > Thanks for digging into this issue and developing a new test @greyp9! The ClientProvider changes make sense.
   > 
   > The new test is helpful, and covers a lot of ground. It does a lot of work, and it seems to stretch the boundary of a unit test versus an integration test. In light of having existing unit tests for FTP processors, it seems better to maintain a minimal unit test, and then provide this new test class as an integration test. As noted in the detailed comments, there are several ways the test could be optimized. Supporting an external FTP server is also useful, and could be parameterized through System properties or environment variables.
   > 
   > What do you think about changing the test to an integration test, an updating existing unit tests with more minimal changes to incorporate evaluation of UTF-8 encoding?
   
   I've renamed to *IT to align with integration test naming convention.  I'd like to defer modifications of the existing unit tests to be part of future efforts, as needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org