You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2016/08/01 07:27:37 UTC
Re: Review Request 50600: LENS-1243: Support Asynchronous status
updates from drivers
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50600/
-----------------------------------------------------------
(Updated Aug. 1, 2016, 12:57 p.m.)
Review request for lens.
Bugs: LENS-1243
https://issues.apache.org/jira/browse/LENS-1243
Repository: lens
Description
-------
Diffs (updated)
-----
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 6dff173e26993e40e3cb82622be8173359f92592
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 8047302d880a99fc04dac82b58a67d968e242dd1
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 491aa6976d6e73ddfb45494823cae7d6a3429887
lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java f1d844a1987d7f7990b2e10f03d2e3af8e0294e0
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java 2374c1e4b2737a0d1ea7123232800413baa9a560
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 95ea3608e612aff44ec78eee003c05ccd3068ffb
lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryDriverStatusUpdateListener.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/StatusUpdateMethod.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java e160f58bfb45cffb05b9f6be19db3bc7605dde57
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 2641b606faa20943a5f3b9de9b729380a35e8c25
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java f5ea3db82f350e99c43604c0af7a7687839dbc81
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 9f40a014bebdfc6f0ff7ea3d7a21baacc890018d
lens-server/src/test/resources/lens-site.xml 908fbb232f3065518f62b08c997a6bfb7e1eed11
pom.xml f5a80df725b4730181a78817a685f85905406914
Diff: https://reviews.apache.org/r/50600/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 50600: LENS-1243: Support Asynchronous status
updates from drivers
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50600/#review144727
-----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRangeWriter.java (line 31)
<https://reviews.apache.org/r/50600/#comment210805>
Looks unrelated.please check
- Puneet Gupta
On Aug. 3, 2016, 8:58 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50600/
> -----------------------------------------------------------
>
> (Updated Aug. 3, 2016, 8:58 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1243
> https://issues.apache.org/jira/browse/LENS-1243
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRangeWriter.java 08f957e0820ac507dce1855430887b5caa0e3586
> lens-driver-es/src/main/java/org/apache/lens/driver/es/ESDriver.java 8a4f4105ad6ffc75445e5e10a51f6fbd4f5f1d3f
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 1326611d01e7a9b4f58877435f36b1391ca178b2
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 6dff173e26993e40e3cb82622be8173359f92592
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bebb9ae9a4d694f224f0ec907df166880e0cf5b8
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 12fa6f0328242b1bd06ff0397b2f2a3a9dec010d
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java e7636d2e631cf86021af398ee31300441a335096
> lens-driver-jdbc/src/test/resources/hive-site.xml b497ca19b14811ecb4474b7f9bf6dec2bdf0b036
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java f1d844a1987d7f7990b2e10f03d2e3af8e0294e0
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java 2374c1e4b2737a0d1ea7123232800413baa9a560
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 95ea3608e612aff44ec78eee003c05ccd3068ffb
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryCompletionListener.java 3713b5156e2cfc20528d9b3b9a6f9b117daeb284
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryDriverStatusUpdateListener.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/StatusUpdateMethod.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java e160f58bfb45cffb05b9f6be19db3bc7605dde57
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 2641b606faa20943a5f3b9de9b729380a35e8c25
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 59f85691d08e7deb5e3b5892b3ffc729265874d8
> lens-server/src/main/java/org/apache/lens/server/LensServerConf.java e977ebd82118307bdbfd20be762a523337da4788
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 84dcecda0970d2756a943522a5876117daa71409
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 9f40a014bebdfc6f0ff7ea3d7a21baacc890018d
> lens-server/src/test/resources/hive-site.xml 94c5012821330e1a78aad2a7fdfca0cc1d0fade2
>
> Diff: https://reviews.apache.org/r/50600/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 50600: LENS-1243: Support Asynchronous status
updates from drivers
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On Aug. 4, 2016, 7:03 p.m., Puneet Gupta wrote:
> > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java, line 1041
> > <https://reviews.apache.org/r/50600/diff/6/?file=1461126#file1461126line1041>
> >
> > will driver status cancelled be different from query status cancelled ?
Removed duplication. Now boolean is not there, only enum check everywhere.
> On Aug. 4, 2016, 7:03 p.m., Puneet Gupta wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryDriverStatusUpdateListener.java, line 27
> > <https://reviews.apache.org/r/50600/diff/6/?file=1461134#file1461134line27>
> >
> > Should we name it DriverQueryStatusUpdateListener
That would sound like a listener for driver's status updates instead of a listener for query's driver-states-updates.
> On Aug. 4, 2016, 7:03 p.m., Puneet Gupta wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java, line 495
> > <https://reviews.apache.org/r/50600/diff/6/?file=1461137#file1461137line495>
> >
> > We dont need this anymore?
This method was unused.
> On Aug. 4, 2016, 7:03 p.m., Puneet Gupta wrote:
> > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java, line 820
> > <https://reviews.apache.org/r/50600/diff/6/?file=1461140#file1461140line820>
> >
> > Should we Remove Async from name ?
There's already a StatusPoller. The name `StatusUpdater` would be confusing. Hence added `Async`.
> On Aug. 4, 2016, 7:03 p.m., Puneet Gupta wrote:
> > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java, line 825
> > <https://reviews.apache.org/r/50600/diff/6/?file=1461140#file1461140line825>
> >
> > Should we optimize in this case ? updateState() will again ask the driver for status though driver already sent the updated status
Optimized by adding a boolean and overriding the method.
> On Aug. 4, 2016, 7:03 p.m., Puneet Gupta wrote:
> > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java, line 993
> > <https://reviews.apache.org/r/50600/diff/6/?file=1461126#file1461126line993>
> >
> > should we remove registerForCompletionNotification method from drivers and rely on QueryContext.registerStatusUpdateListener()?
> >
> > Let notification be realtime only for PUSH type drivers and let PULL type drivers rely on status poller to update status and trigger notifictaion (we ll be removing the extra polling thread from Hive in this case.. don't think its useful anyway for hive queries)
This change might change the functionality of `execute with timeout` for hive queries. Didn't want to change that. We can certainly pick it up seperately.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50600/#review144728
-----------------------------------------------------------
On Aug. 4, 2016, 6:30 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50600/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2016, 6:30 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1243
> https://issues.apache.org/jira/browse/LENS-1243
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-driver-es/src/main/java/org/apache/lens/driver/es/ESDriver.java 8a4f4105ad6ffc75445e5e10a51f6fbd4f5f1d3f
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 1326611d01e7a9b4f58877435f36b1391ca178b2
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 6dff173e26993e40e3cb82622be8173359f92592
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bebb9ae9a4d694f224f0ec907df166880e0cf5b8
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 12fa6f0328242b1bd06ff0397b2f2a3a9dec010d
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java e7636d2e631cf86021af398ee31300441a335096
> lens-driver-jdbc/src/test/resources/hive-site.xml b497ca19b14811ecb4474b7f9bf6dec2bdf0b036
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java f1d844a1987d7f7990b2e10f03d2e3af8e0294e0
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java 2374c1e4b2737a0d1ea7123232800413baa9a560
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 95ea3608e612aff44ec78eee003c05ccd3068ffb
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryCompletionListener.java 3713b5156e2cfc20528d9b3b9a6f9b117daeb284
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryDriverStatusUpdateListener.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/StatusUpdateMethod.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 2641b606faa20943a5f3b9de9b729380a35e8c25
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 59f85691d08e7deb5e3b5892b3ffc729265874d8
> lens-server/src/main/java/org/apache/lens/server/LensServerConf.java e977ebd82118307bdbfd20be762a523337da4788
> lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java 47159b568e9eff2f39ede9839f278441f0305d1f
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 84dcecda0970d2756a943522a5876117daa71409
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 9f40a014bebdfc6f0ff7ea3d7a21baacc890018d
> lens-server/src/test/resources/hive-site.xml 94c5012821330e1a78aad2a7fdfca0cc1d0fade2
>
> Diff: https://reviews.apache.org/r/50600/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 50600: LENS-1243: Support Asynchronous status
updates from drivers
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50600/#review144728
-----------------------------------------------------------
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java
<https://reviews.apache.org/r/50600/#comment210850>
should we remove registerForCompletionNotification method from drivers and rely on QueryContext.registerStatusUpdateListener()?
Let notification be realtime only for PUSH type drivers and let PULL type drivers rely on status poller to update status and trigger notifictaion (we ll be removing the extra polling thread from Hive in this case.. don't think its useful anyway for hive queries)
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java (line 976)
<https://reviews.apache.org/r/50600/#comment210857>
will driver status cancelled be different from query status cancelled ?
lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryDriverStatusUpdateListener.java (line 27)
<https://reviews.apache.org/r/50600/#comment210837>
Should we name it DriverQueryStatusUpdateListener
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
<https://reviews.apache.org/r/50600/#comment210808>
We dont need this anymore?
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 817)
<https://reviews.apache.org/r/50600/#comment210838>
Should we Remove Async from name ?
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 822)
<https://reviews.apache.org/r/50600/#comment210809>
Should we optimize in this case ? updateState() will again ask the driver for status though driver already sent the updated status
- Puneet Gupta
On Aug. 4, 2016, 1 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50600/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2016, 1 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1243
> https://issues.apache.org/jira/browse/LENS-1243
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-driver-es/src/main/java/org/apache/lens/driver/es/ESDriver.java 8a4f4105ad6ffc75445e5e10a51f6fbd4f5f1d3f
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 1326611d01e7a9b4f58877435f36b1391ca178b2
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 6dff173e26993e40e3cb82622be8173359f92592
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bebb9ae9a4d694f224f0ec907df166880e0cf5b8
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 12fa6f0328242b1bd06ff0397b2f2a3a9dec010d
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java e7636d2e631cf86021af398ee31300441a335096
> lens-driver-jdbc/src/test/resources/hive-site.xml b497ca19b14811ecb4474b7f9bf6dec2bdf0b036
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java f1d844a1987d7f7990b2e10f03d2e3af8e0294e0
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java 2374c1e4b2737a0d1ea7123232800413baa9a560
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 95ea3608e612aff44ec78eee003c05ccd3068ffb
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryCompletionListener.java 3713b5156e2cfc20528d9b3b9a6f9b117daeb284
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryDriverStatusUpdateListener.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/StatusUpdateMethod.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 2641b606faa20943a5f3b9de9b729380a35e8c25
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 59f85691d08e7deb5e3b5892b3ffc729265874d8
> lens-server/src/main/java/org/apache/lens/server/LensServerConf.java e977ebd82118307bdbfd20be762a523337da4788
> lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java 47159b568e9eff2f39ede9839f278441f0305d1f
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 84dcecda0970d2756a943522a5876117daa71409
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 9f40a014bebdfc6f0ff7ea3d7a21baacc890018d
> lens-server/src/test/resources/hive-site.xml 94c5012821330e1a78aad2a7fdfca0cc1d0fade2
>
> Diff: https://reviews.apache.org/r/50600/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 50600: LENS-1243: Support Asynchronous status
updates from drivers
Posted by Rajat Khandelwal <ra...@gmail.com>.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50600/#review146065
-----------------------------------------------------------
On Aug. 22, 2016, 1:17 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50600/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2016, 1:17 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1243
> https://issues.apache.org/jira/browse/LENS-1243
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-driver-es/src/main/java/org/apache/lens/driver/es/ESDriver.java 8a4f4105ad6ffc75445e5e10a51f6fbd4f5f1d3f
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 1326611d01e7a9b4f58877435f36b1391ca178b2
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 6dff173e26993e40e3cb82622be8173359f92592
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bebb9ae9a4d694f224f0ec907df166880e0cf5b8
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 12fa6f0328242b1bd06ff0397b2f2a3a9dec010d
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java e7636d2e631cf86021af398ee31300441a335096
> lens-driver-jdbc/src/test/resources/hive-site.xml b497ca19b14811ecb4474b7f9bf6dec2bdf0b036
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java f1d844a1987d7f7990b2e10f03d2e3af8e0294e0
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java 2374c1e4b2737a0d1ea7123232800413baa9a560
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 95ea3608e612aff44ec78eee003c05ccd3068ffb
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryCompletionListener.java 3713b5156e2cfc20528d9b3b9a6f9b117daeb284
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryDriverStatusUpdateListener.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/StatusUpdateMethod.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 2641b606faa20943a5f3b9de9b729380a35e8c25
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 59f85691d08e7deb5e3b5892b3ffc729265874d8
> lens-server/src/main/java/org/apache/lens/server/LensServerConf.java e977ebd82118307bdbfd20be762a523337da4788
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1752414e89c550c31645f2a2fd686f5b06686a93
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java be1326f62e47c72514039fc6525eeea12ae28456
> lens-server/src/test/resources/hive-site.xml 94c5012821330e1a78aad2a7fdfca0cc1d0fade2
>
> Diff: https://reviews.apache.org/r/50600/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 50600: LENS-1243: Support Asynchronous status
updates from drivers
Posted by Rajat Khandelwal <ra...@gmail.com>.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50600/#review146065
-----------------------------------------------------------
On Aug. 22, 2016, 1:17 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50600/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2016, 1:17 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1243
> https://issues.apache.org/jira/browse/LENS-1243
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-driver-es/src/main/java/org/apache/lens/driver/es/ESDriver.java 8a4f4105ad6ffc75445e5e10a51f6fbd4f5f1d3f
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 1326611d01e7a9b4f58877435f36b1391ca178b2
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 6dff173e26993e40e3cb82622be8173359f92592
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bebb9ae9a4d694f224f0ec907df166880e0cf5b8
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 12fa6f0328242b1bd06ff0397b2f2a3a9dec010d
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java e7636d2e631cf86021af398ee31300441a335096
> lens-driver-jdbc/src/test/resources/hive-site.xml b497ca19b14811ecb4474b7f9bf6dec2bdf0b036
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java f1d844a1987d7f7990b2e10f03d2e3af8e0294e0
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java 2374c1e4b2737a0d1ea7123232800413baa9a560
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 95ea3608e612aff44ec78eee003c05ccd3068ffb
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryCompletionListener.java 3713b5156e2cfc20528d9b3b9a6f9b117daeb284
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryDriverStatusUpdateListener.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/StatusUpdateMethod.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 2641b606faa20943a5f3b9de9b729380a35e8c25
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 59f85691d08e7deb5e3b5892b3ffc729265874d8
> lens-server/src/main/java/org/apache/lens/server/LensServerConf.java e977ebd82118307bdbfd20be762a523337da4788
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1752414e89c550c31645f2a2fd686f5b06686a93
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java be1326f62e47c72514039fc6525eeea12ae28456
> lens-server/src/test/resources/hive-site.xml 94c5012821330e1a78aad2a7fdfca0cc1d0fade2
>
> Diff: https://reviews.apache.org/r/50600/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 50600: LENS-1243: Support Asynchronous status
updates from drivers
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On Aug. 18, 2016, 11:40 a.m., Amareshwari Sriramadasu wrote:
> > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java, line 1075
> > <https://reviews.apache.org/r/50600/diff/10/?file=1471878#file1471878line1075>
> >
> > isFinished is checking for all states - finished/cancelled/error . Setting state as successful does not seem correct.
Makes sense. But looking at the earlier code, it's calling `onCompletion` even when it `FAILED`, since `isFinished` will return `true`, which seems to be a bug in the existing code. Will modify and update.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50600/#review146065
-----------------------------------------------------------
On Aug. 22, 2016, 1:17 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50600/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2016, 1:17 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1243
> https://issues.apache.org/jira/browse/LENS-1243
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-driver-es/src/main/java/org/apache/lens/driver/es/ESDriver.java 8a4f4105ad6ffc75445e5e10a51f6fbd4f5f1d3f
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 1326611d01e7a9b4f58877435f36b1391ca178b2
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 6dff173e26993e40e3cb82622be8173359f92592
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bebb9ae9a4d694f224f0ec907df166880e0cf5b8
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 12fa6f0328242b1bd06ff0397b2f2a3a9dec010d
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java e7636d2e631cf86021af398ee31300441a335096
> lens-driver-jdbc/src/test/resources/hive-site.xml b497ca19b14811ecb4474b7f9bf6dec2bdf0b036
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java f1d844a1987d7f7990b2e10f03d2e3af8e0294e0
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java 2374c1e4b2737a0d1ea7123232800413baa9a560
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 95ea3608e612aff44ec78eee003c05ccd3068ffb
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryCompletionListener.java 3713b5156e2cfc20528d9b3b9a6f9b117daeb284
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryDriverStatusUpdateListener.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/StatusUpdateMethod.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 2641b606faa20943a5f3b9de9b729380a35e8c25
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 59f85691d08e7deb5e3b5892b3ffc729265874d8
> lens-server/src/main/java/org/apache/lens/server/LensServerConf.java e977ebd82118307bdbfd20be762a523337da4788
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1752414e89c550c31645f2a2fd686f5b06686a93
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java be1326f62e47c72514039fc6525eeea12ae28456
> lens-server/src/test/resources/hive-site.xml 94c5012821330e1a78aad2a7fdfca0cc1d0fade2
>
> Diff: https://reviews.apache.org/r/50600/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 50600: LENS-1243: Support Asynchronous status
updates from drivers
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50600/#review146065
-----------------------------------------------------------
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java (line 1074)
<https://reviews.apache.org/r/50600/#comment212441>
isFinished is checking for all states - finished/cancelled/error . Setting state as successful does not seem correct.
- Amareshwari Sriramadasu
On Aug. 12, 2016, 7:40 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50600/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2016, 7:40 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1243
> https://issues.apache.org/jira/browse/LENS-1243
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-driver-es/src/main/java/org/apache/lens/driver/es/ESDriver.java 8a4f4105ad6ffc75445e5e10a51f6fbd4f5f1d3f
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 1326611d01e7a9b4f58877435f36b1391ca178b2
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 6dff173e26993e40e3cb82622be8173359f92592
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bebb9ae9a4d694f224f0ec907df166880e0cf5b8
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 12fa6f0328242b1bd06ff0397b2f2a3a9dec010d
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java e7636d2e631cf86021af398ee31300441a335096
> lens-driver-jdbc/src/test/resources/hive-site.xml b497ca19b14811ecb4474b7f9bf6dec2bdf0b036
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java f1d844a1987d7f7990b2e10f03d2e3af8e0294e0
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java 2374c1e4b2737a0d1ea7123232800413baa9a560
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 95ea3608e612aff44ec78eee003c05ccd3068ffb
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryCompletionListener.java 3713b5156e2cfc20528d9b3b9a6f9b117daeb284
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryDriverStatusUpdateListener.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/StatusUpdateMethod.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 2641b606faa20943a5f3b9de9b729380a35e8c25
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 59f85691d08e7deb5e3b5892b3ffc729265874d8
> lens-server/src/main/java/org/apache/lens/server/LensServerConf.java e977ebd82118307bdbfd20be762a523337da4788
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1752414e89c550c31645f2a2fd686f5b06686a93
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java be1326f62e47c72514039fc6525eeea12ae28456
> lens-server/src/test/resources/hive-site.xml 94c5012821330e1a78aad2a7fdfca0cc1d0fade2
>
> Diff: https://reviews.apache.org/r/50600/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 50600: LENS-1243: Support Asynchronous status
updates from drivers
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50600/#review146500
-----------------------------------------------------------
lens-driver-es/src/main/java/org/apache/lens/driver/es/ESDriver.java (line 202)
<https://reviews.apache.org/r/50600/#comment212980>
Lets add notification on cancel also in QueryCompletionListener
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java (line 1097)
<https://reviews.apache.org/r/50600/#comment212983>
Lets leave this as onError() only.
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java (line 263)
<https://reviews.apache.org/r/50600/#comment212987>
Lets put is as initialized
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java (line 292)
<https://reviews.apache.org/r/50600/#comment212991>
We might have to add this to catch block also.
lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryCompletionListener.java (line 52)
<https://reviews.apache.org/r/50600/#comment212998>
Lets do onError for canceled also.
- Amareshwari Sriramadasu
On Aug. 22, 2016, 8:54 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50600/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2016, 8:54 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1243
> https://issues.apache.org/jira/browse/LENS-1243
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-driver-es/src/main/java/org/apache/lens/driver/es/ESDriver.java 8a4f4105ad6ffc75445e5e10a51f6fbd4f5f1d3f
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 1326611d01e7a9b4f58877435f36b1391ca178b2
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 6dff173e26993e40e3cb82622be8173359f92592
> lens-driver-hive/src/test/resources/hive-site.xml 2f4076a1d7e20c84464226868d99fffeb2fed5b8
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bebb9ae9a4d694f224f0ec907df166880e0cf5b8
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 12fa6f0328242b1bd06ff0397b2f2a3a9dec010d
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java e7636d2e631cf86021af398ee31300441a335096
> lens-driver-jdbc/src/test/resources/hive-site.xml b497ca19b14811ecb4474b7f9bf6dec2bdf0b036
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java f1d844a1987d7f7990b2e10f03d2e3af8e0294e0
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java 2374c1e4b2737a0d1ea7123232800413baa9a560
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 95ea3608e612aff44ec78eee003c05ccd3068ffb
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryCompletionListener.java 3713b5156e2cfc20528d9b3b9a6f9b117daeb284
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryDriverStatusUpdateListener.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/StatusUpdateMethod.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 2641b606faa20943a5f3b9de9b729380a35e8c25
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 59f85691d08e7deb5e3b5892b3ffc729265874d8
> lens-server/src/main/java/org/apache/lens/server/LensServerConf.java e977ebd82118307bdbfd20be762a523337da4788
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1752414e89c550c31645f2a2fd686f5b06686a93
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java be1326f62e47c72514039fc6525eeea12ae28456
> lens-server/src/test/resources/hive-site.xml 94c5012821330e1a78aad2a7fdfca0cc1d0fade2
>
> Diff: https://reviews.apache.org/r/50600/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 50600: LENS-1243: Support Asynchronous status
updates from drivers
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On Aug. 23, 2016, 5:33 p.m., Amareshwari Sriramadasu wrote:
> > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java, line 585
> > <https://reviews.apache.org/r/50600/diff/13/?file=1481842#file1481842line585>
> >
> > How is time update happening in this flow? Can we have sigle method/api to set/update state and time?
This is happening in existing code. No changes required.
> On Aug. 23, 2016, 5:33 p.m., Amareshwari Sriramadasu wrote:
> > lens-driver-es/src/main/java/org/apache/lens/driver/es/ESDriver.java, line 150
> > <https://reviews.apache.org/r/50600/diff/13/?file=1481841#file1481841line150>
> >
> > not populated on execute() api ? cancelQuery might give NPE in that case.
Added.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50600/#review146509
-----------------------------------------------------------
On Aug. 23, 2016, 3:52 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50600/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2016, 3:52 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1243
> https://issues.apache.org/jira/browse/LENS-1243
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-driver-es/src/main/java/org/apache/lens/driver/es/ESDriver.java 8a4f4105ad6ffc75445e5e10a51f6fbd4f5f1d3f
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 1326611d01e7a9b4f58877435f36b1391ca178b2
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 6dff173e26993e40e3cb82622be8173359f92592
> lens-driver-hive/src/test/resources/hive-site.xml 2f4076a1d7e20c84464226868d99fffeb2fed5b8
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bebb9ae9a4d694f224f0ec907df166880e0cf5b8
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 12fa6f0328242b1bd06ff0397b2f2a3a9dec010d
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java e7636d2e631cf86021af398ee31300441a335096
> lens-driver-jdbc/src/test/resources/hive-site.xml b497ca19b14811ecb4474b7f9bf6dec2bdf0b036
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java f1d844a1987d7f7990b2e10f03d2e3af8e0294e0
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java 2374c1e4b2737a0d1ea7123232800413baa9a560
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 95ea3608e612aff44ec78eee003c05ccd3068ffb
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryCompletionListener.java 3713b5156e2cfc20528d9b3b9a6f9b117daeb284
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryDriverStatusUpdateListener.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/StatusUpdateMethod.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 2641b606faa20943a5f3b9de9b729380a35e8c25
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 59f85691d08e7deb5e3b5892b3ffc729265874d8
> lens-server/src/main/java/org/apache/lens/server/LensServerConf.java e977ebd82118307bdbfd20be762a523337da4788
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 78d0b8a96349c35565389936170ba8f68b950efb
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 9384e1ce5000135b112fa2aad078418cdd524ce6
> lens-server/src/test/resources/hive-site.xml 94c5012821330e1a78aad2a7fdfca0cc1d0fade2
>
> Diff: https://reviews.apache.org/r/50600/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 50600: LENS-1243: Support Asynchronous status
updates from drivers
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50600/#review146509
-----------------------------------------------------------
lens-driver-es/src/main/java/org/apache/lens/driver/es/ESDriver.java (line 149)
<https://reviews.apache.org/r/50600/#comment213019>
not populated on execute() api ? cancelQuery might give NPE in that case.
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java (line 585)
<https://reviews.apache.org/r/50600/#comment213020>
How is time update happening in this flow? Can we have sigle method/api to set/update state and time?
- Amareshwari Sriramadasu
On Aug. 23, 2016, 10:22 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50600/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2016, 10:22 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1243
> https://issues.apache.org/jira/browse/LENS-1243
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-driver-es/src/main/java/org/apache/lens/driver/es/ESDriver.java 8a4f4105ad6ffc75445e5e10a51f6fbd4f5f1d3f
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 1326611d01e7a9b4f58877435f36b1391ca178b2
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 6dff173e26993e40e3cb82622be8173359f92592
> lens-driver-hive/src/test/resources/hive-site.xml 2f4076a1d7e20c84464226868d99fffeb2fed5b8
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bebb9ae9a4d694f224f0ec907df166880e0cf5b8
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 12fa6f0328242b1bd06ff0397b2f2a3a9dec010d
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java e7636d2e631cf86021af398ee31300441a335096
> lens-driver-jdbc/src/test/resources/hive-site.xml b497ca19b14811ecb4474b7f9bf6dec2bdf0b036
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java f1d844a1987d7f7990b2e10f03d2e3af8e0294e0
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java 2374c1e4b2737a0d1ea7123232800413baa9a560
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 95ea3608e612aff44ec78eee003c05ccd3068ffb
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryCompletionListener.java 3713b5156e2cfc20528d9b3b9a6f9b117daeb284
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryDriverStatusUpdateListener.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/StatusUpdateMethod.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 2641b606faa20943a5f3b9de9b729380a35e8c25
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 59f85691d08e7deb5e3b5892b3ffc729265874d8
> lens-server/src/main/java/org/apache/lens/server/LensServerConf.java e977ebd82118307bdbfd20be762a523337da4788
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 78d0b8a96349c35565389936170ba8f68b950efb
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 9384e1ce5000135b112fa2aad078418cdd524ce6
> lens-server/src/test/resources/hive-site.xml 94c5012821330e1a78aad2a7fdfca0cc1d0fade2
>
> Diff: https://reviews.apache.org/r/50600/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 50600: LENS-1243: Support Asynchronous status
updates from drivers
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50600/#review146511
-----------------------------------------------------------
Other changes look fine to me.
- Amareshwari Sriramadasu
On Aug. 23, 2016, 10:22 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50600/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2016, 10:22 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1243
> https://issues.apache.org/jira/browse/LENS-1243
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-driver-es/src/main/java/org/apache/lens/driver/es/ESDriver.java 8a4f4105ad6ffc75445e5e10a51f6fbd4f5f1d3f
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 1326611d01e7a9b4f58877435f36b1391ca178b2
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 6dff173e26993e40e3cb82622be8173359f92592
> lens-driver-hive/src/test/resources/hive-site.xml 2f4076a1d7e20c84464226868d99fffeb2fed5b8
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bebb9ae9a4d694f224f0ec907df166880e0cf5b8
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 12fa6f0328242b1bd06ff0397b2f2a3a9dec010d
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java e7636d2e631cf86021af398ee31300441a335096
> lens-driver-jdbc/src/test/resources/hive-site.xml b497ca19b14811ecb4474b7f9bf6dec2bdf0b036
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java f1d844a1987d7f7990b2e10f03d2e3af8e0294e0
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java 2374c1e4b2737a0d1ea7123232800413baa9a560
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 95ea3608e612aff44ec78eee003c05ccd3068ffb
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryCompletionListener.java 3713b5156e2cfc20528d9b3b9a6f9b117daeb284
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryDriverStatusUpdateListener.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/StatusUpdateMethod.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 2641b606faa20943a5f3b9de9b729380a35e8c25
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 59f85691d08e7deb5e3b5892b3ffc729265874d8
> lens-server/src/main/java/org/apache/lens/server/LensServerConf.java e977ebd82118307bdbfd20be762a523337da4788
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 78d0b8a96349c35565389936170ba8f68b950efb
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 9384e1ce5000135b112fa2aad078418cdd524ce6
> lens-server/src/test/resources/hive-site.xml 94c5012821330e1a78aad2a7fdfca0cc1d0fade2
>
> Diff: https://reviews.apache.org/r/50600/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 50600: LENS-1243: Support Asynchronous status
updates from drivers
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50600/#review146595
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On Aug. 23, 2016, 1:54 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50600/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2016, 1:54 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1243
> https://issues.apache.org/jira/browse/LENS-1243
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-driver-es/src/main/java/org/apache/lens/driver/es/ESDriver.java 8a4f4105ad6ffc75445e5e10a51f6fbd4f5f1d3f
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 1326611d01e7a9b4f58877435f36b1391ca178b2
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 6dff173e26993e40e3cb82622be8173359f92592
> lens-driver-hive/src/test/resources/hive-site.xml 2f4076a1d7e20c84464226868d99fffeb2fed5b8
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bebb9ae9a4d694f224f0ec907df166880e0cf5b8
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 12fa6f0328242b1bd06ff0397b2f2a3a9dec010d
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java e7636d2e631cf86021af398ee31300441a335096
> lens-driver-jdbc/src/test/resources/hive-site.xml b497ca19b14811ecb4474b7f9bf6dec2bdf0b036
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java f1d844a1987d7f7990b2e10f03d2e3af8e0294e0
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java 2374c1e4b2737a0d1ea7123232800413baa9a560
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 95ea3608e612aff44ec78eee003c05ccd3068ffb
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryCompletionListener.java 3713b5156e2cfc20528d9b3b9a6f9b117daeb284
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryDriverStatusUpdateListener.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/StatusUpdateMethod.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 2641b606faa20943a5f3b9de9b729380a35e8c25
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 59f85691d08e7deb5e3b5892b3ffc729265874d8
> lens-server/src/main/java/org/apache/lens/server/LensServerConf.java e977ebd82118307bdbfd20be762a523337da4788
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 78d0b8a96349c35565389936170ba8f68b950efb
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 9384e1ce5000135b112fa2aad078418cdd524ce6
> lens-server/src/test/resources/hive-site.xml 94c5012821330e1a78aad2a7fdfca0cc1d0fade2
>
> Diff: https://reviews.apache.org/r/50600/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 50600: LENS-1243: Support Asynchronous status
updates from drivers
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50600/
-----------------------------------------------------------
(Updated Aug. 23, 2016, 7:24 p.m.)
Review request for lens.
Bugs: LENS-1243
https://issues.apache.org/jira/browse/LENS-1243
Repository: lens
Description
-------
Diffs (updated)
-----
lens-driver-es/src/main/java/org/apache/lens/driver/es/ESDriver.java 8a4f4105ad6ffc75445e5e10a51f6fbd4f5f1d3f
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 1326611d01e7a9b4f58877435f36b1391ca178b2
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 6dff173e26993e40e3cb82622be8173359f92592
lens-driver-hive/src/test/resources/hive-site.xml 2f4076a1d7e20c84464226868d99fffeb2fed5b8
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bebb9ae9a4d694f224f0ec907df166880e0cf5b8
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 12fa6f0328242b1bd06ff0397b2f2a3a9dec010d
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java e7636d2e631cf86021af398ee31300441a335096
lens-driver-jdbc/src/test/resources/hive-site.xml b497ca19b14811ecb4474b7f9bf6dec2bdf0b036
lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java f1d844a1987d7f7990b2e10f03d2e3af8e0294e0
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java 2374c1e4b2737a0d1ea7123232800413baa9a560
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 95ea3608e612aff44ec78eee003c05ccd3068ffb
lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryCompletionListener.java 3713b5156e2cfc20528d9b3b9a6f9b117daeb284
lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryDriverStatusUpdateListener.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/StatusUpdateMethod.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 2641b606faa20943a5f3b9de9b729380a35e8c25
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 59f85691d08e7deb5e3b5892b3ffc729265874d8
lens-server/src/main/java/org/apache/lens/server/LensServerConf.java e977ebd82118307bdbfd20be762a523337da4788
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 78d0b8a96349c35565389936170ba8f68b950efb
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 9384e1ce5000135b112fa2aad078418cdd524ce6
lens-server/src/test/resources/hive-site.xml 94c5012821330e1a78aad2a7fdfca0cc1d0fade2
Diff: https://reviews.apache.org/r/50600/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 50600: LENS-1243: Support Asynchronous status
updates from drivers
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50600/
-----------------------------------------------------------
(Updated Aug. 23, 2016, 3:52 p.m.)
Review request for lens.
Bugs: LENS-1243
https://issues.apache.org/jira/browse/LENS-1243
Repository: lens
Description
-------
Diffs (updated)
-----
lens-driver-es/src/main/java/org/apache/lens/driver/es/ESDriver.java 8a4f4105ad6ffc75445e5e10a51f6fbd4f5f1d3f
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 1326611d01e7a9b4f58877435f36b1391ca178b2
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 6dff173e26993e40e3cb82622be8173359f92592
lens-driver-hive/src/test/resources/hive-site.xml 2f4076a1d7e20c84464226868d99fffeb2fed5b8
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bebb9ae9a4d694f224f0ec907df166880e0cf5b8
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 12fa6f0328242b1bd06ff0397b2f2a3a9dec010d
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java e7636d2e631cf86021af398ee31300441a335096
lens-driver-jdbc/src/test/resources/hive-site.xml b497ca19b14811ecb4474b7f9bf6dec2bdf0b036
lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java f1d844a1987d7f7990b2e10f03d2e3af8e0294e0
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java 2374c1e4b2737a0d1ea7123232800413baa9a560
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 95ea3608e612aff44ec78eee003c05ccd3068ffb
lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryCompletionListener.java 3713b5156e2cfc20528d9b3b9a6f9b117daeb284
lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryDriverStatusUpdateListener.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/StatusUpdateMethod.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 2641b606faa20943a5f3b9de9b729380a35e8c25
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 59f85691d08e7deb5e3b5892b3ffc729265874d8
lens-server/src/main/java/org/apache/lens/server/LensServerConf.java e977ebd82118307bdbfd20be762a523337da4788
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 78d0b8a96349c35565389936170ba8f68b950efb
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 9384e1ce5000135b112fa2aad078418cdd524ce6
lens-server/src/test/resources/hive-site.xml 94c5012821330e1a78aad2a7fdfca0cc1d0fade2
Diff: https://reviews.apache.org/r/50600/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 50600: LENS-1243: Support Asynchronous status
updates from drivers
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50600/
-----------------------------------------------------------
(Updated Aug. 22, 2016, 2:24 p.m.)
Review request for lens.
Bugs: LENS-1243
https://issues.apache.org/jira/browse/LENS-1243
Repository: lens
Description
-------
Diffs (updated)
-----
lens-driver-es/src/main/java/org/apache/lens/driver/es/ESDriver.java 8a4f4105ad6ffc75445e5e10a51f6fbd4f5f1d3f
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 1326611d01e7a9b4f58877435f36b1391ca178b2
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 6dff173e26993e40e3cb82622be8173359f92592
lens-driver-hive/src/test/resources/hive-site.xml 2f4076a1d7e20c84464226868d99fffeb2fed5b8
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bebb9ae9a4d694f224f0ec907df166880e0cf5b8
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 12fa6f0328242b1bd06ff0397b2f2a3a9dec010d
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java e7636d2e631cf86021af398ee31300441a335096
lens-driver-jdbc/src/test/resources/hive-site.xml b497ca19b14811ecb4474b7f9bf6dec2bdf0b036
lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java f1d844a1987d7f7990b2e10f03d2e3af8e0294e0
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java 2374c1e4b2737a0d1ea7123232800413baa9a560
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 95ea3608e612aff44ec78eee003c05ccd3068ffb
lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryCompletionListener.java 3713b5156e2cfc20528d9b3b9a6f9b117daeb284
lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryDriverStatusUpdateListener.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/StatusUpdateMethod.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 2641b606faa20943a5f3b9de9b729380a35e8c25
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 59f85691d08e7deb5e3b5892b3ffc729265874d8
lens-server/src/main/java/org/apache/lens/server/LensServerConf.java e977ebd82118307bdbfd20be762a523337da4788
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1752414e89c550c31645f2a2fd686f5b06686a93
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java be1326f62e47c72514039fc6525eeea12ae28456
lens-server/src/test/resources/hive-site.xml 94c5012821330e1a78aad2a7fdfca0cc1d0fade2
Diff: https://reviews.apache.org/r/50600/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 50600: LENS-1243: Support Asynchronous status
updates from drivers
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50600/
-----------------------------------------------------------
(Updated Aug. 22, 2016, 1:17 p.m.)
Review request for lens.
Bugs: LENS-1243
https://issues.apache.org/jira/browse/LENS-1243
Repository: lens
Description
-------
Diffs (updated)
-----
lens-driver-es/src/main/java/org/apache/lens/driver/es/ESDriver.java 8a4f4105ad6ffc75445e5e10a51f6fbd4f5f1d3f
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 1326611d01e7a9b4f58877435f36b1391ca178b2
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 6dff173e26993e40e3cb82622be8173359f92592
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bebb9ae9a4d694f224f0ec907df166880e0cf5b8
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 12fa6f0328242b1bd06ff0397b2f2a3a9dec010d
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java e7636d2e631cf86021af398ee31300441a335096
lens-driver-jdbc/src/test/resources/hive-site.xml b497ca19b14811ecb4474b7f9bf6dec2bdf0b036
lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java f1d844a1987d7f7990b2e10f03d2e3af8e0294e0
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java 2374c1e4b2737a0d1ea7123232800413baa9a560
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 95ea3608e612aff44ec78eee003c05ccd3068ffb
lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryCompletionListener.java 3713b5156e2cfc20528d9b3b9a6f9b117daeb284
lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryDriverStatusUpdateListener.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/StatusUpdateMethod.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 2641b606faa20943a5f3b9de9b729380a35e8c25
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 59f85691d08e7deb5e3b5892b3ffc729265874d8
lens-server/src/main/java/org/apache/lens/server/LensServerConf.java e977ebd82118307bdbfd20be762a523337da4788
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1752414e89c550c31645f2a2fd686f5b06686a93
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java be1326f62e47c72514039fc6525eeea12ae28456
lens-server/src/test/resources/hive-site.xml 94c5012821330e1a78aad2a7fdfca0cc1d0fade2
Diff: https://reviews.apache.org/r/50600/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 50600: LENS-1243: Support Asynchronous status
updates from drivers
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50600/
-----------------------------------------------------------
(Updated Aug. 12, 2016, 1:10 p.m.)
Review request for lens.
Bugs: LENS-1243
https://issues.apache.org/jira/browse/LENS-1243
Repository: lens
Description
-------
Diffs (updated)
-----
lens-driver-es/src/main/java/org/apache/lens/driver/es/ESDriver.java 8a4f4105ad6ffc75445e5e10a51f6fbd4f5f1d3f
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 1326611d01e7a9b4f58877435f36b1391ca178b2
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 6dff173e26993e40e3cb82622be8173359f92592
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bebb9ae9a4d694f224f0ec907df166880e0cf5b8
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 12fa6f0328242b1bd06ff0397b2f2a3a9dec010d
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java e7636d2e631cf86021af398ee31300441a335096
lens-driver-jdbc/src/test/resources/hive-site.xml b497ca19b14811ecb4474b7f9bf6dec2bdf0b036
lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java f1d844a1987d7f7990b2e10f03d2e3af8e0294e0
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java 2374c1e4b2737a0d1ea7123232800413baa9a560
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 95ea3608e612aff44ec78eee003c05ccd3068ffb
lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryCompletionListener.java 3713b5156e2cfc20528d9b3b9a6f9b117daeb284
lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryDriverStatusUpdateListener.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/StatusUpdateMethod.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 2641b606faa20943a5f3b9de9b729380a35e8c25
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 59f85691d08e7deb5e3b5892b3ffc729265874d8
lens-server/src/main/java/org/apache/lens/server/LensServerConf.java e977ebd82118307bdbfd20be762a523337da4788
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1752414e89c550c31645f2a2fd686f5b06686a93
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java be1326f62e47c72514039fc6525eeea12ae28456
lens-server/src/test/resources/hive-site.xml 94c5012821330e1a78aad2a7fdfca0cc1d0fade2
Diff: https://reviews.apache.org/r/50600/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 50600: LENS-1243: Support Asynchronous status
updates from drivers
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On Aug. 10, 2016, 12:53 p.m., Amareshwari Sriramadasu wrote:
> > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java, line 952
> > <https://reviews.apache.org/r/50600/diff/9/?file=1468813#file1468813line952>
> >
> > logSegregationContext no more passed?
It was unused.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50600/#review145316
-----------------------------------------------------------
On Aug. 9, 2016, 6:34 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50600/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2016, 6:34 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1243
> https://issues.apache.org/jira/browse/LENS-1243
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-driver-es/src/main/java/org/apache/lens/driver/es/ESDriver.java 8a4f4105ad6ffc75445e5e10a51f6fbd4f5f1d3f
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 1326611d01e7a9b4f58877435f36b1391ca178b2
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 6dff173e26993e40e3cb82622be8173359f92592
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bebb9ae9a4d694f224f0ec907df166880e0cf5b8
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 12fa6f0328242b1bd06ff0397b2f2a3a9dec010d
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java e7636d2e631cf86021af398ee31300441a335096
> lens-driver-jdbc/src/test/resources/hive-site.xml b497ca19b14811ecb4474b7f9bf6dec2bdf0b036
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java f1d844a1987d7f7990b2e10f03d2e3af8e0294e0
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java 2374c1e4b2737a0d1ea7123232800413baa9a560
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 95ea3608e612aff44ec78eee003c05ccd3068ffb
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryCompletionListener.java 3713b5156e2cfc20528d9b3b9a6f9b117daeb284
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryDriverStatusUpdateListener.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/StatusUpdateMethod.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 2641b606faa20943a5f3b9de9b729380a35e8c25
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 59f85691d08e7deb5e3b5892b3ffc729265874d8
> lens-server/src/main/java/org/apache/lens/server/LensServerConf.java e977ebd82118307bdbfd20be762a523337da4788
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1752414e89c550c31645f2a2fd686f5b06686a93
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java be1326f62e47c72514039fc6525eeea12ae28456
> lens-server/src/test/resources/hive-site.xml 94c5012821330e1a78aad2a7fdfca0cc1d0fade2
>
> Diff: https://reviews.apache.org/r/50600/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 50600: LENS-1243: Support Asynchronous status
updates from drivers
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50600/#review145316
-----------------------------------------------------------
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java (line 882)
<https://reviews.apache.org/r/50600/#comment211508>
logSegregationContext no more passed?
- Amareshwari Sriramadasu
On Aug. 9, 2016, 1:04 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50600/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2016, 1:04 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1243
> https://issues.apache.org/jira/browse/LENS-1243
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-driver-es/src/main/java/org/apache/lens/driver/es/ESDriver.java 8a4f4105ad6ffc75445e5e10a51f6fbd4f5f1d3f
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 1326611d01e7a9b4f58877435f36b1391ca178b2
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 6dff173e26993e40e3cb82622be8173359f92592
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bebb9ae9a4d694f224f0ec907df166880e0cf5b8
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 12fa6f0328242b1bd06ff0397b2f2a3a9dec010d
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java e7636d2e631cf86021af398ee31300441a335096
> lens-driver-jdbc/src/test/resources/hive-site.xml b497ca19b14811ecb4474b7f9bf6dec2bdf0b036
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java f1d844a1987d7f7990b2e10f03d2e3af8e0294e0
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java 2374c1e4b2737a0d1ea7123232800413baa9a560
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 95ea3608e612aff44ec78eee003c05ccd3068ffb
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryCompletionListener.java 3713b5156e2cfc20528d9b3b9a6f9b117daeb284
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryDriverStatusUpdateListener.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/StatusUpdateMethod.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 2641b606faa20943a5f3b9de9b729380a35e8c25
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 59f85691d08e7deb5e3b5892b3ffc729265874d8
> lens-server/src/main/java/org/apache/lens/server/LensServerConf.java e977ebd82118307bdbfd20be762a523337da4788
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1752414e89c550c31645f2a2fd686f5b06686a93
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java be1326f62e47c72514039fc6525eeea12ae28456
> lens-server/src/test/resources/hive-site.xml 94c5012821330e1a78aad2a7fdfca0cc1d0fade2
>
> Diff: https://reviews.apache.org/r/50600/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 50600: LENS-1243: Support Asynchronous status
updates from drivers
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On Aug. 10, 2016, 12:31 p.m., Amareshwari Sriramadasu wrote:
> > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java, line 1044
> > <https://reviews.apache.org/r/50600/diff/9/?file=1468813#file1468813line1044>
> >
> > Is ctx's status not updated upon cancel?
That boolean is removed and merged with enum having a particular value.
> On Aug. 10, 2016, 12:31 p.m., Amareshwari Sriramadasu wrote:
> > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java, line 1089
> > <https://reviews.apache.org/r/50600/diff/9/?file=1468813#file1468813line1089>
> >
> > why are we removing this?
driver end time is being set by the `setDriverStatus` call.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50600/#review145314
-----------------------------------------------------------
On Aug. 9, 2016, 6:34 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50600/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2016, 6:34 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1243
> https://issues.apache.org/jira/browse/LENS-1243
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-driver-es/src/main/java/org/apache/lens/driver/es/ESDriver.java 8a4f4105ad6ffc75445e5e10a51f6fbd4f5f1d3f
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 1326611d01e7a9b4f58877435f36b1391ca178b2
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 6dff173e26993e40e3cb82622be8173359f92592
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bebb9ae9a4d694f224f0ec907df166880e0cf5b8
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 12fa6f0328242b1bd06ff0397b2f2a3a9dec010d
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java e7636d2e631cf86021af398ee31300441a335096
> lens-driver-jdbc/src/test/resources/hive-site.xml b497ca19b14811ecb4474b7f9bf6dec2bdf0b036
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java f1d844a1987d7f7990b2e10f03d2e3af8e0294e0
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java 2374c1e4b2737a0d1ea7123232800413baa9a560
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 95ea3608e612aff44ec78eee003c05ccd3068ffb
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryCompletionListener.java 3713b5156e2cfc20528d9b3b9a6f9b117daeb284
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryDriverStatusUpdateListener.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/StatusUpdateMethod.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 2641b606faa20943a5f3b9de9b729380a35e8c25
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 59f85691d08e7deb5e3b5892b3ffc729265874d8
> lens-server/src/main/java/org/apache/lens/server/LensServerConf.java e977ebd82118307bdbfd20be762a523337da4788
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1752414e89c550c31645f2a2fd686f5b06686a93
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java be1326f62e47c72514039fc6525eeea12ae28456
> lens-server/src/test/resources/hive-site.xml 94c5012821330e1a78aad2a7fdfca0cc1d0fade2
>
> Diff: https://reviews.apache.org/r/50600/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 50600: LENS-1243: Support Asynchronous status
updates from drivers
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50600/#review145314
-----------------------------------------------------------
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java (line 954)
<https://reviews.apache.org/r/50600/#comment211503>
Is ctx's status not updated upon cancel?
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java
<https://reviews.apache.org/r/50600/#comment211502>
why are we removing this?
- Amareshwari Sriramadasu
On Aug. 9, 2016, 1:04 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50600/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2016, 1:04 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1243
> https://issues.apache.org/jira/browse/LENS-1243
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-driver-es/src/main/java/org/apache/lens/driver/es/ESDriver.java 8a4f4105ad6ffc75445e5e10a51f6fbd4f5f1d3f
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 1326611d01e7a9b4f58877435f36b1391ca178b2
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 6dff173e26993e40e3cb82622be8173359f92592
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bebb9ae9a4d694f224f0ec907df166880e0cf5b8
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 12fa6f0328242b1bd06ff0397b2f2a3a9dec010d
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java e7636d2e631cf86021af398ee31300441a335096
> lens-driver-jdbc/src/test/resources/hive-site.xml b497ca19b14811ecb4474b7f9bf6dec2bdf0b036
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java f1d844a1987d7f7990b2e10f03d2e3af8e0294e0
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java 2374c1e4b2737a0d1ea7123232800413baa9a560
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 95ea3608e612aff44ec78eee003c05ccd3068ffb
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryCompletionListener.java 3713b5156e2cfc20528d9b3b9a6f9b117daeb284
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryDriverStatusUpdateListener.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/StatusUpdateMethod.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 2641b606faa20943a5f3b9de9b729380a35e8c25
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 59f85691d08e7deb5e3b5892b3ffc729265874d8
> lens-server/src/main/java/org/apache/lens/server/LensServerConf.java e977ebd82118307bdbfd20be762a523337da4788
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1752414e89c550c31645f2a2fd686f5b06686a93
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java be1326f62e47c72514039fc6525eeea12ae28456
> lens-server/src/test/resources/hive-site.xml 94c5012821330e1a78aad2a7fdfca0cc1d0fade2
>
> Diff: https://reviews.apache.org/r/50600/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 50600: LENS-1243: Support Asynchronous status
updates from drivers
Posted by Rajat Khandelwal <ra...@gmail.com>.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50600/#review145315
-----------------------------------------------------------
On Aug. 22, 2016, 1:17 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50600/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2016, 1:17 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1243
> https://issues.apache.org/jira/browse/LENS-1243
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-driver-es/src/main/java/org/apache/lens/driver/es/ESDriver.java 8a4f4105ad6ffc75445e5e10a51f6fbd4f5f1d3f
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 1326611d01e7a9b4f58877435f36b1391ca178b2
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 6dff173e26993e40e3cb82622be8173359f92592
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bebb9ae9a4d694f224f0ec907df166880e0cf5b8
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 12fa6f0328242b1bd06ff0397b2f2a3a9dec010d
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java e7636d2e631cf86021af398ee31300441a335096
> lens-driver-jdbc/src/test/resources/hive-site.xml b497ca19b14811ecb4474b7f9bf6dec2bdf0b036
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java f1d844a1987d7f7990b2e10f03d2e3af8e0294e0
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java 2374c1e4b2737a0d1ea7123232800413baa9a560
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 95ea3608e612aff44ec78eee003c05ccd3068ffb
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryCompletionListener.java 3713b5156e2cfc20528d9b3b9a6f9b117daeb284
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryDriverStatusUpdateListener.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/StatusUpdateMethod.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 2641b606faa20943a5f3b9de9b729380a35e8c25
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 59f85691d08e7deb5e3b5892b3ffc729265874d8
> lens-server/src/main/java/org/apache/lens/server/LensServerConf.java e977ebd82118307bdbfd20be762a523337da4788
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1752414e89c550c31645f2a2fd686f5b06686a93
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java be1326f62e47c72514039fc6525eeea12ae28456
> lens-server/src/test/resources/hive-site.xml 94c5012821330e1a78aad2a7fdfca0cc1d0fade2
>
> Diff: https://reviews.apache.org/r/50600/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 50600: LENS-1243: Support Asynchronous status
updates from drivers
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On Aug. 10, 2016, 7:21 a.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryCompletionListener.java, line 56
> > <https://reviews.apache.org/r/50600/diff/9/?file=1468820#file1468820line56>
> >
> > no cancel here?
>
> Rajat Khandelwal wrote:
> I don't think we need that here. This is implementing Completion Listener using Status Update listener. We only need to handle success and failure scenarios. Am I missing something?
Ok. I would say completion listener should also have a onCancel(). But can be done in a separate issue, as it does not exist right now.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50600/#review145315
-----------------------------------------------------------
On Aug. 12, 2016, 7:40 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50600/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2016, 7:40 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1243
> https://issues.apache.org/jira/browse/LENS-1243
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-driver-es/src/main/java/org/apache/lens/driver/es/ESDriver.java 8a4f4105ad6ffc75445e5e10a51f6fbd4f5f1d3f
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 1326611d01e7a9b4f58877435f36b1391ca178b2
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 6dff173e26993e40e3cb82622be8173359f92592
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bebb9ae9a4d694f224f0ec907df166880e0cf5b8
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 12fa6f0328242b1bd06ff0397b2f2a3a9dec010d
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java e7636d2e631cf86021af398ee31300441a335096
> lens-driver-jdbc/src/test/resources/hive-site.xml b497ca19b14811ecb4474b7f9bf6dec2bdf0b036
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java f1d844a1987d7f7990b2e10f03d2e3af8e0294e0
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java 2374c1e4b2737a0d1ea7123232800413baa9a560
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 95ea3608e612aff44ec78eee003c05ccd3068ffb
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryCompletionListener.java 3713b5156e2cfc20528d9b3b9a6f9b117daeb284
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryDriverStatusUpdateListener.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/StatusUpdateMethod.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 2641b606faa20943a5f3b9de9b729380a35e8c25
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 59f85691d08e7deb5e3b5892b3ffc729265874d8
> lens-server/src/main/java/org/apache/lens/server/LensServerConf.java e977ebd82118307bdbfd20be762a523337da4788
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1752414e89c550c31645f2a2fd686f5b06686a93
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java be1326f62e47c72514039fc6525eeea12ae28456
> lens-server/src/test/resources/hive-site.xml 94c5012821330e1a78aad2a7fdfca0cc1d0fade2
>
> Diff: https://reviews.apache.org/r/50600/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 50600: LENS-1243: Support Asynchronous status
updates from drivers
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On Aug. 10, 2016, 12:51 p.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java, line 1047
> > <https://reviews.apache.org/r/50600/diff/9/?file=1468827#file1468827line1047>
> >
> > why is this change done?
>
> Rajat Khandelwal wrote:
> Not sure why we're not seeing this in master, but I was seeing an error. The flow is the following:
>
> 1. create dimension
> 2. create dimtable
> 1. create
> 2. get dimtable
> 3. get latest partition -> time dim is null, so error.
Possibly because master depends on hive 2.1.0 and I'm depending on development version in hive 2.1 branch.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50600/#review145315
-----------------------------------------------------------
On Aug. 22, 2016, 1:17 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50600/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2016, 1:17 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1243
> https://issues.apache.org/jira/browse/LENS-1243
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-driver-es/src/main/java/org/apache/lens/driver/es/ESDriver.java 8a4f4105ad6ffc75445e5e10a51f6fbd4f5f1d3f
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 1326611d01e7a9b4f58877435f36b1391ca178b2
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 6dff173e26993e40e3cb82622be8173359f92592
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bebb9ae9a4d694f224f0ec907df166880e0cf5b8
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 12fa6f0328242b1bd06ff0397b2f2a3a9dec010d
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java e7636d2e631cf86021af398ee31300441a335096
> lens-driver-jdbc/src/test/resources/hive-site.xml b497ca19b14811ecb4474b7f9bf6dec2bdf0b036
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java f1d844a1987d7f7990b2e10f03d2e3af8e0294e0
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java 2374c1e4b2737a0d1ea7123232800413baa9a560
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 95ea3608e612aff44ec78eee003c05ccd3068ffb
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryCompletionListener.java 3713b5156e2cfc20528d9b3b9a6f9b117daeb284
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryDriverStatusUpdateListener.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/StatusUpdateMethod.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 2641b606faa20943a5f3b9de9b729380a35e8c25
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 59f85691d08e7deb5e3b5892b3ffc729265874d8
> lens-server/src/main/java/org/apache/lens/server/LensServerConf.java e977ebd82118307bdbfd20be762a523337da4788
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1752414e89c550c31645f2a2fd686f5b06686a93
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java be1326f62e47c72514039fc6525eeea12ae28456
> lens-server/src/test/resources/hive-site.xml 94c5012821330e1a78aad2a7fdfca0cc1d0fade2
>
> Diff: https://reviews.apache.org/r/50600/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 50600: LENS-1243: Support Asynchronous status
updates from drivers
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On Aug. 10, 2016, 12:51 p.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryCompletionListener.java, line 56
> > <https://reviews.apache.org/r/50600/diff/9/?file=1468820#file1468820line56>
> >
> > no cancel here?
I don't think we need that here. This is implementing Completion Listener using Status Update listener. We only need to handle success and failure scenarios. Am I missing something?
> On Aug. 10, 2016, 12:51 p.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java, line 572
> > <https://reviews.apache.org/r/50600/diff/9/?file=1468823#file1468823line572>
> >
> > Shouldnt query context update its own status also once driver status is updated?
> >
> > When does QueryContext's status get updated in this flow?
QueryService adds an Async status updater as an observer of this. So this call then notifies all the observers, including the async status updater, which then updates QueryContext's status.
> On Aug. 10, 2016, 12:51 p.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java, line 580
> > <https://reviews.apache.org/r/50600/diff/9/?file=1468823#file1468823line580>
> >
> > Who are the callers of this? why is the argument null?
Most of the places, the status message is just "Query is successful/failed/canceled/...". `null` here means that status message will be derived based on the status enum value.
> On Aug. 10, 2016, 12:51 p.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java, line 1047
> > <https://reviews.apache.org/r/50600/diff/9/?file=1468827#file1468827line1047>
> >
> > why is this change done?
Not sure why we're not seeing this in master, but I was seeing an error. The flow is the following:
1. create dimension
2. create dimtable
1. create
2. get dimtable
3. get latest partition -> time dim is null, so error.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50600/#review145315
-----------------------------------------------------------
On Aug. 9, 2016, 6:34 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50600/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2016, 6:34 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1243
> https://issues.apache.org/jira/browse/LENS-1243
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-driver-es/src/main/java/org/apache/lens/driver/es/ESDriver.java 8a4f4105ad6ffc75445e5e10a51f6fbd4f5f1d3f
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 1326611d01e7a9b4f58877435f36b1391ca178b2
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 6dff173e26993e40e3cb82622be8173359f92592
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bebb9ae9a4d694f224f0ec907df166880e0cf5b8
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 12fa6f0328242b1bd06ff0397b2f2a3a9dec010d
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java e7636d2e631cf86021af398ee31300441a335096
> lens-driver-jdbc/src/test/resources/hive-site.xml b497ca19b14811ecb4474b7f9bf6dec2bdf0b036
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java f1d844a1987d7f7990b2e10f03d2e3af8e0294e0
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java 2374c1e4b2737a0d1ea7123232800413baa9a560
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 95ea3608e612aff44ec78eee003c05ccd3068ffb
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryCompletionListener.java 3713b5156e2cfc20528d9b3b9a6f9b117daeb284
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryDriverStatusUpdateListener.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/StatusUpdateMethod.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 2641b606faa20943a5f3b9de9b729380a35e8c25
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 59f85691d08e7deb5e3b5892b3ffc729265874d8
> lens-server/src/main/java/org/apache/lens/server/LensServerConf.java e977ebd82118307bdbfd20be762a523337da4788
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1752414e89c550c31645f2a2fd686f5b06686a93
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java be1326f62e47c72514039fc6525eeea12ae28456
> lens-server/src/test/resources/hive-site.xml 94c5012821330e1a78aad2a7fdfca0cc1d0fade2
>
> Diff: https://reviews.apache.org/r/50600/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 50600: LENS-1243: Support Asynchronous status
updates from drivers
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50600/#review145315
-----------------------------------------------------------
lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryCompletionListener.java (line 55)
<https://reviews.apache.org/r/50600/#comment211504>
no cancel here?
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java (line 562)
<https://reviews.apache.org/r/50600/#comment211505>
Shouldnt query context update its own status also once driver status is updated?
When does QueryContext's status get updated in this flow?
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java (line 570)
<https://reviews.apache.org/r/50600/#comment211507>
Who are the callers of this? why is the argument null?
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java (line 1047)
<https://reviews.apache.org/r/50600/#comment211506>
why is this change done?
- Amareshwari Sriramadasu
On Aug. 9, 2016, 1:04 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50600/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2016, 1:04 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1243
> https://issues.apache.org/jira/browse/LENS-1243
>
>
> Repository: lens
>
>
> Description
> -------
>
>
> Diffs
> -----
>
> lens-driver-es/src/main/java/org/apache/lens/driver/es/ESDriver.java 8a4f4105ad6ffc75445e5e10a51f6fbd4f5f1d3f
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 1326611d01e7a9b4f58877435f36b1391ca178b2
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 6dff173e26993e40e3cb82622be8173359f92592
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bebb9ae9a4d694f224f0ec907df166880e0cf5b8
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 12fa6f0328242b1bd06ff0397b2f2a3a9dec010d
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java e7636d2e631cf86021af398ee31300441a335096
> lens-driver-jdbc/src/test/resources/hive-site.xml b497ca19b14811ecb4474b7f9bf6dec2bdf0b036
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java f1d844a1987d7f7990b2e10f03d2e3af8e0294e0
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java 2374c1e4b2737a0d1ea7123232800413baa9a560
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 95ea3608e612aff44ec78eee003c05ccd3068ffb
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryCompletionListener.java 3713b5156e2cfc20528d9b3b9a6f9b117daeb284
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryDriverStatusUpdateListener.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/StatusUpdateMethod.java PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 2641b606faa20943a5f3b9de9b729380a35e8c25
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 59f85691d08e7deb5e3b5892b3ffc729265874d8
> lens-server/src/main/java/org/apache/lens/server/LensServerConf.java e977ebd82118307bdbfd20be762a523337da4788
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1752414e89c550c31645f2a2fd686f5b06686a93
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java be1326f62e47c72514039fc6525eeea12ae28456
> lens-server/src/test/resources/hive-site.xml 94c5012821330e1a78aad2a7fdfca0cc1d0fade2
>
> Diff: https://reviews.apache.org/r/50600/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 50600: LENS-1243: Support Asynchronous status
updates from drivers
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50600/
-----------------------------------------------------------
(Updated Aug. 9, 2016, 6:34 p.m.)
Review request for lens.
Bugs: LENS-1243
https://issues.apache.org/jira/browse/LENS-1243
Repository: lens
Description
-------
Diffs (updated)
-----
lens-driver-es/src/main/java/org/apache/lens/driver/es/ESDriver.java 8a4f4105ad6ffc75445e5e10a51f6fbd4f5f1d3f
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 1326611d01e7a9b4f58877435f36b1391ca178b2
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 6dff173e26993e40e3cb82622be8173359f92592
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bebb9ae9a4d694f224f0ec907df166880e0cf5b8
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 12fa6f0328242b1bd06ff0397b2f2a3a9dec010d
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java e7636d2e631cf86021af398ee31300441a335096
lens-driver-jdbc/src/test/resources/hive-site.xml b497ca19b14811ecb4474b7f9bf6dec2bdf0b036
lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java f1d844a1987d7f7990b2e10f03d2e3af8e0294e0
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java 2374c1e4b2737a0d1ea7123232800413baa9a560
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 95ea3608e612aff44ec78eee003c05ccd3068ffb
lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryCompletionListener.java 3713b5156e2cfc20528d9b3b9a6f9b117daeb284
lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryDriverStatusUpdateListener.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/StatusUpdateMethod.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 2641b606faa20943a5f3b9de9b729380a35e8c25
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 59f85691d08e7deb5e3b5892b3ffc729265874d8
lens-server/src/main/java/org/apache/lens/server/LensServerConf.java e977ebd82118307bdbfd20be762a523337da4788
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1752414e89c550c31645f2a2fd686f5b06686a93
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java be1326f62e47c72514039fc6525eeea12ae28456
lens-server/src/test/resources/hive-site.xml 94c5012821330e1a78aad2a7fdfca0cc1d0fade2
Diff: https://reviews.apache.org/r/50600/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 50600: LENS-1243: Support Asynchronous status
updates from drivers
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50600/
-----------------------------------------------------------
(Updated Aug. 8, 2016, 6:35 p.m.)
Review request for lens.
Bugs: LENS-1243
https://issues.apache.org/jira/browse/LENS-1243
Repository: lens
Description
-------
Diffs (updated)
-----
lens-driver-es/src/main/java/org/apache/lens/driver/es/ESDriver.java 8a4f4105ad6ffc75445e5e10a51f6fbd4f5f1d3f
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 1326611d01e7a9b4f58877435f36b1391ca178b2
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 6dff173e26993e40e3cb82622be8173359f92592
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bebb9ae9a4d694f224f0ec907df166880e0cf5b8
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 12fa6f0328242b1bd06ff0397b2f2a3a9dec010d
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java e7636d2e631cf86021af398ee31300441a335096
lens-driver-jdbc/src/test/resources/hive-site.xml b497ca19b14811ecb4474b7f9bf6dec2bdf0b036
lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java f1d844a1987d7f7990b2e10f03d2e3af8e0294e0
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java 2374c1e4b2737a0d1ea7123232800413baa9a560
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 95ea3608e612aff44ec78eee003c05ccd3068ffb
lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryCompletionListener.java 3713b5156e2cfc20528d9b3b9a6f9b117daeb284
lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryDriverStatusUpdateListener.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/StatusUpdateMethod.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 2641b606faa20943a5f3b9de9b729380a35e8c25
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 59f85691d08e7deb5e3b5892b3ffc729265874d8
lens-server/src/main/java/org/apache/lens/server/LensServerConf.java e977ebd82118307bdbfd20be762a523337da4788
lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java 47159b568e9eff2f39ede9839f278441f0305d1f
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1752414e89c550c31645f2a2fd686f5b06686a93
lens-server/src/test/resources/hive-site.xml 94c5012821330e1a78aad2a7fdfca0cc1d0fade2
Diff: https://reviews.apache.org/r/50600/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 50600: LENS-1243: Support Asynchronous status
updates from drivers
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50600/
-----------------------------------------------------------
(Updated Aug. 4, 2016, 6:30 p.m.)
Review request for lens.
Bugs: LENS-1243
https://issues.apache.org/jira/browse/LENS-1243
Repository: lens
Description
-------
Diffs (updated)
-----
lens-driver-es/src/main/java/org/apache/lens/driver/es/ESDriver.java 8a4f4105ad6ffc75445e5e10a51f6fbd4f5f1d3f
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 1326611d01e7a9b4f58877435f36b1391ca178b2
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 6dff173e26993e40e3cb82622be8173359f92592
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bebb9ae9a4d694f224f0ec907df166880e0cf5b8
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 12fa6f0328242b1bd06ff0397b2f2a3a9dec010d
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java e7636d2e631cf86021af398ee31300441a335096
lens-driver-jdbc/src/test/resources/hive-site.xml b497ca19b14811ecb4474b7f9bf6dec2bdf0b036
lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java f1d844a1987d7f7990b2e10f03d2e3af8e0294e0
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java 2374c1e4b2737a0d1ea7123232800413baa9a560
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 95ea3608e612aff44ec78eee003c05ccd3068ffb
lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryCompletionListener.java 3713b5156e2cfc20528d9b3b9a6f9b117daeb284
lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryDriverStatusUpdateListener.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/StatusUpdateMethod.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 2641b606faa20943a5f3b9de9b729380a35e8c25
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 59f85691d08e7deb5e3b5892b3ffc729265874d8
lens-server/src/main/java/org/apache/lens/server/LensServerConf.java e977ebd82118307bdbfd20be762a523337da4788
lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java 47159b568e9eff2f39ede9839f278441f0305d1f
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 84dcecda0970d2756a943522a5876117daa71409
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 9f40a014bebdfc6f0ff7ea3d7a21baacc890018d
lens-server/src/test/resources/hive-site.xml 94c5012821330e1a78aad2a7fdfca0cc1d0fade2
Diff: https://reviews.apache.org/r/50600/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 50600: LENS-1243: Support Asynchronous status
updates from drivers
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50600/
-----------------------------------------------------------
(Updated Aug. 3, 2016, 2:28 p.m.)
Review request for lens.
Bugs: LENS-1243
https://issues.apache.org/jira/browse/LENS-1243
Repository: lens
Description
-------
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRangeWriter.java 08f957e0820ac507dce1855430887b5caa0e3586
lens-driver-es/src/main/java/org/apache/lens/driver/es/ESDriver.java 8a4f4105ad6ffc75445e5e10a51f6fbd4f5f1d3f
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 1326611d01e7a9b4f58877435f36b1391ca178b2
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 6dff173e26993e40e3cb82622be8173359f92592
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java bebb9ae9a4d694f224f0ec907df166880e0cf5b8
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 12fa6f0328242b1bd06ff0397b2f2a3a9dec010d
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java e7636d2e631cf86021af398ee31300441a335096
lens-driver-jdbc/src/test/resources/hive-site.xml b497ca19b14811ecb4474b7f9bf6dec2bdf0b036
lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java f1d844a1987d7f7990b2e10f03d2e3af8e0294e0
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java 2374c1e4b2737a0d1ea7123232800413baa9a560
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 95ea3608e612aff44ec78eee003c05ccd3068ffb
lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryCompletionListener.java 3713b5156e2cfc20528d9b3b9a6f9b117daeb284
lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryDriverStatusUpdateListener.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/StatusUpdateMethod.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java e160f58bfb45cffb05b9f6be19db3bc7605dde57
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 2641b606faa20943a5f3b9de9b729380a35e8c25
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 59f85691d08e7deb5e3b5892b3ffc729265874d8
lens-server/src/main/java/org/apache/lens/server/LensServerConf.java e977ebd82118307bdbfd20be762a523337da4788
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 84dcecda0970d2756a943522a5876117daa71409
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 9f40a014bebdfc6f0ff7ea3d7a21baacc890018d
lens-server/src/test/resources/hive-site.xml 94c5012821330e1a78aad2a7fdfca0cc1d0fade2
Diff: https://reviews.apache.org/r/50600/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 50600: LENS-1243: Support Asynchronous status
updates from drivers
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50600/
-----------------------------------------------------------
(Updated Aug. 1, 2016, 4:34 p.m.)
Review request for lens.
Bugs: LENS-1243
https://issues.apache.org/jira/browse/LENS-1243
Repository: lens
Description
-------
Diffs (updated)
-----
lens-driver-es/src/main/java/org/apache/lens/driver/es/ESDriver.java 8a4f4105ad6ffc75445e5e10a51f6fbd4f5f1d3f
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 1326611d01e7a9b4f58877435f36b1391ca178b2
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 6dff173e26993e40e3cb82622be8173359f92592
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 15a182629b04e22031d94373a058c9f06b2508d3
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java e7636d2e631cf86021af398ee31300441a335096
lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java f1d844a1987d7f7990b2e10f03d2e3af8e0294e0
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java 2374c1e4b2737a0d1ea7123232800413baa9a560
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 95ea3608e612aff44ec78eee003c05ccd3068ffb
lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryCompletionListener.java 3713b5156e2cfc20528d9b3b9a6f9b117daeb284
lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryDriverStatusUpdateListener.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/StatusUpdateMethod.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java e160f58bfb45cffb05b9f6be19db3bc7605dde57
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 2641b606faa20943a5f3b9de9b729380a35e8c25
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 59f85691d08e7deb5e3b5892b3ffc729265874d8
lens-server/src/main/java/org/apache/lens/server/LensServerConf.java e977ebd82118307bdbfd20be762a523337da4788
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 84dcecda0970d2756a943522a5876117daa71409
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 9f40a014bebdfc6f0ff7ea3d7a21baacc890018d
pom.xml f7ebee600c1f33ef29e71861f961506f841d2523
Diff: https://reviews.apache.org/r/50600/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 50600: LENS-1243: Support Asynchronous status
updates from drivers
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50600/
-----------------------------------------------------------
(Updated Aug. 1, 2016, 4:33 p.m.)
Review request for lens.
Bugs: LENS-1243
https://issues.apache.org/jira/browse/LENS-1243
Repository: lens
Description
-------
Diffs (updated)
-----
lens-driver-es/src/main/java/org/apache/lens/driver/es/ESDriver.java 8a4f4105ad6ffc75445e5e10a51f6fbd4f5f1d3f
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 1326611d01e7a9b4f58877435f36b1391ca178b2
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 6dff173e26993e40e3cb82622be8173359f92592
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 15a182629b04e22031d94373a058c9f06b2508d3
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java e7636d2e631cf86021af398ee31300441a335096
lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java f1d844a1987d7f7990b2e10f03d2e3af8e0294e0
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java 2374c1e4b2737a0d1ea7123232800413baa9a560
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 95ea3608e612aff44ec78eee003c05ccd3068ffb
lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryCompletionListener.java 3713b5156e2cfc20528d9b3b9a6f9b117daeb284
lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryDriverStatusUpdateListener.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/StatusUpdateMethod.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java e160f58bfb45cffb05b9f6be19db3bc7605dde57
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 2641b606faa20943a5f3b9de9b729380a35e8c25
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 59f85691d08e7deb5e3b5892b3ffc729265874d8
lens-server/src/main/java/org/apache/lens/server/LensServerConf.java e977ebd82118307bdbfd20be762a523337da4788
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 84dcecda0970d2756a943522a5876117daa71409
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 9f40a014bebdfc6f0ff7ea3d7a21baacc890018d
pom.xml f7ebee600c1f33ef29e71861f961506f841d2523
Diff: https://reviews.apache.org/r/50600/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 50600: LENS-1243: Support Asynchronous status
updates from drivers
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50600/
-----------------------------------------------------------
(Updated Aug. 1, 2016, 4:28 p.m.)
Review request for lens.
Bugs: LENS-1243
https://issues.apache.org/jira/browse/LENS-1243
Repository: lens
Description
-------
Diffs (updated)
-----
lens-driver-es/src/main/java/org/apache/lens/driver/es/ESDriver.java 8a4f4105ad6ffc75445e5e10a51f6fbd4f5f1d3f
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 1326611d01e7a9b4f58877435f36b1391ca178b2
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 6dff173e26993e40e3cb82622be8173359f92592
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 15a182629b04e22031d94373a058c9f06b2508d3
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java e7636d2e631cf86021af398ee31300441a335096
lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java f1d844a1987d7f7990b2e10f03d2e3af8e0294e0
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java 2374c1e4b2737a0d1ea7123232800413baa9a560
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 95ea3608e612aff44ec78eee003c05ccd3068ffb
lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryDriverStatusUpdateListener.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/StatusUpdateMethod.java PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java e160f58bfb45cffb05b9f6be19db3bc7605dde57
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 2641b606faa20943a5f3b9de9b729380a35e8c25
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 59f85691d08e7deb5e3b5892b3ffc729265874d8
lens-server/src/main/java/org/apache/lens/server/LensServerConf.java e977ebd82118307bdbfd20be762a523337da4788
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 84dcecda0970d2756a943522a5876117daa71409
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 9f40a014bebdfc6f0ff7ea3d7a21baacc890018d
pom.xml f7ebee600c1f33ef29e71861f961506f841d2523
Diff: https://reviews.apache.org/r/50600/diff/
Testing
-------
Thanks,
Rajat Khandelwal