You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@camel.apache.org by "Stephen Saucier (Created) (JIRA)" <ji...@apache.org> on 2012/01/16 20:29:48 UTC

[jira] [Created] (CAMEL-4904) org.apache.camel.util.concurrent.ExecutorServiceHelper.getThreadName(String, String) method throws IllegalArgumentException when name parameter contains '$', "

org.apache.camel.util.concurrent.ExecutorServiceHelper.getThreadName(String, String) method throws IllegalArgumentException when name parameter contains '$', "
---------------------------------------------------------------------------------------------------------------------------------------------------------------

                 Key: CAMEL-4904
                 URL: https://issues.apache.org/jira/browse/CAMEL-4904
             Project: Camel
          Issue Type: Bug
            Reporter: Stephen Saucier




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CAMEL-4904) org.apache.camel.util.concurrent.ExecutorServiceHelper.getThreadName(String, String) method throws IllegalArgumentException when name parameter contains '$', "${" or '}'

Posted by "Stephen Saucier (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-4904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247319#comment-13247319 ] 

Stephen Saucier commented on CAMEL-4904:
----------------------------------------

Could you please check again the links I posted previously? The code that is included in 2.8.4 and 2.9.1 does not quote the replacement, and still exhibits the issue as it is still checking after the replacement that that string does not contain a '}' character which my name does. This is working in trunk due to the use of a regular expression (and the fact that '#' is being used as the delimiter for placeholders, which are not contained in my particular names).
                
> org.apache.camel.util.concurrent.ExecutorServiceHelper.getThreadName(String, String) method throws IllegalArgumentException when name parameter contains '$', "${" or '}'
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-4904
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4904
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-core
>    Affects Versions: 2.8.3, 2.9.0
>            Reporter: Stephen Saucier
>            Assignee: Claus Ibsen
>            Priority: Minor
>             Fix For: 2.8.4, 2.9.1
>
>
> When the "name" parameter contains a '$', "${" or '}' substring, the getThreadName method will throw an erroneous IllegalArgumentException.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CAMEL-4904) org.apache.camel.util.concurrent.ExecutorServiceHelper.getThreadName(String, String) method throws IllegalArgumentException when name parameter contains '$', "${" or '}'

Posted by "Claus Ibsen (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-4904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247376#comment-13247376 ] 

Claus Ibsen commented on CAMEL-4904:
------------------------------------

Then I suggest to not use { } in your thread names. Its very unusual.
                
> org.apache.camel.util.concurrent.ExecutorServiceHelper.getThreadName(String, String) method throws IllegalArgumentException when name parameter contains '$', "${" or '}'
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-4904
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4904
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-core
>    Affects Versions: 2.8.3, 2.9.0
>            Reporter: Stephen Saucier
>            Assignee: Claus Ibsen
>            Priority: Minor
>             Fix For: 2.8.4, 2.9.1
>
>
> When the "name" parameter contains a '$', "${" or '}' substring, the getThreadName method will throw an erroneous IllegalArgumentException.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CAMEL-4904) org.apache.camel.util.concurrent.ExecutorServiceHelper.getThreadName(String, String) method throws IllegalArgumentException when name parameter contains '$', "${" or '}'

Posted by "Babak Vahdat (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-4904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187658#comment-13187658 ] 

Babak Vahdat commented on CAMEL-4904:
-------------------------------------

fair enough :-)
                
> org.apache.camel.util.concurrent.ExecutorServiceHelper.getThreadName(String, String) method throws IllegalArgumentException when name parameter contains '$', "${" or '}'
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-4904
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4904
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-core
>    Affects Versions: 2.8.3, 2.9.0
>            Reporter: Stephen Saucier
>            Assignee: Claus Ibsen
>            Priority: Minor
>             Fix For: 2.8.4, 2.9.1
>
>
> When the "name" parameter contains a '$', "${" or '}' substring, the getThreadName method will throw an erroneous IllegalArgumentException.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CAMEL-4904) org.apache.camel.util.concurrent.ExecutorServiceHelper.getThreadName(String, String) method throws IllegalArgumentException when name parameter contains '$', "${" or '}'

Posted by "Stephen Saucier (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-4904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stephen Saucier updated CAMEL-4904:
-----------------------------------

             Component/s: camel-core
             Description: When the "name" parameter contains a '$', "${" or '}' substring, the getThreadName method will throw an erroneous IllegalArgumentException.
                Priority: Minor  (was: Major)
    Estimated Complexity: Novice  (was: Unknown)
                 Summary: org.apache.camel.util.concurrent.ExecutorServiceHelper.getThreadName(String, String) method throws IllegalArgumentException when name parameter contains '$', "${" or '}'  (was: org.apache.camel.util.concurrent.ExecutorServiceHelper.getThreadName(String, String) method throws IllegalArgumentException when name parameter contains '$', ")
    
> org.apache.camel.util.concurrent.ExecutorServiceHelper.getThreadName(String, String) method throws IllegalArgumentException when name parameter contains '$', "${" or '}'
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-4904
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4904
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-core
>            Reporter: Stephen Saucier
>            Priority: Minor
>
> When the "name" parameter contains a '$', "${" or '}' substring, the getThreadName method will throw an erroneous IllegalArgumentException.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CAMEL-4904) org.apache.camel.util.concurrent.ExecutorServiceHelper.getThreadName(String, String) method throws IllegalArgumentException when name parameter contains '$', "${" or '}'

Posted by "Claus Ibsen (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-4904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187481#comment-13187481 ] 

Claus Ibsen commented on CAMEL-4904:
------------------------------------

Thanks for reporting. I fixed that on trunk yesterday with CAMEL-4903.
Will have to manually backport a fix, for the older branches as the trunk changed. Basically you need to quote the names, so the replace works.
                
> org.apache.camel.util.concurrent.ExecutorServiceHelper.getThreadName(String, String) method throws IllegalArgumentException when name parameter contains '$', "${" or '}'
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-4904
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4904
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-core
>    Affects Versions: 2.8.3, 2.9.0
>            Reporter: Stephen Saucier
>            Priority: Minor
>             Fix For: 2.8.4, 2.9.1
>
>
> When the "name" parameter contains a '$', "${" or '}' substring, the getThreadName method will throw an erroneous IllegalArgumentException.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (CAMEL-4904) org.apache.camel.util.concurrent.ExecutorServiceHelper.getThreadName(String, String) method throws IllegalArgumentException when name parameter contains '$', "${" or '}'

Posted by "Claus Ibsen (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-4904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen resolved CAMEL-4904.
--------------------------------

    Resolution: Fixed

Fixed on 2.8 branch as well.
                
> org.apache.camel.util.concurrent.ExecutorServiceHelper.getThreadName(String, String) method throws IllegalArgumentException when name parameter contains '$', "${" or '}'
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-4904
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4904
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-core
>    Affects Versions: 2.8.3, 2.9.0
>            Reporter: Stephen Saucier
>            Assignee: Claus Ibsen
>            Priority: Minor
>             Fix For: 2.8.4, 2.9.1
>
>
> When the "name" parameter contains a '$', "${" or '}' substring, the getThreadName method will throw an erroneous IllegalArgumentException.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CAMEL-4904) org.apache.camel.util.concurrent.ExecutorServiceHelper.getThreadName(String, String) method throws IllegalArgumentException when name parameter contains '$', "${" or '}'

Posted by "Babak Vahdat (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-4904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187527#comment-13187527 ] 

Babak Vahdat commented on CAMEL-4904:
-------------------------------------

Claus not that much important at all but I commented a svn-typo by CAMEL-4903 
                
> org.apache.camel.util.concurrent.ExecutorServiceHelper.getThreadName(String, String) method throws IllegalArgumentException when name parameter contains '$', "${" or '}'
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-4904
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4904
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-core
>    Affects Versions: 2.8.3, 2.9.0
>            Reporter: Stephen Saucier
>            Assignee: Claus Ibsen
>            Priority: Minor
>             Fix For: 2.8.4, 2.9.1
>
>
> When the "name" parameter contains a '$', "${" or '}' substring, the getThreadName method will throw an erroneous IllegalArgumentException.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CAMEL-4904) org.apache.camel.util.concurrent.ExecutorServiceHelper.getThreadName(String, String) method throws IllegalArgumentException when name parameter contains '$', "${" or '}'

Posted by "Claus Ibsen (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-4904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247064#comment-13247064 ] 

Claus Ibsen commented on CAMEL-4904:
------------------------------------


The fix works fine as we use this quote the matcher before using
{code}

    // must quote the names to have it work as literal replacement
        shortName = Matcher.quoteReplacement(shortName);
        longName = Matcher.quoteReplacement(longName);
{code}

However note that the syntax in Camel 2.10 has changed to use # instead of $ as tokens. This avoids any confusions with property placeholders, simple language etc. The 2.9 and older releases uses the $ to not break compatibility.
                
> org.apache.camel.util.concurrent.ExecutorServiceHelper.getThreadName(String, String) method throws IllegalArgumentException when name parameter contains '$', "${" or '}'
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-4904
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4904
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-core
>    Affects Versions: 2.8.3, 2.9.0
>            Reporter: Stephen Saucier
>            Assignee: Claus Ibsen
>            Priority: Minor
>             Fix For: 2.8.4, 2.9.1
>
>
> When the "name" parameter contains a '$', "${" or '}' substring, the getThreadName method will throw an erroneous IllegalArgumentException.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CAMEL-4904) org.apache.camel.util.concurrent.ExecutorServiceHelper.getThreadName(String, String) method throws IllegalArgumentException when name parameter contains '$', "${" or '}'

Posted by "Claus Ibsen (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-4904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187643#comment-13187643 ] 

Claus Ibsen commented on CAMEL-4904:
------------------------------------

Babak

In due time you will be able to make the commit log changes yourself :)

Its not really that important, and just risk something odd **** up with svn/git / syncing and whatnot.
So I would just leave it as is.
                
> org.apache.camel.util.concurrent.ExecutorServiceHelper.getThreadName(String, String) method throws IllegalArgumentException when name parameter contains '$', "${" or '}'
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-4904
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4904
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-core
>    Affects Versions: 2.8.3, 2.9.0
>            Reporter: Stephen Saucier
>            Assignee: Claus Ibsen
>            Priority: Minor
>             Fix For: 2.8.4, 2.9.1
>
>
> When the "name" parameter contains a '$', "${" or '}' substring, the getThreadName method will throw an erroneous IllegalArgumentException.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CAMEL-4904) org.apache.camel.util.concurrent.ExecutorServiceHelper.getThreadName(String, String) method throws IllegalArgumentException when name parameter contains '$', "${" or '}'

Posted by "Stephen Saucier (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-4904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246856#comment-13246856 ] 

Stephen Saucier commented on CAMEL-4904:
----------------------------------------

I am confused -- the bug details indicate that this fix should be present in 2.9.1 and 2.8.4, but as far as I can tell, it isn't in either. 

I am looking at
https://svn.apache.org/repos/asf/camel/tags/camel-2.8.4/camel-core/src/main/java/org/apache/camel/util/concurrent/ExecutorServiceHelper.java
and
https://svn.apache.org/repos/asf/camel/tags/camel-2.9.1/camel-core/src/main/java/org/apache/camel/util/concurrent/ThreadHelper.java

What is in trunk seems okay:
https://svn.apache.org/repos/asf/camel/trunk/camel-core/src/main/java/org/apache/camel/util/concurrent/ThreadHelper.java

Am I missing something? Testing with 2.9.1, my bug still exists.
                
> org.apache.camel.util.concurrent.ExecutorServiceHelper.getThreadName(String, String) method throws IllegalArgumentException when name parameter contains '$', "${" or '}'
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-4904
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4904
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-core
>    Affects Versions: 2.8.3, 2.9.0
>            Reporter: Stephen Saucier
>            Assignee: Claus Ibsen
>            Priority: Minor
>             Fix For: 2.8.4, 2.9.1
>
>
> When the "name" parameter contains a '$', "${" or '}' substring, the getThreadName method will throw an erroneous IllegalArgumentException.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CAMEL-4904) org.apache.camel.util.concurrent.ExecutorServiceHelper.getThreadName(String, String) method throws IllegalArgumentException when name parameter contains '$', "${" or '}'

Posted by "Claus Ibsen (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CAMEL-4904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen updated CAMEL-4904:
-------------------------------

    Affects Version/s: 2.8.3
                       2.9.0
        Fix Version/s: 2.9.1
                       2.8.4
             Assignee: Claus Ibsen
    
> org.apache.camel.util.concurrent.ExecutorServiceHelper.getThreadName(String, String) method throws IllegalArgumentException when name parameter contains '$', "${" or '}'
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-4904
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4904
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-core
>    Affects Versions: 2.8.3, 2.9.0
>            Reporter: Stephen Saucier
>            Assignee: Claus Ibsen
>            Priority: Minor
>             Fix For: 2.8.4, 2.9.1
>
>
> When the "name" parameter contains a '$', "${" or '}' substring, the getThreadName method will throw an erroneous IllegalArgumentException.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CAMEL-4904) org.apache.camel.util.concurrent.ExecutorServiceHelper.getThreadName(String, String) method throws IllegalArgumentException when name parameter contains '$', "${" or '}'

Posted by "Claus Ibsen (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CAMEL-4904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187484#comment-13187484 ] 

Claus Ibsen commented on CAMEL-4904:
------------------------------------

Stephen if you wish to work on a patch, then you can take a look at this commit
http://svn.apache.org/viewvc?rev=1232013&view=rev

Notice the quote replacement code.
                
> org.apache.camel.util.concurrent.ExecutorServiceHelper.getThreadName(String, String) method throws IllegalArgumentException when name parameter contains '$', "${" or '}'
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-4904
>                 URL: https://issues.apache.org/jira/browse/CAMEL-4904
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-core
>    Affects Versions: 2.8.3, 2.9.0
>            Reporter: Stephen Saucier
>            Assignee: Claus Ibsen
>            Priority: Minor
>             Fix For: 2.8.4, 2.9.1
>
>
> When the "name" parameter contains a '$', "${" or '}' substring, the getThreadName method will throw an erroneous IllegalArgumentException.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira