You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "github-actions[bot] (via GitHub)" <gi...@apache.org> on 2024/10/30 17:49:25 UTC

Re: [PR] [fix](cloud-mow) MS should delete the existing keys before rewriting it when processing old version delete bitmap on cu compaction [doris]

github-actions[bot] commented on code in PR #42379:
URL: https://github.com/apache/doris/pull/42379#discussion_r1823125552


##########
be/src/cloud/cloud_cumulative_compaction.cpp:
##########
@@ -353,12 +353,12 @@ Status CloudCumulativeCompaction::modify_rowsets() {
     }
     if (_tablet->keys_type() == KeysType::UNIQUE_KEYS &&
         _tablet->enable_unique_key_merge_on_write() && _input_rowsets.size() != 1) {
-        process_old_version_delete_bitmap();
+        RETURN_IF_ERROR(process_old_version_delete_bitmap());
     }
     return Status::OK();
 }
 
-void CloudCumulativeCompaction::process_old_version_delete_bitmap() {
+Status CloudCumulativeCompaction::process_old_version_delete_bitmap() {

Review Comment:
   warning: function 'process_old_version_delete_bitmap' exceeds recommended size/complexity thresholds [readability-function-size]
   ```cpp
   Status CloudCumulativeCompaction::process_old_version_delete_bitmap() {
                                     ^
   ```
   <details>
   <summary>Additional context</summary>
   
   **be/src/cloud/cloud_cumulative_compaction.cpp:360:** 82 lines including whitespace and comments (threshold 80)
   ```cpp
   Status CloudCumulativeCompaction::process_old_version_delete_bitmap() {
                                     ^
   ```
   
   </details>
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org