You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2020/03/26 09:09:32 UTC

[GitHub] [zeppelin] zjffdu opened a new pull request #3698: [ZEPPELIN-4694]. Limit the number of running interpreter process

zjffdu opened a new pull request #3698: [ZEPPELIN-4694]. Limit the number of running interpreter process
URL: https://github.com/apache/zeppelin/pull/3698
 
 
   ### What is this PR for?
   This is to limit the number of running interpreter process to protect zeppelin machine ran out of memory. By default, you can run at most 10 interpreter processes. To be noticed, this won't impact k8s mode. 
   
   ### What type of PR is it?
   [Feature]
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   * https://issues.apache.org/jira/browse/ZEPPELIN-4694
   
   ### How should this be tested?
   * CI pass and unit test is added
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Does the licenses files need update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] alexott commented on a change in pull request #3698: [ZEPPELIN-4694]. Limit the number of running interpreter process

Posted by GitBox <gi...@apache.org>.
alexott commented on a change in pull request #3698: [ZEPPELIN-4694]. Limit the number of running interpreter process
URL: https://github.com/apache/zeppelin/pull/3698#discussion_r398530129
 
 

 ##########
 File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterManagedProcess.java
 ##########
 @@ -96,6 +100,11 @@ public int getPort() {
 
   @Override
   public void start(String userName) throws IOException {
+
+    if (TOTAL_RUNNING_PROCESS >= MAX_RUNNING_PROCESS) {
+      throw new IOException("You have reached the max number of running interpreter process: "
 
 Review comment:
   it would be nice to change `interpreter process` to `interpreter processes`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services