[jira] [Commented] (ZOOKEEPER-3068) Improve C client logging of IPv6 hosts

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-3068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16520696#comment-16520696 ] 

Hadoop QA commented on ZOOKEEPER-3068:
--------------------------------------

-1 overall.  GitHub Pull Request  Build
      

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1858//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1858//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1858//console

This message is automatically generated.

> Improve C client logging of IPv6 hosts
> --------------------------------------
>
>                 Key: ZOOKEEPER-3068
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3068
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: c client
>    Affects Versions: 3.6.0
>            Reporter: Brian Nixon
>            Assignee: Brian Nixon
>            Priority: Trivial
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The C client formats host-port pairings as [host:port] when logging. This is visually confusing when the host is an IPv6 address (see the below). In that case, it would be preferable to cleanly separate the IPv6 from the port. 
> {code:java}
> ZOO_INFO@check_events@2736: initiated connection to server [2401:db00:1020:40bf:face:0:5:0:2181]{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)