You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/03/27 23:46:20 UTC
[GitHub] [iceberg] rdblue commented on a change in pull request #4393: Aliyun: Add metrics tracking for OSSFileIO
rdblue commented on a change in pull request #4393:
URL: https://github.com/apache/iceberg/pull/4393#discussion_r835980861
##########
File path: aliyun/src/main/java/org/apache/iceberg/aliyun/oss/OSSInputFile.java
##########
@@ -24,17 +24,18 @@
import org.apache.iceberg.exceptions.ValidationException;
import org.apache.iceberg.io.InputFile;
import org.apache.iceberg.io.SeekableInputStream;
+import org.apache.iceberg.metrics.MetricsContext;
-public class OSSInputFile extends BaseOSSFile implements InputFile {
+class OSSInputFile extends BaseOSSFile implements InputFile {
Review comment:
This is technically a breaking change. I think we should roll it back in case anyone references this file. We can deprecate the class so that we can make this change in a release or two.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org