You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/20 15:02:15 UTC

[GitHub] [pulsar] michaeljmarshall opened a new pull request, #18140: [fix][doc] Point Python and C++ docs to new GitHub repos

michaeljmarshall opened a new pull request, #18140:
URL: https://github.com/apache/pulsar/pull/18140

   ### Motivation
   
   With the recent PIP to move the Python and C++ clients to their own GitHub repo, we need to update the documentation.
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [x] `doc`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] michaeljmarshall commented on pull request #18140: [fix][doc] Point Python and C++ docs to new GitHub repos

Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on PR #18140:
URL: https://github.com/apache/pulsar/pull/18140#issuecomment-1285790462

   @merlimat @lhotari - I added links to redirect any users that have bookmarked the client directories


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #18140: [fix][doc] Point Python and C++ docs to new GitHub repos

Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on code in PR #18140:
URL: https://github.com/apache/pulsar/pull/18140#discussion_r1000763051


##########
site2/website/versioned_docs/version-2.10.x/client-libraries-cpp.md:
##########
@@ -654,7 +654,7 @@ Client client("pulsar+ssl://my-broker.com:6651", config);
 
 ```
 
-For complete examples, refer to [C++ client examples](https://github.com/apache/pulsar/tree/master/pulsar-client-cpp/examples).
+For complete examples, refer to [C++ client examples](https://github.com/apache/pulsar-client-cpp/examples).

Review Comment:
   Fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on a diff in pull request #18140: [fix][doc] Point Python and C++ docs to new GitHub repos

Posted by GitBox <gi...@apache.org>.
lhotari commented on code in PR #18140:
URL: https://github.com/apache/pulsar/pull/18140#discussion_r1000760484


##########
site2/website/versioned_docs/version-2.10.x/client-libraries-cpp.md:
##########
@@ -654,7 +654,7 @@ Client client("pulsar+ssl://my-broker.com:6651", config);
 
 ```
 
-For complete examples, refer to [C++ client examples](https://github.com/apache/pulsar/tree/master/pulsar-client-cpp/examples).
+For complete examples, refer to [C++ client examples](https://github.com/apache/pulsar-client-cpp/examples).

Review Comment:
   it seems that `main` is the default branch now. so this url is https://github.com/apache/pulsar-client-cpp/tree/main/examples



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #18140: [fix][doc] Point Python and C++ docs to new GitHub repos

Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on code in PR #18140:
URL: https://github.com/apache/pulsar/pull/18140#discussion_r1000760569


##########
site2/website/versioned_docs/version-2.10.x/client-libraries-cpp.md:
##########
@@ -654,7 +654,7 @@ Client client("pulsar+ssl://my-broker.com:6651", config);
 
 ```
 
-For complete examples, refer to [C++ client examples](https://github.com/apache/pulsar/tree/master/pulsar-client-cpp/examples).
+For complete examples, refer to [C++ client examples](https://github.com/apache/pulsar-client-cpp/examples).

Review Comment:
   Great catch. It should be https://github.com/apache/pulsar-client-cpp/tree/main/examples



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on a diff in pull request #18140: [fix][doc] Point Python and C++ docs to new GitHub repos

Posted by GitBox <gi...@apache.org>.
lhotari commented on code in PR #18140:
URL: https://github.com/apache/pulsar/pull/18140#discussion_r1000759298


##########
site2/website/versioned_docs/version-2.10.x/client-libraries-cpp.md:
##########
@@ -654,7 +654,7 @@ Client client("pulsar+ssl://my-broker.com:6651", config);
 
 ```
 
-For complete examples, refer to [C++ client examples](https://github.com/apache/pulsar/tree/master/pulsar-client-cpp/examples).
+For complete examples, refer to [C++ client examples](https://github.com/apache/pulsar-client-cpp/examples).

Review Comment:
   this url needs to be fixed. please check that subdirectories are properly referenced.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari merged pull request #18140: [fix][doc] Point Python and C++ docs to new GitHub repos

Posted by GitBox <gi...@apache.org>.
lhotari merged PR #18140:
URL: https://github.com/apache/pulsar/pull/18140


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org